refactor: flag some object literals as read only

Signed-off-by: Jérôme Benoit <[email protected]>

Author: jerome-benoit

src/pools/selection-strategies/abstract-worker-choice-strategy.ts

@@ -41,11 +41,12 @@ export abstract class AbstractWorkerChoiceStrategy<
   }
 
   /** @inheritDoc */
-  public readonly taskStatisticsRequirements: TaskStatisticsRequirements = {
-    runTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-    waitTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-    elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-  }
+  public readonly taskStatisticsRequirements: TaskStatisticsRequirements =
+    Object.freeze({
+      runTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
+      waitTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
+      elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
+    })
 
   /**
    * Constructs a worker choice strategy bound to the pool.

src/pools/selection-strategies/fair-share-worker-choice-strategy.ts

@@ -23,7 +23,7 @@ export class FairShareWorkerChoiceStrategy<
   implements IWorkerChoiceStrategy {
   /** @inheritDoc */
   public override readonly taskStatisticsRequirements:
-    TaskStatisticsRequirements = {
+    TaskStatisticsRequirements = Object.freeze({
       runTime: {
         aggregate: true,
         average: true,
@@ -39,7 +39,7 @@ export class FairShareWorkerChoiceStrategy<
         average: true,
         median: false,
       },
-    }
+    })
 
   /** @inheritDoc */
   public constructor(

src/pools/selection-strategies/interleaved-weighted-round-robin-worker-choice-strategy.ts

@@ -23,7 +23,7 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy<
   implements IWorkerChoiceStrategy {
   /** @inheritDoc */
   public override readonly taskStatisticsRequirements:
-    TaskStatisticsRequirements = {
+    TaskStatisticsRequirements = Object.freeze({
       runTime: {
         aggregate: true,
         average: true,
@@ -35,7 +35,7 @@ export class InterleavedWeightedRoundRobinWorkerChoiceStrategy<
         median: false,
       },
       elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-    }
+    })
 
   /**
    * Round id.

src/pools/selection-strategies/least-busy-worker-choice-strategy.ts

@@ -23,7 +23,7 @@ export class LeastBusyWorkerChoiceStrategy<
   implements IWorkerChoiceStrategy {
   /** @inheritDoc */
   public override readonly taskStatisticsRequirements:
-    TaskStatisticsRequirements = {
+    TaskStatisticsRequirements = Object.freeze({
       runTime: {
         aggregate: true,
         average: false,
@@ -35,7 +35,7 @@ export class LeastBusyWorkerChoiceStrategy<
         median: false,
       },
       elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-    }
+    })
 
   /** @inheritDoc */
   public constructor(

src/pools/selection-strategies/least-elu-worker-choice-strategy.ts

@@ -23,15 +23,15 @@ export class LeastEluWorkerChoiceStrategy<
   implements IWorkerChoiceStrategy {
   /** @inheritDoc */
   public override readonly taskStatisticsRequirements:
-    TaskStatisticsRequirements = {
+    TaskStatisticsRequirements = Object.freeze({
       runTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
       waitTime: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
       elu: {
         aggregate: true,
         average: false,
         median: false,
       },
-    }
+    })
 
   /** @inheritDoc */
   public constructor(

src/pools/selection-strategies/weighted-round-robin-worker-choice-strategy.ts

@@ -24,7 +24,7 @@ export class WeightedRoundRobinWorkerChoiceStrategy<
   implements IWorkerChoiceStrategy {
   /** @inheritDoc */
   public override readonly taskStatisticsRequirements:
-    TaskStatisticsRequirements = {
+    TaskStatisticsRequirements = Object.freeze({
       runTime: {
         aggregate: true,
         average: true,
@@ -36,7 +36,7 @@ export class WeightedRoundRobinWorkerChoiceStrategy<
         median: false,
       },
       elu: DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS,
-    }
+    })
 
   /**
    * Worker node virtual task execution time.

src/pools/utils.ts

@@ -36,24 +36,25 @@ export { exportedUpdateMeasurementStatistics }
 /**
  * Default measurement statistics requirements.
  */
-export const DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS:
-  MeasurementStatisticsRequirements = {
-    aggregate: false,
-    average: false,
-    median: false,
-  }
+export const DEFAULT_MEASUREMENT_STATISTICS_REQUIREMENTS: Readonly<
+  MeasurementStatisticsRequirements
+> = Object.freeze({
+  aggregate: false,
+  average: false,
+  median: false,
+})
 
 export const getDefaultTasksQueueOptions = (
   poolMaxSize: number,
-): Required<TasksQueueOptions> => {
-  return {
+): Required<Readonly<TasksQueueOptions>> => {
+  return Object.freeze({
     size: Math.pow(poolMaxSize, 2),
     concurrency: 1,
     taskStealing: true,
     tasksStealingOnBackPressure: true,
     tasksStealingRatio: 0.6,
     tasksFinishedTimeout: 2000,
-  }
+  })
 }
 
 export const checkFileURL = (fileURL: URL | undefined): void => {

src/worker/abstract-worker.ts

@@ -28,7 +28,7 @@ import {
 import { KillBehaviors, type WorkerOptions } from './worker-options.ts'
 
 const DEFAULT_MAX_INACTIVE_TIME = 60000
-const DEFAULT_WORKER_OPTIONS: WorkerOptions = {
+const DEFAULT_WORKER_OPTIONS: Readonly<WorkerOptions> = Object.freeze({
   /**
    * The kill behavior option on this worker or its default value.
    */
@@ -42,7 +42,7 @@ const DEFAULT_WORKER_OPTIONS: WorkerOptions = {
    * The function to call when the worker is killed.
    */
   killHandler: EMPTY_FUNCTION,
-}
+})
 
 /**
  * Base class that implements some shared logic for all poolifier workers.
@@ -59,7 +59,8 @@ export abstract class AbstractWorker<
   /**
    * Worker id.
    */
-  protected abstract id?: `${string}-${string}-${string}-${string}-${string}`
+  protected abstract readonly id?:
+    `${string}-${string}-${string}-${string}-${string}`
   /**
    * Task function(s) object processed by the worker when the pool's `execute` method is invoked.
    */