refactor(queue): cleanup variables namespace

Signed-off-by: Jérôme Benoit <[email protected]>

Author: jerome-benoit

src/queues/abstract-fixed-queue.ts

@@ -77,16 +77,16 @@ export abstract class AbstractFixedQueue<T> implements IFixedQueue<T> {
         --this.size
         return true
       }
-      let physicalShiftIndex = currentPhysicalIndex
+      let shiftPhysicalIndex = currentPhysicalIndex
       for (let i = logicalIndex; i < this.size - 1; i++) {
-        let nextPhysicalIndex = physicalShiftIndex + 1
+        let nextPhysicalIndex = shiftPhysicalIndex + 1
         if (nextPhysicalIndex === this.capacity) {
           nextPhysicalIndex = 0
         }
-        this.nodeArray[physicalShiftIndex] = this.nodeArray[nextPhysicalIndex]
-        physicalShiftIndex = nextPhysicalIndex
+        this.nodeArray[shiftPhysicalIndex] = this.nodeArray[nextPhysicalIndex]
+        shiftPhysicalIndex = nextPhysicalIndex
       }
-      this.nodeArray[physicalShiftIndex] = undefined
+      this.nodeArray[shiftPhysicalIndex] = undefined
       --this.size
       return true
     }

src/queues/fixed-priority-queue.ts

@@ -27,20 +27,21 @@ export class FixedPriorityQueue<T> extends AbstractFixedQueue<T>
         currentPhysicalIndex = 0
       }
     }
-    let end = this.start + this.size
-    if (end >= this.capacity) {
-      end -= this.capacity
+    let endPhysicalIndex = this.start + this.size
+    if (endPhysicalIndex >= this.capacity) {
+      endPhysicalIndex -= this.capacity
     }
     if (insertionPhysicalIndex === -1) {
-      insertionPhysicalIndex = end
+      insertionPhysicalIndex = endPhysicalIndex
     } else {
-      let toShiftIndex = end
-      while (toShiftIndex !== insertionPhysicalIndex) {
-        const previousIndex = toShiftIndex === 0
+      let shiftPhysicalIndex = endPhysicalIndex
+      while (shiftPhysicalIndex !== insertionPhysicalIndex) {
+        const previousPhysicalIndex = shiftPhysicalIndex === 0
           ? this.capacity - 1
-          : toShiftIndex - 1
-        this.nodeArray[toShiftIndex] = this.nodeArray[previousIndex]
-        toShiftIndex = previousIndex
+          : shiftPhysicalIndex - 1
+        this.nodeArray[shiftPhysicalIndex] =
+          this.nodeArray[previousPhysicalIndex]
+        shiftPhysicalIndex = previousPhysicalIndex
       }
     }
     this.nodeArray[insertionPhysicalIndex] = { data, priority }