refactor: cleanup queuing code

Signed-off-by: Jérôme Benoit <[email protected]>

Author: jerome-benoit

src/circular-buffer.ts

@@ -82,13 +82,13 @@ export class CircularBuffer {
    * @returns Numbers' array.
    */
   public toArray(): number[] {
-    const array: number[] = []
     if (this.empty()) {
-      return array
+      return []
     }
+    const array: number[] = new Array<number>(this.size)
     let currentIdx = this.readIdx
     for (let i = 0; i < this.size; i++) {
-      array.push(this.items[currentIdx])
+      array[i] = this.items[currentIdx]
       currentIdx = currentIdx === this.maxArrayIdx ? 0 : currentIdx + 1
     }
     return array
@@ -105,9 +105,9 @@ export class CircularBuffer {
         `Invalid circular buffer size: '${size.toString()}' is not an integer`,
       )
     }
-    if (size < 0) {
+    if (size <= 0) {
       throw new RangeError(
-        `Invalid circular buffer size: ${size.toString()} < 0`,
+        `Invalid circular buffer size: ${size.toString()} <= 0`,
       )
     }
   }

src/queues/abstract-fixed-queue.ts

@@ -47,7 +47,7 @@ export abstract class AbstractFixedQueue<T> implements IFixedQueue<T> {
 
   /** @inheritdoc */
   public get(index: number): T | undefined {
-    if (this.empty() || index >= this.size) {
+    if (this.empty() || index < 0 || index >= this.size) {
       return undefined
     }
     index += this.start

src/queues/priority-queue.ts

@@ -40,8 +40,8 @@ export class PriorityQueue<T> {
         `Invalid bucket size: '${bucketSize.toString()}' is not an integer`,
       )
     }
-    if (bucketSize < 0) {
-      throw new RangeError(`Invalid bucket size: ${bucketSize.toString()} < 0`)
+    if (bucketSize <= 0) {
+      throw new RangeError(`Invalid bucket size: ${bucketSize.toString()} <= 0`)
     }
     this.bucketSize = bucketSize
     this.priorityEnabled = enablePriority

tests/circular-buffer.test.mjs

@@ -27,7 +27,7 @@ describe('Circular buffer test suite', () => {
       new TypeError("Invalid circular buffer size: '0.25' is not an integer"),
     )
     expect(() => new CircularBuffer(-1)).toThrow(
-      new RangeError('Invalid circular buffer size: -1 < 0'),
+      new RangeError('Invalid circular buffer size: -1 <= 0'),
     )
     expect(() => new CircularBuffer(Number.MAX_SAFE_INTEGER + 1)).toThrow(
       new TypeError(

tests/queues/priority-queue.test.mjs

@@ -12,7 +12,7 @@ describe('Priority queue test suite', () => {
       new TypeError("Invalid bucket size: '' is not an integer"),
     )
     expect(() => new PriorityQueue(-1)).toThrow(
-      new RangeError('Invalid bucket size: -1 < 0'),
+      new RangeError('Invalid bucket size: -1 <= 0'),
     )
     let priorityQueue = new PriorityQueue()
     expect(priorityQueue.bucketSize).toBe(defaultBucketSize)