refactor: make pool destroy() more robust

Signed-off-by: Jérôme Benoit <[email protected]>

Author: jerome-benoit

deno.json

@@ -3,9 +3,7 @@
   "version": "0.5.11",
   "exports": "./src/mod.ts",
   "compilerOptions": {
-    "lib": [
-      "deno.worker"
-    ],
+    "lib": ["deno.worker"],
     "strict": true
   },
   "tasks": {
@@ -27,9 +25,7 @@
     "documentation": "deno doc ./src/mod.ts"
   },
   "test": {
-    "include": [
-      "./tests/**/*.test.mjs"
-    ]
+    "include": ["./tests/**/*.test.mjs"]
   },
   "fmt": {
     "semiColons": false,
@@ -42,18 +38,8 @@
     "@std/testing": "jsr:@std/testing@^1.0.15"
   },
   "publish": {
-    "include": [
-      "LICENSE",
-      "README.md",
-      "deno.json",
-      "src/**/*.ts"
-    ]
+    "include": ["LICENSE", "README.md", "deno.json", "src/**/*.ts"]
   },
   "lock": false,
-  "exclude": [
-    "./coverage",
-    "./dist/browser",
-    "./dist/esm",
-    "./npm"
-  ]
+  "exclude": ["./coverage", "./dist/browser", "./dist/esm", "./npm"]
 }

src/pools/abstract-pool.ts

@@ -1323,20 +1323,31 @@ export abstract class AbstractPool<
       throw new Error('Cannot destroy an already destroying pool')
     }
     this.destroying = true
-    await Promise.all(
-      this.workerNodes.map(async (_, workerNodeKey) => {
-        await this.destroyWorkerNode(workerNodeKey)
-      }),
-    )
-    if (this.eventTarget != null) {
-      this.eventTarget.dispatchEvent(
-        new CustomEvent<PoolInfo>(PoolEvents.destroy, { detail: this.info }),
+    try {
+      await Promise.allSettled(
+        this.workerNodes.map(async (_, workerNodeKey) => {
+          try {
+            await this.destroyWorkerNode(workerNodeKey)
+          } catch (error) {
+            if (this.eventTarget != null) {
+              this.eventTarget.dispatchEvent(
+                new ErrorEvent(PoolEvents.error, { error }),
+              )
+            }
+          }
+        }),
       )
-      this.readyEventEmitted = false
+    } finally {
+      if (this.eventTarget != null) {
+        this.eventTarget.dispatchEvent(
+          new CustomEvent<PoolInfo>(PoolEvents.destroy, { detail: this.info }),
+        )
+        this.readyEventEmitted = false
+      }
+      delete this.startTimestamp
+      this.destroying = false
+      this.started = false
     }
-    delete this.startTimestamp
-    this.destroying = false
-    this.started = false
   }
 
   private async sendKillMessageToWorker(