Skip to content

Commit b0f1ee0

Browse files
committed
fix: do not leak task at abortion
Signed-off-by: Jérôme Benoit <[email protected]>
1 parent e289c1d commit b0f1ee0

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

src/pools/abstract-pool.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1913,7 +1913,6 @@ export abstract class AbstractPool<
19131913
(this.info.stealingWorkerNodes ?? 0) >
19141914
Math.ceil(
19151915
this.workerNodes.length *
1916-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
19171916
this.opts.tasksQueueOptions!.tasksStealingRatio!,
19181917
)
19191918
)
@@ -2258,6 +2257,7 @@ export abstract class AbstractPool<
22582257
if (taskId === task.taskId && abortable === true) {
22592258
workerNode.info.queuedTaskAbortion = true
22602259
workerNode.deleteTask(task)
2260+
this.promiseResponseMap.delete(taskId!)
22612261
workerNode.info.queuedTaskAbortion = false
22622262
reject(this.getAbortError(name!, taskId!))
22632263
return

src/worker/abstract-worker.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,10 +592,8 @@ export abstract class AbstractWorker<
592592
}
593593
let fn: TaskFunction<Data, Response>
594594
if (abortable === true) {
595-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
596595
fn = this.getAbortableTaskFunction(taskFunctionName, taskId!)
597596
} else {
598-
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
599597
fn = this.taskFunctions.get(taskFunctionName)!.taskFunction
600598
}
601599
if (isAsyncFunction(fn)) {

0 commit comments

Comments
 (0)