Skip to content

Commit e1fbde5

Browse files
committed
refactor: improve messaging worker id check error message
Signed-off-by: Jérôme Benoit <[email protected]>
1 parent b2c42ef commit e1fbde5

File tree

3 files changed

+19
-23
lines changed

3 files changed

+19
-23
lines changed

deno.json

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@
33
"version": "0.5.3",
44
"exports": "./src/mod.ts",
55
"compilerOptions": {
6-
"lib": [
7-
"deno.worker"
8-
],
6+
"lib": ["deno.worker"],
97
"strict": true
108
},
119
"tasks": {
@@ -26,9 +24,7 @@
2624
"documentation": "deno doc ./src/mod.ts"
2725
},
2826
"test": {
29-
"include": [
30-
"./tests/**/*.test.mjs"
31-
]
27+
"include": ["./tests/**/*.test.mjs"]
3228
},
3329
"fmt": {
3430
"semiColons": false,
@@ -41,18 +37,8 @@
4137
"@std/testing": "jsr:@std/testing@^1.0.14"
4238
},
4339
"publish": {
44-
"include": [
45-
"LICENSE",
46-
"README.md",
47-
"deno.json",
48-
"src/**/*.ts"
49-
]
40+
"include": ["LICENSE", "README.md", "deno.json", "src/**/*.ts"]
5041
},
5142
"lock": false,
52-
"exclude": [
53-
"./coverage",
54-
"./dist/browser",
55-
"./dist/esm",
56-
"./npm"
57-
]
43+
"exclude": ["./coverage", "./dist/browser", "./dist/esm", "./npm"]
5844
}

src/pools/abstract-pool.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -546,15 +546,19 @@ export abstract class AbstractPool<
546546
*/
547547
private checkMessageWorkerId(message: MessageValue<Data | Response>): void {
548548
if (message.workerId == null) {
549-
throw new Error('Worker message received without worker id')
549+
throw new Error(
550+
`Worker message '${
551+
JSON.stringify(message)
552+
}' received without worker id`,
553+
)
550554
}
551555
if (this.getWorkerNodeKeyByWorkerId(message.workerId) === -1) {
552556
throw new Error(
553-
`Worker message received from unknown worker '${message.workerId.toString()}': ${
557+
`Worker message '${
554558
JSON.stringify(
555559
message,
556560
)
557-
}`,
561+
}' received from unknown worker ${message.workerId.toString()}`,
558562
)
559563
}
560564
}

src/worker/abstract-worker.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,11 +468,17 @@ export abstract class AbstractWorker<
468468
*/
469469
private checkMessageWorkerId(message: MessageValue<Data>): void {
470470
if (message.workerId == null) {
471-
throw new Error('Message worker id is not set')
471+
throw new Error(
472+
`Message worker id is not set: ${JSON.stringify(message)}`,
473+
)
472474
}
473475
if (message.workerId !== this.id) {
474476
throw new Error(
475-
`Message worker id ${message.workerId.toString()} does not match the worker id ${this.id}`,
477+
`Message worker id ${message.workerId.toString()} does not match the worker id ${this.id}: ${
478+
JSON.stringify(
479+
message,
480+
)
481+
}`,
476482
)
477483
}
478484
}

0 commit comments

Comments
 (0)