More refactors for perf

Author: Cheong-Lau

cosmic-applet-audio/src/lib.rs

@@ -490,13 +490,11 @@ impl cosmic::Application for Audio {
                     match msg {
                         // This is where we match messages from the subscription to app state
                         pulse::Message::SetSinks(sinks) => self.outputs = sinks,
-                        pulse::Message::SetSources(sources) => {
-                            self.inputs = sources
-                                .into_iter()
-                                .filter(|source| {
-                                    !source.name.as_ref().is_some_and(|n| n.contains("monitor"))
-                                })
-                                .collect()
+                        pulse::Message::SetSources(mut sources) => {
+                            sources.retain(|source| {
+                                !source.name.as_ref().is_some_and(|n| n.contains("monitor"))
+                            });
+                            self.inputs = sources;
                         }
                         pulse::Message::SetDefaultSink(sink) => {
                             self.update_output(Some(sink));
@@ -824,13 +822,7 @@ impl cosmic::Application for Audio {
                         Some(output) => pretty_name(output.description.clone()),
                         None => String::from("No device selected"),
                     },
-                    self.outputs
-                        .iter()
-                        .map(|output| (
-                            output.name.clone().unwrap_or_default(),
-                            pretty_name(output.description.clone())
-                        ))
-                        .collect(),
+                    self.outputs.as_slice(),
                     Message::OutputToggle,
                     Message::OutputChanged,
                 ),
@@ -841,13 +833,7 @@ impl cosmic::Application for Audio {
                         Some(input) => pretty_name(input.description.clone()),
                         None => fl!("no-device"),
                     },
-                    self.inputs
-                        .iter()
-                        .map(|input| (
-                            input.name.clone().unwrap_or_default(),
-                            pretty_name(input.description.clone())
-                        ))
-                        .collect(),
+                    self.inputs.as_slice(),
                     Message::InputToggle,
                     Message::InputChanged,
                 )
@@ -975,17 +961,23 @@ fn revealer(
     open: bool,
     title: String,
     selected: String,
-    options: Vec<(String, String)>,
+    device_info: &[DeviceInfo],
     toggle: Message,
     mut change: impl FnMut(String) -> Message + 'static,
 ) -> widget::Column<'static, Message, crate::Theme, Renderer> {
     if open {
-        options.iter().fold(
+        let options = device_info.iter().map(|device| {
+            (
+                device.name.clone().unwrap_or_default(),
+                pretty_name(device.description.clone()),
+            )
+        });
+        options.fold(
             column![revealer_head(open, title, selected, toggle)].width(Length::Fill),
             |col, (id, name)| {
                 col.push(
-                    menu_button(text::body(name.clone()))
-                        .on_press(change(id.clone()))
+                    menu_button(text::body(name))
+                        .on_press(change(id))
                         .width(Length::Fill)
                         .padding([8, 48]),
                 )

cosmic-applet-notifications/src/subscriptions/notifications.rs

@@ -80,7 +80,7 @@ pub fn notifications(proxy: NotificationsAppletProxy<'static>) -> Subscription<O
                         cosmic::iced::futures::select! {
                             v = next_signal => {
                                 if let Some(msg) = v {
-                                    let Some(args) = msg.args().into_iter().next() else {
+                                    let Ok(args) = msg.args() else {
                                         break;
                                     };
                                     let notification = Notification::new(