perf: use unstable sorting when async

Unstable sorting should be slightly faster than stable sorting, and if
the vector was built asynchronously then preserving the initial order
doesn't matter too much.

Continue to use stable sorting where the vector is not built
asynchronously, or if the vector is partially sorted (e.g. when new
elements are pushed to a sorted vector).

Author: Cheong-Lau

cosmic-applet-audio/src/mpris_subscription.rs

@@ -171,7 +171,7 @@ impl State {
         filter_firefox_players(&mut players);
 
         // pre-sort by path so that the same player is always selected
-        players.sort_by(|a, b| a.name().cmp(b.name()));
+        players.sort_unstable_by(|a, b| a.name().cmp(b.name()));
 
         let mut state = Self {
             conn,

cosmic-applet-bluetooth/src/bluetooth.rs

@@ -808,6 +808,6 @@ async fn build_device_list(mut devices: Vec<BluerDevice>, adapter: &Adapter) ->
         devices.push(device);
     }
 
-    devices.sort();
+    devices.sort_unstable();
     devices
 }

cosmic-applet-network/src/network_manager/available_wifi.rs

@@ -77,7 +77,7 @@ pub async fn handle_wireless_device(
         );
     }
     let mut aps = aps.into_values().collect::<Vec<_>>();
-    aps.sort_by_key(|ap| ap.strength);
+    aps.sort_unstable_by_key(|ap| ap.strength);
     Ok(aps)
 }
 

cosmic-applet-network/src/network_manager/current_networks.rs

@@ -71,7 +71,7 @@ pub async fn active_connections(
         }
     }
 
-    info.sort();
+    info.sort_unstable();
     Ok(info)
 }
 

cosmic-applet-network/src/network_manager/mod.rs

@@ -420,15 +420,15 @@ impl NetworkManagerState {
         let s = NetworkManagerSettings::new(conn).await?;
         _ = s.load_connections(&[]).await;
         let known_conns = s.list_connections().await.unwrap_or_default();
-        let mut active_conns = active_connections(
+        let active_conns = active_connections(
             network_manager
                 .active_connections()
                 .await
                 .unwrap_or_default(),
         )
         .await
         .unwrap_or_default();
-        active_conns.sort();
+        // active_conns.sort(); active_connections should have already sorted the vector
         let devices = network_manager.devices().await.ok().unwrap_or_default();
         let wireless_access_point_futures: Vec<_> = devices
             .into_iter()