fix: allow hiding and showing empty windows

Author: wash2

cosmic-panel-bin/src/space/layout.rs

@@ -67,7 +67,7 @@ impl PanelSpace {
         let mut right_overflow_button = None;
         let mut center_overflow_button = None;
 
-        let to_map = self
+        let mut to_map = self
             .space
             .elements()
             .cloned()

cosmic-panel-bin/src/space/panel_space.rs

@@ -75,7 +75,7 @@ use smithay::{
         compositor::with_states,
         fractional_scale::with_fractional_scale,
         seat::WaylandFocus,
-        shell::xdg::{PopupSurface, PositionerState},
+        shell::xdg::{PopupSurface, PositionerState, ToplevelSurface},
     },
 };
 use tokio::sync::{mpsc, oneshot};
@@ -313,6 +313,7 @@ pub struct PanelSpace {
     pub c_display: Option<WlDisplay>,
     pub config: CosmicPanelConfig,
     pub space: Space<CosmicMappedInternal>,
+    pub unmapped_windows: Vec<CosmicMappedInternal>,
     pub damage_tracked_renderer: Option<OutputDamageTracker>,
     pub clients_left: Clients,
     pub clients_center: Clients,
@@ -396,6 +397,7 @@ impl PanelSpace {
             config,
             shared: shared.clone(),
             space: Space::default(),
+            unmapped_windows: Vec::new(),
             overflow_left: Space::default(),
             overflow_center: Space::default(),
             overflow_right: Space::default(),
@@ -1940,6 +1942,55 @@ impl PanelSpace {
             });
         }
     }
+
+    pub fn minimize_window(&mut self, surface: ToplevelSurface) -> bool {
+        let w = self
+            .space
+            .elements()
+            .find(|e| {
+                if let CosmicMappedInternal::Window(w) = e {
+                    if let Some(t) = w.toplevel() {
+                        return *t == surface;
+                    }
+                }
+                false
+            })
+            .cloned();
+
+        if let Some(window) = w {
+            self.space.unmap_elem(&window);
+            self.unmapped_windows.push(window);
+            true
+        } else {
+            false
+        }
+    }
+
+    pub fn unminimize_window(&mut self, surface: ToplevelSurface) -> bool {
+        let pos = self.unmapped_windows.iter().position(|e| {
+            if let CosmicMappedInternal::Window(w) = e {
+                if let Some(t) = w.toplevel() {
+                    return *t == surface;
+                }
+            }
+            false
+        });
+
+        if let Some(idx) = pos {
+            let window = self.unmapped_windows.remove(idx);
+            if let Some(wl_surface) = window.wl_surface() {
+                with_states(&wl_surface, |states| {
+                    with_fractional_scale(states, |fractional_scale| {
+                        fractional_scale.set_preferred_scale(self.scale);
+                    });
+                });
+            }
+            self.space.map_element(window, (0, 0), false);
+            true
+        } else {
+            false
+        }
+    }
 }
 
 impl Drop for PanelSpace {

cosmic-panel-bin/src/space_container/space_container.rs

@@ -36,6 +36,7 @@ use smithay::{
     backend::renderer::gles::GlesRenderer,
     output::Output,
     reexports::wayland_server::{self, backend::ClientId},
+    wayland::shell::xdg::ToplevelSurface,
 };
 use tokio::sync::mpsc;
 use tracing::{error, info};
@@ -569,4 +570,20 @@ impl SpaceContainer {
             );
         }
     }
+
+    pub(crate) fn minimize_window(&mut self, surface: ToplevelSurface) {
+        for space in &mut self.space_list {
+            if space.minimize_window(surface.clone()) {
+                break;
+            }
+        }
+    }
+
+    pub(crate) fn maximize_window(&mut self, surface: ToplevelSurface) {
+        for space in &mut self.space_list {
+            if space.unminimize_window(surface.clone()) {
+                break;
+            }
+        }
+    }
 }

cosmic-panel-bin/src/xdg_shell_wrapper/server/handlers/xdg_shell.rs

@@ -114,6 +114,14 @@ impl XdgShellHandler for GlobalState {
     fn popup_destroyed(&mut self, surface: PopupSurface) {
         self.server_state.popup_manager.commit(surface.wl_surface());
     }
+
+    fn minimize_request(&mut self, surface: ToplevelSurface) {
+        self.space.minimize_window(surface.clone());
+    }
+
+    fn maximize_request(&mut self, surface: ToplevelSurface) {
+        self.space.maximize_window(surface.clone());
+    }
 }
 
 // Xdg Shell