fix(about): deduplicate OpenGL GPU name variants in About page#1906
Merged
leviport merged 2 commits intopop-os:masterfrom Mar 24, 2026
Merged
fix(about): deduplicate OpenGL GPU name variants in About page#1906leviport merged 2 commits intopop-os:masterfrom
leviport merged 2 commits intopop-os:masterfrom
Conversation
Normalize GPU names before fallback name-based deduplication so OpenGL renderer suffixes like '/PCIe/SSE2' do not create duplicate NVIDIA entries in About. Signed-off-by: manascb1344 <zephop76593@gmail.com>
Contributor
Author
|
The commit 415e1d8 was merged to master without proper formatting, so the CI failure exists |
mmstick
approved these changes
Mar 24, 2026
leviport
approved these changes
Mar 24, 2026
Member
leviport
left a comment
leviport
left a comment
There was a problem hiding this comment.
Seems to work as intended. Thanks!
Details
Regression testing passed:Network & Wireless
Wi-Fi
- Able to disconnect from and connect to a network.
Bluetooth
- Bluetooth device connects.
- Paired device can be disconnected & reconnected.
- Paired device can be forgotten & connecting again works.
Desktop
Wallpaper
- Clicking a different wallpaper switches to it immediately
- Leaving the page and coming back does not change the wallpaper
Appearance
- Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
- Changing the accent color works.
- Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
- Changing the interface density works.
Panel
- Enable tiling. "Automatically hide panel" takes effect immediately.
- Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.
Dock
- Enable tiling. "Automatically hide dock" takes effect immediately.
- Disable tiling; maximize a window. "Autommatically hide dock" takes effect immediately.
- Changing position on screen works.
- All Style settings take effect as expected.
Displays
- Plug in a second display. Displays can be rearranged via dragging.
Sound
TBD after devices/profiles are fixed.
Power & Battery
- Changing power mode takes effect and is reflected by top panel applet.
Input Devices
Touchpad
- All click behavior settings work as expected.
- All scrolling settings work as expected.
Applications
Default Applications
- Changing the default terminal affects Super-T shortcut.
X11 Applications Compatibility
- Global Shortcuts in X11 Applications works (in e.g. Discord).
Time & Language
Date & Time
- Changing time zome works.
- Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
- Toggling seconds takes effect in Settings preview and on top panel.
- Changing first day of week takes effect in Calendar applet.
- Turning date on/off for applet works.
System & Accounts
About
- Changing hostname works (check terminal prompt).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1814
Problem
When a system has an NVIDIA GPU, wgpu enumerates it twice:
"NVIDIA GeForce RTX 3080 Ti Laptop GPU""NVIDIA GeForce RTX 3080 Ti Laptop GPU/PCIe/SSE2"The OpenGL variant includes a renderer suffix (
/PCIe/SSE2) which causes the name-based deduplication to fail, resulting in duplicate GPU entries in Settings -> System -> About.Solution
Add
normalize_gpu_name()helper that strips OpenGL renderer suffixes (everything after/) before comparing names for deduplication. This ensures both Vulkan and OpenGL representations of the same GPU are correctly identified as duplicates.Changes
cosmic-settings/src/pages/system/info.rs:normalize_gpu_name()function with doc commentwgpu_graphics()to use normalized names forseen_namesHashSetTesting
cargo fmt --checkpassescargo clippy --all-featurespasses (no new warnings)cargo test --all-featurespasses (3/3 tests)just check-featurespassesChecklist