small pausing bug fixes and lints

Author: 13r0ck

README.md

@@ -17,7 +17,7 @@ TODOs before release:
 - [ ] Documentation
 - [ ] Add `Cosmic` cargo feature for compatibility with both iced and System76's temporary fork.
 - [x] optimize for `as_subscription` logic
-- [ ] Add pause for looping animations
+- [x] Add pause for animations
 
 Other TODOs:
 - [x] test for easing

examples/stopwatch/src/main.rs

@@ -1,7 +1,6 @@
 use iced::alignment;
 use iced::executor;
-use iced::time;
-use iced::widget::{button, column, container, row, text};
+use iced::widget::{button, column, row, text};
 use iced::{Alignment, Application, Command, Event, Length, Settings, Subscription};
 
 mod theme;
@@ -54,7 +53,7 @@ impl Application for Stopwatch {
         timeline.set_chain_paused(anim_background()).start();
         (
             Stopwatch {
-                timeline: timeline,
+                timeline,
                 duration: Duration::default(),
                 state: State::Idle,
             },
@@ -106,13 +105,7 @@ impl Application for Stopwatch {
     }
 
     fn subscription(&self) -> Subscription<Message> {
-        Subscription::batch(vec![
-            match self.state {
-                State::Idle => Subscription::none(),
-                State::Ticking { .. } => time::every(Duration::from_millis(10)).map(Message::Tick),
-            },
-            self.timeline.as_subscription::<Event>().map(Message::Tick),
-        ])
+        self.timeline.as_subscription::<Event>().map(Message::Tick)
     }
 
     fn view(&self) -> Element<Message> {

examples/stopwatch/src/theme.rs

@@ -8,10 +8,9 @@
  *
  */
 
-use iced::theme::palette::{self, Background};
 use iced::widget::{button, container, text};
 use iced::Background as B;
-use iced::{application, color, Color, Vector};
+use iced::{application, color, Vector};
 
 #[derive(Default)]
 pub struct Theme;
@@ -76,6 +75,7 @@ impl container::StyleSheet for Theme {
 }
 
 #[derive(Default)]
+#[allow(dead_code)]
 pub enum Button {
     #[default]
     Primary,
@@ -98,7 +98,6 @@ impl button::StyleSheet for Theme {
                 border_width: 10.0,
                 shadow_offset: Vector::new(3., 3.),
                 border_color: color!(0x25, 0x63, 0xeb),
-                ..Default::default()
             },
             Button::Secondary => button::Appearance {
                 background: color!(0x3c, 0x38, 0x36).into(),
@@ -114,7 +113,6 @@ impl button::StyleSheet for Theme {
                 shadow_offset: Vector::new(5., 5.),
                 border_color: color!(0xdc, 0x26, 0x26),
                 border_width: 10.0,
-                ..Default::default()
             },
             _ => panic!("This isn't a custom style exmaple, just skipping these for now"),
         }

src/timeline.rs

@@ -59,6 +59,7 @@ struct PendingChain {
 }
 
 impl PendingChain {
+    #[allow(clippy::new_ret_no_self)]
     pub fn new(
         id: widget::Id,
         repeat: Repeat,
@@ -123,9 +124,9 @@ impl Meta {
 
     pub fn pause(&mut self, now: Instant) {
         if let Pause::Resumed(delay) = self.pause {
-            self.pause = Pause::Paused(relative_time(&(now - delay), &self));
+            self.pause = Pause::Paused(relative_time(&(now - delay), self));
         } else {
-            self.pause = Pause::Paused(relative_time(&now, &self));
+            self.pause = Pause::Paused(relative_time(&now, self));
         }
     }
 
@@ -149,10 +150,7 @@ pub enum Pause {
 
 impl Pause {
     pub fn is_playing(&self) -> bool {
-        match self {
-            Pause::Paused(_) => false,
-            _ => true,
-        }
+      !matches!(self, Pause::Paused(_))
     }
 }
 
@@ -298,7 +296,7 @@ impl Timeline {
     }
 
     pub fn start(&mut self) {
-        self.start_at(self.now);
+        self.start_at(Instant::now());
     }
 
     pub fn start_at(&mut self, now: Instant) {
@@ -416,9 +414,6 @@ impl Timeline {
                             modifier.value,
                             modifier.ease.tween(elapsed / duration),
                         );
-                        if index == 8 && meta.length == Duration::from_secs(4) {
-                            println!("({percent}%) relative_now = {:?}", relative_now);
-                        }
 
                         return Some(Interped {
                             previous,