Windows build brocken in Main branch

[snoweuph]

Hi, it looks like building for windows is currently brocken.
using 197049945935f0e0c2d1e42e5c0ff136dd4146ce (latest on main rn)

cargo build --target x86_64-pc-windows-gnu
   Compiling accesskit_winit v0.30.0 (https://github.com/wash2/accesskit?tag=cosmic-0.14#f0599eed)
error[E0782]: expected a type, found a trait
  --> /home/snoweuph/.local/share/cargo/git/checkouts/accesskit-c5e0fd64a779e7b6/f0599ee/platforms/winit/src/platform_impl/windows.rs:20:18
   |
20 |         window: &Window,
   |                  ^^^^^^
   |
help: use a new generic type parameter, constrained by `Window`
   |
18 ~     pub fn new<T: Window>(
19 |         _event_loop: &dyn ActiveEventLoop,
20 ~         window: &T,
   |
help: you can also use an opaque type, but users won't be able to specify the type parameter when calling the `fn`, having to rely exclusively on type inference
   |
20 |         window: &impl Window,
   |                  ++++
help: alternatively, use a trait object to accept any type that implements `Window`, accessing its methods at runtime using dynamic dispatch
   |
20 |         window: &dyn Window,
   |                  +++

Cargo.toml

[target.'cfg(target_os = "linux")'.dependencies.libcosmic]
git = "https://github.com/pop-os/libcosmic.git"
rev = "197049945935f0e0c2d1e42e5c0ff136dd4146ce"
default-features = false
features = ["a11y", "about", "multi-window", "smol", "winit", "wayland", "wgpu"]

[target.'cfg(not(target_os = "linux"))'.dependencies.libcosmic]
git = "https://github.com/pop-os/libcosmic.git"
rev = "197049945935f0e0c2d1e42e5c0ff136dd4146ce"
default-features = false
features = ["a11y", "about", "multi-window", "smol", "winit", "wgpu"]

I am cross compiling using mingw, but that shouldn't matter as this is clearly not a cross platform problem

[snoweuph]

or is accessibility not supported on windows?

[snoweuph]

removing a11y gives me

cargo build --target x86_64-pc-windows-gnu --keep-going
   Compiling iced_winit v0.14.0 (https://github.com/pop-os/libcosmic.git?rev=197049945935f0e0c2d1e42e5c0ff136dd4146ce#19704994)
error[E0433]: failed to resolve: could not find `Event` in `winit`
   --> /home/snoweuph/.local/share/cargo/git/checkouts/libcosmic-41009aea1d72760b/1970499/iced/winit/src/lib.rs:298:36
    |
298 | ...                   winit::Event::AboutToWait,
    |                              ^^^^^ could not find `Event` in `winit`
    |
help: consider importing one of these enums
    |
 25 + use crate::Event;
    |
 25 + use crate::core::Event;
    |
 25 + use crate::core::input_method::Event;
    |
 25 + use crate::core::touch::Event;
    |
    = and 7 other candidates
help: if you import `Event`, refer to it directly
    |
298 -                             winit::Event::AboutToWait,
298 +                             Event::AboutToWait,
    |

error[E0599]: no variant or associated item named `EventLoopAwakened` found for enum `Event<Message>` in the current scope
   --> /home/snoweuph/.local/share/cargo/git/checkouts/libcosmic-41009aea1d72760b/1970499/iced/winit/src/lib.rs:297:37
    |
297 |                         Some(Event::EventLoopAwakened(
    |                                     ^^^^^^^^^^^^^^^^^ variant or associated item not found in `Event<_>`
...
668 | enum Event<Message: 'static> {
    | ---------------------------- variant or associated item `EventLoopAwakened` not found for this enum

Some errors have detailed explanations: E0433, E0599.
For more information about an error, try `rustc --explain E0433`.
error: could not compile `iced_winit` (lib) due to 2 previous errors

so theres still some more problems....

[snoweuph]

same problems on latest rev 14a5d0c0ba60b95e5b244414da041df36148edc8#14a5d0c0

[snoweuph]

same problem on latest rev 03d0171bbe36664b4749c2b70297a288f35df59f

[snoweuph]

still happening with latest rev ff6454248ff0f2ffe889798ef9610a1f8e5384e4

[snoweuph]

I though this was cross platform 👀

Could we plz get some tagging on this, so as a dev you know which revs are considered "stable" ?

[snoweuph]

Looks like e10459fb375d6a84e4ad296df98b1af610fcc531 broke windows builds

[snoweuph]

Looks like e10459fb375d6a84e4ad296df98b1af610fcc531 broke windows builds

I can still build on the rev right before it: 86dcf8af6cfcb3ab65e41649e4793f47c5595433 for windows

[target.'cfg(not(target_os = "linux"))'.dependencies.libcosmic]
git = "https://github.com/pop-os/libcosmic.git"
rev = "86dcf8af6cfcb3ab65e41649e4793f47c5595433"
default-features = false
features = ["tokio", "winit"]

[wiiznokes]

It will work eventually chill. Iced works on windows so it's just a matter of time

[snoweuph]

I mean, the docs state that it works.
also the getting started with libcosmic guide 👀

so I'm basicly using this issue as a way to document what i've tryed in the case anybody else cares.

[snoweuph]

I though this was cross platform 👀

Could we plz get some tagging on this, so as a dev you know which revs are considered "stable" ?

btw any feedback regarding that?
Tags would help massively, to know what rev to use

[sensn]

I was able to build (Some) examples on Windows with editing both Cargo.toml files (libcosmic and the examples one). In the examples (application) folders Cargo.toml:

[package]
name = "application"
version = "0.1.0"
edition = "2021"

[features]
default = []
#default = ["wayland"]
#wayland = ["libcosmic/wayland"]

[dependencies]
tracing = "0.1.44"
tracing-subscriber = "0.3.22"
tracing-log = "0.2.0"

[dependencies.libcosmic]
path = "../../"
features = [
    "debug",
    "winit",
    "tokio",
    #"xdg-portal",
    #"a11y",
    "wgpu",
    #"single-instance",
    "surface-message",
]

and in libcosmics toml i had to change to:

[package]
name = "libcosmic"
version = "1.0.0"
edition = "2024"
rust-version = "1.90"

[lib]
name = "cosmic"

[features]
#default = ["dbus-config", "multi-window", "a11y"]
default = ["multi-window"]
# Accessibility support
a11y = ["iced/a11y", "iced_accessibility"]
# Enable about widget
about = []
# Builds support for animated images
animated-image = ["dep:async-fs", "image/gif", "tokio?/io-util", "tokio?/fs"]
# XXX autosize should not be used on winit windows unless dialogs
autosize = []
applet = [
    "autosize",
    "winit",
    "wayland",
    "tokio",
    "cosmic-panel-config",
    "ron",
    "multi-window",
]
applet-token = ["applet"]
# Use the cosmic-settings-daemon for config handling on Linux targets
dbus-config = []
# Debug features
debug = ["iced/debug"]
# Enables pipewire support in ashpd, if ashpd is enabled
pipewire = ["ashpd?/pipewire"]
# Enables process spawning helper
process = ["dep:libc", "dep:rustix"]
# Use rfd for file dialogs
rfd = ["dep:rfd"]
# Enables desktop files helpers
desktop = [
    "process",
    "dep:cosmic-settings-config",
    "dep:freedesktop-desktop-entry",
    "dep:mime",
    "dep:shlex",
    "tokio?/io-util",
    "tokio?/net",
]
# Enables launching desktop files inside systemd scopes
desktop-systemd-scope = ["desktop", "dep:zbus"]
# Enables keycode serialization
serde-keycode = ["iced_core/serde"]
# Prevents multiple separate process instances.
single-instance = ["zbus/blocking-api", "ron"]
# smol async runtime
smol = ["dep:smol", "iced/smol", "zbus?/async-io", "rfd?/async-std"]
tokio = [
    "dep:tokio",
    "ashpd?/tokio",
    "iced/tokio",
    "rfd?/tokio",
    "zbus?/tokio",
    "cosmic-config/tokio",
]
# Tokio async runtime
# Wayland window support
wayland = [
    "ashpd?/wayland",
    "autosize",
    "iced_runtime/wayland",
    "iced/wayland",
    "iced_winit/wayland",
    "cctk",
    "surface-message",
]
surface-message = []
# multi-window support
multi-window = ["iced/multi-window"]
# Render with wgpu
wgpu = ["iced/wgpu", "iced_wgpu"]
# X11 window support via winit
winit = ["iced/winit", "iced_winit"]
winit_debug = ["winit", "debug"]
winit_tokio = ["winit", "tokio"]
winit_wgpu = ["winit", "wgpu"]
# Enables XDG portal integrations
xdg-portal = ["ashpd"]
qr_code = ["iced/qr_code"]
markdown = ["iced/markdown"]
highlighter = ["iced/highlighter"]
async-std = [
    "dep:async-std",
    "ashpd?/async-std",
    "rfd?/async-std",
    "zbus?/async-io",
    "iced/async-std",
]

[dependencies]
apply = "0.3.0"

async-fs = { version = "2.2", optional = true }
async-std = { version = "1.13", optional = true }
auto_enums = "0.8.7"
cctk = { git = "https://github.com/pop-os/cosmic-protocols", package = "cosmic-client-toolkit", rev = "d0e95be", optional = true }
chrono = "0.4.43"
cosmic-config = { path = "cosmic-config" }
cosmic-settings-config = { git = "https://github.com/pop-os/cosmic-settings-daemon", optional = true }
# Internationalization
i18n-embed = { version = "0.16.0", features = [
    "fluent-system",
    "desktop-requester",
] }
i18n-embed-fl = "0.10"
rust-embed = "8.11.0"
css-color = "0.2.8"
derive_setters = "0.1.8"
futures = "0.3"
image = { version = "0.25.9", default-features = false, features = [
    "jpeg",
    "png",
] }
libc = { version = "0.2.180", optional = true }
log = "0.4"
mime = { version = "0.3.17", optional = true }
palette = "0.7.6"
raw-window-handle = "0.6"
rfd = { version = "0.16.0", default-features = false, features = [
    "xdg-portal",
], optional = true }
rustix = { version = "1.1", features = ["pipe", "process"], optional = true }
serde = { version = "1.0.228", features = ["derive"] }
slotmap = "1.1.1"
smol = { version = "2.0.2", optional = true }
thiserror = "2.0.18"
taffy = { version = "0.9.2", features = ["grid"] }
tokio = { version = "1.49.0", optional = true }
tracing = "0.1.44"
unicode-segmentation = "1.12"
url = "2.5.8"
zbus = { version = "5.13.2", default-features = false, optional = true }

# Enable DBus feature on Linux targets
[target.'cfg(target_os = "linux")'.dependencies]
cosmic-config = { path = "cosmic-config", features = ["dbus"] }
cosmic-settings-daemon = { git = "https://github.com/pop-os/dbus-settings-bindings" }
zbus = { version = "5.13.2", default-features = false }
ashpd = { version = "0.12.1", default-features = false, optional = true }

[target.'cfg(unix)'.dependencies]
freedesktop-icons = { package = "cosmic-freedesktop-icons", git = "https://github.com/pop-os/freedesktop-icons" }
freedesktop-desktop-entry = { version = "0.8.1", optional = true }
shlex = { version = "1.3.0", optional = true }

[target.'cfg(not(unix))'.dependencies]
# Used to embed bundled icons for non-unix platforms.
phf = { version = "0.13.1", features = ["macros"] }



[dependencies.cosmic-theme]
path = "cosmic-theme"

[dependencies.iced]
path = "./iced"
default-features = false
features = [
    "advanced",
    "image-without-codecs",
    "lazy",
    "svg",
    "web-colors",
    "tiny-skia",
]

[dependencies.iced_runtime]
path = "./iced/runtime"

[dependencies.iced_renderer]
path = "./iced/renderer"

[dependencies.iced_core]
path = "./iced/core"
features = ["serde"]

[dependencies.iced_widget]
path = "./iced/widget"
features = ["canvas"]

[dependencies.iced_futures]
path = "./iced/futures"

[dependencies.iced_accessibility]
path = "./iced/accessibility"
optional = true

[dependencies.iced_tiny_skia]
path = "./iced/tiny_skia"

[dependencies.iced_winit]
path = "./iced/winit"
optional = true

[dependencies.iced_wgpu]
path = "./iced/wgpu"
optional = true

[dependencies.cosmic-panel-config]
git = "https://github.com/pop-os/cosmic-panel"
# path = "../cosmic-panel/cosmic-panel-config"
optional = true

[dependencies.ron]
version = "0.12"
optional = true

[workspace]
members = [
    "cosmic-config",
    "cosmic-config-derive",
    "cosmic-theme",
    "examples/*",
]
exclude = ["iced"]

[workspace.dependencies]
dirs = "6.0.0"

[dev-dependencies]
tempfile = "3.24.0"

[snoweuph]

I was able to build (Some) examples on Windows with editing both Cargo.toml files (libcosmic and the examples one). In the examples (application) folders Cargo.toml:

[package]
name = "application"
version = "0.1.0"
edition = "2021"

[features]
default = []
#default = ["wayland"]
#wayland = ["libcosmic/wayland"]

[dependencies]
tracing = "0.1.44"
tracing-subscriber = "0.3.22"
tracing-log = "0.2.0"

[dependencies.libcosmic]
path = "../../"
features = [
    "debug",
    "winit",
    "tokio",
    #"xdg-portal",
    #"a11y",
    "wgpu",
    #"single-instance",
    "surface-message",
]

and in libcosmics toml i had to change to:

[package]
name = "libcosmic"
version = "1.0.0"
edition = "2024"
rust-version = "1.90"

[lib]
name = "cosmic"

[features]
#default = ["dbus-config", "multi-window", "a11y"]
default = ["multi-window"]
# Accessibility support
a11y = ["iced/a11y", "iced_accessibility"]
# Enable about widget
about = []
# Builds support for animated images
animated-image = ["dep:async-fs", "image/gif", "tokio?/io-util", "tokio?/fs"]
# XXX autosize should not be used on winit windows unless dialogs
autosize = []
applet = [
    "autosize",
    "winit",
    "wayland",
    "tokio",
    "cosmic-panel-config",
    "ron",
    "multi-window",
]
applet-token = ["applet"]
# Use the cosmic-settings-daemon for config handling on Linux targets
dbus-config = []
# Debug features
debug = ["iced/debug"]
# Enables pipewire support in ashpd, if ashpd is enabled
pipewire = ["ashpd?/pipewire"]
# Enables process spawning helper
process = ["dep:libc", "dep:rustix"]
# Use rfd for file dialogs
rfd = ["dep:rfd"]
# Enables desktop files helpers
desktop = [
    "process",
    "dep:cosmic-settings-config",
    "dep:freedesktop-desktop-entry",
    "dep:mime",
    "dep:shlex",
    "tokio?/io-util",
    "tokio?/net",
]
# Enables launching desktop files inside systemd scopes
desktop-systemd-scope = ["desktop", "dep:zbus"]
# Enables keycode serialization
serde-keycode = ["iced_core/serde"]
# Prevents multiple separate process instances.
single-instance = ["zbus/blocking-api", "ron"]
# smol async runtime
smol = ["dep:smol", "iced/smol", "zbus?/async-io", "rfd?/async-std"]
tokio = [
    "dep:tokio",
    "ashpd?/tokio",
    "iced/tokio",
    "rfd?/tokio",
    "zbus?/tokio",
    "cosmic-config/tokio",
]
# Tokio async runtime
# Wayland window support
wayland = [
    "ashpd?/wayland",
    "autosize",
    "iced_runtime/wayland",
    "iced/wayland",
    "iced_winit/wayland",
    "cctk",
    "surface-message",
]
surface-message = []
# multi-window support
multi-window = ["iced/multi-window"]
# Render with wgpu
wgpu = ["iced/wgpu", "iced_wgpu"]
# X11 window support via winit
winit = ["iced/winit", "iced_winit"]
winit_debug = ["winit", "debug"]
winit_tokio = ["winit", "tokio"]
winit_wgpu = ["winit", "wgpu"]
# Enables XDG portal integrations
xdg-portal = ["ashpd"]
qr_code = ["iced/qr_code"]
markdown = ["iced/markdown"]
highlighter = ["iced/highlighter"]
async-std = [
    "dep:async-std",
    "ashpd?/async-std",
    "rfd?/async-std",
    "zbus?/async-io",
    "iced/async-std",
]

[dependencies]
apply = "0.3.0"

async-fs = { version = "2.2", optional = true }
async-std = { version = "1.13", optional = true }
auto_enums = "0.8.7"
cctk = { git = "https://github.com/pop-os/cosmic-protocols", package = "cosmic-client-toolkit", rev = "d0e95be", optional = true }
chrono = "0.4.43"
cosmic-config = { path = "cosmic-config" }
cosmic-settings-config = { git = "https://github.com/pop-os/cosmic-settings-daemon", optional = true }
# Internationalization
i18n-embed = { version = "0.16.0", features = [
    "fluent-system",
    "desktop-requester",
] }
i18n-embed-fl = "0.10"
rust-embed = "8.11.0"
css-color = "0.2.8"
derive_setters = "0.1.8"
futures = "0.3"
image = { version = "0.25.9", default-features = false, features = [
    "jpeg",
    "png",
] }
libc = { version = "0.2.180", optional = true }
log = "0.4"
mime = { version = "0.3.17", optional = true }
palette = "0.7.6"
raw-window-handle = "0.6"
rfd = { version = "0.16.0", default-features = false, features = [
    "xdg-portal",
], optional = true }
rustix = { version = "1.1", features = ["pipe", "process"], optional = true }
serde = { version = "1.0.228", features = ["derive"] }
slotmap = "1.1.1"
smol = { version = "2.0.2", optional = true }
thiserror = "2.0.18"
taffy = { version = "0.9.2", features = ["grid"] }
tokio = { version = "1.49.0", optional = true }
tracing = "0.1.44"
unicode-segmentation = "1.12"
url = "2.5.8"
zbus = { version = "5.13.2", default-features = false, optional = true }

# Enable DBus feature on Linux targets
[target.'cfg(target_os = "linux")'.dependencies]
cosmic-config = { path = "cosmic-config", features = ["dbus"] }
cosmic-settings-daemon = { git = "https://github.com/pop-os/dbus-settings-bindings" }
zbus = { version = "5.13.2", default-features = false }
ashpd = { version = "0.12.1", default-features = false, optional = true }

[target.'cfg(unix)'.dependencies]
freedesktop-icons = { package = "cosmic-freedesktop-icons", git = "https://github.com/pop-os/freedesktop-icons" }
freedesktop-desktop-entry = { version = "0.8.1", optional = true }
shlex = { version = "1.3.0", optional = true }

[target.'cfg(not(unix))'.dependencies]
# Used to embed bundled icons for non-unix platforms.
phf = { version = "0.13.1", features = ["macros"] }



[dependencies.cosmic-theme]
path = "cosmic-theme"

[dependencies.iced]
path = "./iced"
default-features = false
features = [
    "advanced",
    "image-without-codecs",
    "lazy",
    "svg",
    "web-colors",
    "tiny-skia",
]

[dependencies.iced_runtime]
path = "./iced/runtime"

[dependencies.iced_renderer]
path = "./iced/renderer"

[dependencies.iced_core]
path = "./iced/core"
features = ["serde"]

[dependencies.iced_widget]
path = "./iced/widget"
features = ["canvas"]

[dependencies.iced_futures]
path = "./iced/futures"

[dependencies.iced_accessibility]
path = "./iced/accessibility"
optional = true

[dependencies.iced_tiny_skia]
path = "./iced/tiny_skia"

[dependencies.iced_winit]
path = "./iced/winit"
optional = true

[dependencies.iced_wgpu]
path = "./iced/wgpu"
optional = true

[dependencies.cosmic-panel-config]
git = "https://github.com/pop-os/cosmic-panel"
# path = "../cosmic-panel/cosmic-panel-config"
optional = true

[dependencies.ron]
version = "0.12"
optional = true

[workspace]
members = [
    "cosmic-config",
    "cosmic-config-derive",
    "cosmic-theme",
    "examples/*",
]
exclude = ["iced"]

[workspace.dependencies]
dirs = "6.0.0"

[dev-dependencies]
tempfile = "3.24.0"

on which hash are you for libcosmic rn?

[sensn]

sorry, i don`t understand your question. I cloned from libcosmic github some weeks ago, then i changed some lines in Cargo.toml. Where can I find that hash?

[snoweuph]

sorry, i don`t understand your question. I cloned from libcosmic github some weeks ago, then i changed some lines in Cargo.toml. Where can I find that hash?

its in the Cargo.lock file, if you didn't set it specificly