feat(preferences): Option to disable stacking with mouse

Author: Szymon Mikler

schemas/org.gnome.shell.extensions.pop-shell.gschema.xml

@@ -74,6 +74,11 @@
             <summary>Tile launched windows by default</summary>
         </key>
 
+        <key type="b" name="stacking-with-mouse">
+            <default>true</default>
+            <summary>Allow for stacking windows as a result of dragging a window with mouse</summary>
+        </key>
+
         <!-- Focus Shifting -->
         <key type="as" name="focus-left">
             <default><![CDATA[['<Super>Left','<Super>KP_Left','<Super>h']]]></default>

src/auto_tiler.ts

@@ -408,7 +408,7 @@ export class AutoTiler {
                 ? fork.area
                 : attach_to.meta.get_frame_rect()
 
-        let placement: null | MoveBy = cursor_placement(attach_area, cursor)
+        let placement: null | MoveBy = cursor_placement(ext, attach_area, cursor)
         const stack = ext.auto_tiler?.find_stack(attach_to.entity)
 
         const matching_stack = win.stack !== null && win.stack === attach_to.stack
@@ -733,11 +733,11 @@ export class AutoTiler {
 *
 * A null indicates that the window should be stacked
 */
-export function cursor_placement(area: Rectangular, cursor: Rectangular): null | MoveByCursor {
+export function cursor_placement(ext: Ext, area: Rectangular, cursor: Rectangular): null | MoveByCursor {
     const { LEFT, RIGHT, TOP, BOTTOM } = geom.Side
     const { HORIZONTAL, VERTICAL } = lib.Orientation
 
-    const [, side] = geom.nearest_side([cursor.x, cursor.y], area)
+    const [, side] = geom.nearest_side(ext, [cursor.x, cursor.y], area)
 
     let res: null | [lib.Orientation, boolean] = side === LEFT
         ? [HORIZONTAL, true]

src/extension.ts

@@ -1469,7 +1469,7 @@ export class Ext extends Ecs.System<ExtEvent> {
 
                     const result = monitor_attachment
                         ? null
-                        : auto_tiler.cursor_placement(area, cursor)
+                        : auto_tiler.cursor_placement(this, area, cursor)
 
                     if (!result) {
                         this.overlay.x = area.x

src/geom.ts

@@ -1,3 +1,5 @@
+import type {Ext} from 'extension';
+
 export enum Side {
     LEFT,
     TOP,
@@ -70,7 +72,7 @@ export function leftward_distance(win_a: Meta.Window, win_b: Meta.Window) {
     return directional_distance(win_a.get_frame_rect(), win_b.get_frame_rect(), east, west);
 }
 
-export function nearest_side(origin: [number, number], rect: Rectangular): [number, Side] {
+export function nearest_side(ext: Ext, origin: [number, number], rect: Rectangular): [number, Side] {
     const left = west(rect), top = north(rect), right = east(rect), bottom = south(rect), ctr = center(rect)
 
     const left_distance = distance(origin, left),
@@ -85,7 +87,7 @@ export function nearest_side(origin: [number, number], rect: Rectangular): [numb
 
     if (top_distance < nearest[0]) nearest = [top_distance, Side.TOP]
     if (bottom_distance < nearest[0]) nearest = [bottom_distance, Side.BOTTOM]
-    if (center_distance < nearest[0]) nearest = [center_distance, Side.CENTER]
+    if (ext.settings.stacking_with_mouse() && center_distance < nearest[0]) nearest = [center_distance, Side.CENTER]
 
     return nearest
 }
@@ -95,4 +97,4 @@ export function shortest_side(origin: [number, number], rect: Rectangular): numb
     shortest = Math.min(shortest, distance(origin, north(rect)))
     shortest = Math.min(shortest, distance(origin, east(rect)))
     return Math.min(shortest, distance(origin, south(rect)))
-}
+}

src/prefs.ts

@@ -14,6 +14,7 @@ import * as focus from 'focus';
 
 interface AppWidgets {
     fullscreen_launcher: any,
+    stacking_with_mouse: any,
     inner_gap: any,
     mouse_cursor_follows_active_window: any,
     outer_gap: any,
@@ -97,7 +98,13 @@ function settings_dialog_new(): Gtk.Container {
     app.fullscreen_launcher.connect('state-set', (_widget: any, state: boolean) => {
         ext.set_fullscreen_launcher(state)
         Settings.sync()
-    })
+    });
+
+    app.stacking_with_mouse.set_active(ext.stacking_with_mouse())
+    app.stacking_with_mouse.connect('state-set', (_widget: any, state: boolean) => {
+        ext.set_stacking_with_mouse(state)
+        Settings.sync()
+    });
 
     return grid;
 }
@@ -143,26 +150,32 @@ function settings_dialog_view(): [AppWidgets, Gtk.Container] {
         xalign: 0.0
     })
 
-    const [inner_gap, outer_gap] = gaps_section(grid, 8);
+    const stacking_with_mouse = new Gtk.Label({
+        label: "Allow stacking with mouse",
+        xalign: 0.0
+    })
+
+    const [inner_gap, outer_gap] = gaps_section(grid, 9);
 
     const settings = {
         inner_gap,
         outer_gap,
         fullscreen_launcher: new Gtk.Switch({ halign: Gtk.Align.END }),
+        stacking_with_mouse: new Gtk.Switch({ halign: Gtk.Align.END }),
         smart_gaps: new Gtk.Switch({ halign: Gtk.Align.END }),
         snap_to_grid: new Gtk.Switch({ halign: Gtk.Align.END }),
         window_titles: new Gtk.Switch({ halign: Gtk.Align.END }),
         show_skip_taskbar: new Gtk.Switch({ halign: Gtk.Align.END }),
         mouse_cursor_follows_active_window: new Gtk.Switch({ halign: Gtk.Align.END }),
         mouse_cursor_focus_position: build_combo(
             grid,
-            6,
+            7,
             focus.FocusPosition,
             'Mouse Cursor Focus Position',
         ),
         log_level: build_combo(
             grid,
-            7,
+            8,
             log.LOG_LEVELS,
             'Log Level',
         )
@@ -180,11 +193,14 @@ function settings_dialog_view(): [AppWidgets, Gtk.Container] {
     grid.attach(fullscreen_launcher_label, 0, 3, 1, 1)
     grid.attach(settings.fullscreen_launcher, 1, 3, 1, 1)
 
-    grid.attach(show_skip_taskbar_label, 0, 4, 1, 1)
-    grid.attach(settings.show_skip_taskbar, 1, 4, 1, 1)
+    grid.attach(stacking_with_mouse, 0, 4, 1, 1)
+    grid.attach(settings.stacking_with_mouse, 1, 4, 1, 1)
+
+    grid.attach(show_skip_taskbar_label, 0, 5, 1, 1)
+    grid.attach(settings.show_skip_taskbar, 1, 5, 1, 1)
 
-    grid.attach(mouse_cursor_follows_active_window_label, 0, 5, 1, 1)
-    grid.attach(settings.mouse_cursor_follows_active_window, 1, 5, 1, 1)
+    grid.attach(mouse_cursor_follows_active_window_label, 0, 6, 1, 1)
+    grid.attach(settings.mouse_cursor_follows_active_window, 1, 6, 1, 1)
 
     return [settings, grid]
 }

src/settings.ts

@@ -49,6 +49,7 @@ function settings_new_schema(schema: string): Settings {
 
 const ACTIVE_HINT = "active-hint";
 const ACTIVE_HINT_BORDER_RADIUS = "active-hint-border-radius";
+const STACKING_WITH_MOUSE = "stacking-with-mouse";
 const COLUMN_SIZE = "column-size";
 const EDGE_TILING = "edge-tiling";
 const FULLSCREEN_LAUNCHER = "fullscreen-launcher"
@@ -82,6 +83,10 @@ export class ExtensionSettings {
         return this.ext.get_uint(ACTIVE_HINT_BORDER_RADIUS);
     }
 
+    stacking_with_mouse(): boolean {
+        return this.ext.get_boolean(STACKING_WITH_MOUSE);
+    }
+
     column_size(): number {
         return this.ext.get_uint(COLUMN_SIZE);
     }
@@ -182,6 +187,10 @@ export class ExtensionSettings {
         this.ext.set_uint(ACTIVE_HINT_BORDER_RADIUS, set);
     }
 
+    set_stacking_with_mouse(set: boolean) {
+        this.ext.set_boolean(STACKING_WITH_MOUSE, set);
+    }
+
     set_column_size(size: number) {
         this.ext.set_uint(COLUMN_SIZE, size);
     }