Gnome 49 support

[CodeAndGin]

Well my Gnome 47 fix had a good run but bye bye x11 I guess

While the extension does load when adding "49" to the metadata, toggling tiling does nothing.

[Neo-29]

+1 ( archlinux wayland here)

[rafafrdz]

+1 (cachyos wayland here) added "49" and pluggin is enabled but toggling tiling doesn't work

[LilMonk]

+1 (cachyos wayland here) added "49" and pluggin is enabled but toggling tiling doesn't work

Same for me

[rr987-0]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing
just unzip it and replace .local/share/gnome-shell/extensions/pop-shell@system76.com
or diff it and figure out

[Neo-29]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing just unzip it and replace .local/share/gnome-shell/extensions/pop-shell@system76.com or diff it and figure out

Why not a PR?

[rafafrdz]

i've made several function modifications get_maximized to is_maximized and some others but can exactly remember what but here is a version that works. https://drive.google.com/file/d/1g_SzZyO6HeDX0hS7fhQTzeEsDUVaT98r/view?usp=sharing
just unzip it and replace .local/share/gnome-shell/extensions/pop-shell@system76.com
or diff it and figure out

yes please, could you open a Pr with the changes? @rr987-0

[LilMonk]

@rafafrdz @CodeAndGin @Neo-29 You can check out this PR #1795 . Let me know if there are any bugs or issues with it. Its working fine for me on cachyos. Note: Need to reboot after installation.

[chrisjonesBSU]

@rafafrdz @CodeAndGin @Neo-29 You can check out this PR #1795 . Let me know if there are any bugs or issues with it. Its working fine for me on cachyos. Note: Need to reboot after installation.

This works for me on a VM with Gnome 49. Thanks!

[Neo-29]

not good here> Once you try to move a window manually, the extension stops working and all is in floating mode

Archlinux wayland

[chrisjonesBSU]

not good here> Once you try to move a window manually, the extension stops working and all is in floating mode

Archlinux wayland

Good catch, I didn't try that out. The same is happening for me.

[LilMonk]

I don't have that issue. I'm using V shell gnome extension for my vertical workspace setup.

[chrisjonesBSU]

This is on a fresh VM installation of EndeavourOS with no other extensions.

This appears in the logs right after clicking and dragging a window

Sep 24 12:47:41 chris-end gnome-shell[1626]: JS ERROR: TypeError: (intermediate value).Rectangle is not a constructor
                                             cursor_status@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2052:22
                                             on_grab_start/this.drag_signal<@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:1096:52
                                             @resource:///org/gnome/shell/ui/init.js:21:20
Sep 24 12:47:42 chris-end gnome-shell[1626]: JS ERROR: TypeError: (intermediate value).Rectangle is not a constructor
                                             cursor_status@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:2052:22
                                             on_drop@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/auto_tiler.js:249:39
                                             on_grab_end_@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:830:41
                                             on_grab_end@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:777:14
                                             signals_attach/</<@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:1605:45
                                             run@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:154:23
                                             wake/<@file:///home/chris/.local/share/gnome-shell/extensions/pop-shell@system76.com/executor.js:26:24
                                             @resource:///org/gnome/shell/ui/init.js:21:20

[LilMonk]

Let me take a look at it. Might be some API changes in gnome 49

[LilMonk]

I have made the changes. It's working now. Reason for the error was The Meta.Rectangle is deprecated in gnome 49

Let me know if anything else breaks.