Remove modeset, i2c_nvidia_gpu modprobe options #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do Jenkins build errors never make any fucking sense? GitHub was down. |
`modeset` is set by the driver package, so it is not necessary to explicitly set it. `i2c_nvidia_gpu` is available as a quirk in system76-driver for models that have issues with suspend because of it. Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
rm-modprobe-options
branch
from
93cae65 to
cf15314
Compare
|
Do we want this change for all branches, or only 24.04 like #463? |
|
All branches. |
jacobgkau
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
No issues with this. The i2c option's still set on e.g. oryp5 through system76-driver, and the modeset option's set through the NVIDIA driver package, as mentioned.
Regression testing on Pop!_OS 22.04 passed:
CLI
Tasks which test the behavior of the CLI client.
- Power profiles can be queried and set
- Switchable graphics can be queried
- Command returns "not supported" message on a non-switchable system
- Command returns
switchableon a laptop with switchable graphics
- Discrete graphics power state can be queried and set (compute mode)
- Works on oryp5 (proprietary firmware); known not to work on oryp6.
GNOME Shell
Tasks which test the behavior of the shell extension.
- Test that the power profile can be switched, and that the dots are correct
- Test that a power profile change from the CLI is reflected in the extension
- When switching to balanced, with screen brightness maxed, screen brightness drops to 40%
- When switching to battery, with screen brightness maxed, screen brightness drops to 10%
- When switching to balanced, with screen brightness minimized, screen brightness does not change
- When restarting the daemon, and the daemon defaults to a balanced profile, the brightness should not change
- When restarting the system, screen brightness should be the same as before
- When plugging in a display in Integrated mode, the system prompts to switch to Hybrid mode
- Switchable system other than galp5
Switchable graphics (test with combination of CLI and GUI)
- Switching from Integrated to NVIDIA
- Switching from Integrated to Hybrid
- Switching from Integrated to Compute
- Switching from NVIDIA to Integrated
- Switching from NVIDIA to Hybrid
- Switching from NVIDIA to Compute
- Switching from Hybrid to Integrated
- Switching from Hybrid to NVIDIA
- Switching from Hybrid to Compute
- Switching from Compute to Integrated
- Switching from Compute to NVIDIA
- Switching from Compute to Hybrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modesetis set by the driver package, so it is not necessary to explicitly set it.i2c_nvidia_gpuis available as a quirk in system76-driver for models that have issues with suspend because of it.