Skip to content

Commit 189970c

Browse files
committed
Rename MenuItem.isEnabled to isActive
1 parent 8e13c87 commit 189970c

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/components/TopBar/LibraryPicker.jsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ const LibraryPicker = createMenu({
1313

1414
renderItems({enabledLibraries, onToggleLibrary}) {
1515
return map(libraries, (library, key) => {
16-
const isEnabled = enabledLibraries.includes(key);
16+
const isActive = enabledLibraries.includes(key);
1717

1818
return (
1919
<MenuItem
20-
isEnabled={isEnabled}
20+
isActive={isActive}
2121
key={key}
2222
onClick={partial(onToggleLibrary, key)}
2323
>
24-
<span className={classnames('u__icon', {u__invisible: !isEnabled})}>
24+
<span className={classnames('u__icon', {u__invisible: !isActive})}>
2525
&#xf00c;{' '}
2626
</span>
2727
{library.name}

src/components/TopBar/ProjectPicker.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const ProjectPicker = createMenu({
2020
renderItems({currentProjectKey, projectKeys, onChangeCurrentProject}) {
2121
return map(projectKeys, projectKey => (
2222
<MenuItem
23-
isEnabled={projectKey === currentProjectKey}
23+
isActive={projectKey === currentProjectKey}
2424
key={projectKey}
2525
onClick={partial(onChangeCurrentProject, projectKey)}
2626
>

src/components/TopBar/createMenu.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ import React from 'react';
1212
import {closeTopBarMenu, toggleTopBarMenu} from '../../actions';
1313
import {getOpenTopBarMenu} from '../../selectors';
1414

15-
export function MenuItem({children, isDisabled, isEnabled, onClick}) {
15+
export function MenuItem({children, isActive, isDisabled, onClick}) {
1616
return (
1717
<div
1818
className={classnames('top-bar__menu-item', {
19-
'top-bar__menu-item_active': isEnabled,
19+
'top-bar__menu-item_active': isActive,
2020
'top-bar__menu-item_disabled': isDisabled,
2121
})}
2222
onClick={isDisabled ? noop : onClick}
@@ -28,14 +28,14 @@ export function MenuItem({children, isDisabled, isEnabled, onClick}) {
2828

2929
MenuItem.propTypes = {
3030
children: PropTypes.node.isRequired,
31+
isActive: PropTypes.bool,
3132
isDisabled: PropTypes.bool,
32-
isEnabled: PropTypes.bool,
3333
onClick: PropTypes.func.isRequired,
3434
};
3535

3636
MenuItem.defaultProps = {
37+
isActive: false,
3738
isDisabled: false,
38-
isEnabled: false,
3939
};
4040

4141
export default function createMenu({

0 commit comments

Comments
 (0)