Remove ColumnDisplayType::Number (#938)

Author: wesm

crates/amalthea/src/comm/data_explorer_comm.rs

@@ -730,10 +730,6 @@ pub enum SearchSchemaSortOrder {
 /// Possible values for ColumnDisplayType
 #[derive(Copy, Clone, Debug, Serialize, Deserialize, PartialEq, strum_macros::Display, strum_macros::EnumString)]
 pub enum ColumnDisplayType {
-	#[serde(rename = "number")]
-	#[strum(to_string = "number")]
-	Number,
-
 	#[serde(rename = "boolean")]
 	#[strum(to_string = "boolean")]
 	Boolean,

crates/ark/src/data_explorer/convert_to_code.rs

@@ -231,7 +231,6 @@ fn format_value_for_r(display_type: &ColumnDisplayType, value: &str) -> String {
         },
 
         // For numbers, no quotes needed
-        ColumnDisplayType::Number |
         ColumnDisplayType::Integer |
         ColumnDisplayType::Floating |
         ColumnDisplayType::Decimal => value.to_string(),

crates/ark/src/data_explorer/r_data_explorer.rs

@@ -787,7 +787,6 @@ impl RDataExplorer {
         let filter_type = &filter.filter_type;
 
         let is_compare_supported = |x: &ColumnDisplayType| match x {
-            ColumnDisplayType::Number |
             ColumnDisplayType::Integer |
             ColumnDisplayType::Floating |
             ColumnDisplayType::Decimal |

crates/ark/src/data_explorer/summary_stats.rs

@@ -38,9 +38,6 @@ pub fn summary_stats(
     let mut stats = empty_column_summary_stats();
     stats.type_display = display_type;
     match stats.type_display {
-        ColumnDisplayType::Number => {
-            stats.number_stats = Some(summary_stats_number(column, format_options, false)?);
-        },
         ColumnDisplayType::Integer => {
             stats.number_stats = Some(summary_stats_number(column, format_options, true)?);
         },