Skip to content

Commit cf1ddd1

Browse files
committed
Don't advertise unsupported syntaxes
These are coming, but not here yet.
1 parent f0a0e68 commit cf1ddd1

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

crates/ark/src/data_explorer/r_data_explorer.rs

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,17 +1153,9 @@ impl RDataExplorer {
11531153
},
11541154
convert_to_code: ConvertToCodeFeatures {
11551155
support_status: SupportStatus::Supported,
1156-
code_syntaxes: Some(vec![
1157-
CodeSyntaxName {
1158-
code_syntax_name: "base".into(),
1159-
},
1160-
CodeSyntaxName {
1161-
code_syntax_name: "data.table".into(),
1162-
},
1163-
CodeSyntaxName {
1164-
code_syntax_name: "dplyr".into(),
1165-
},
1166-
]),
1156+
code_syntaxes: Some(vec![CodeSyntaxName {
1157+
code_syntax_name: "dplyr".into(),
1158+
}]),
11671159
},
11681160
},
11691161
};
@@ -1278,12 +1270,15 @@ impl RDataExplorer {
12781270
/// to executable code that can reproduce the current data view.
12791271
fn convert_to_code(&self, params: ConvertToCodeParams) -> ConvertedCode {
12801272
// Get object name if available, fallback to title
1281-
let object_name = self.binding.as_ref()
1273+
let object_name = self
1274+
.binding
1275+
.as_ref()
12821276
.map(|b| b.name.as_str())
12831277
.or_else(|| Some(self.title.as_str()));
12841278

12851279
// Resolve column names for sort keys using the same pattern as r_sort_rows()
1286-
let resolved_sort_keys: Vec<convert_to_code::ResolvedSortKey> = params.sort_keys
1280+
let resolved_sort_keys: Vec<convert_to_code::ResolvedSortKey> = params
1281+
.sort_keys
12871282
.iter()
12881283
.filter_map(|sort_key| {
12891284
// Get column schema from index, similar to existing sort implementation

0 commit comments

Comments
 (0)