Skip to content

Commit fe59470

Browse files
committed
Comment on optional fields
1 parent 4698ca6 commit fe59470

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

crates/amalthea/src/wire/history_request.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ use crate::wire::jupyter_message::MessageType;
1313
/// Represents a request from the frontend for execution history.
1414
///
1515
/// The protocol defines three access types (`range`, `tail`, `search`)
16-
/// with different fields for each.
16+
/// with different fields for each. All fields are defaulted because the
17+
/// spec notes that most history options are not used by Jupyter frontends
18+
/// and many kernels don't implement them, so clients may send incomplete
19+
/// requests.
1720
#[derive(Debug, Serialize, Deserialize, Clone)]
1821
#[serde(tag = "hist_access_type")]
1922
pub enum HistoryRequest {

0 commit comments

Comments
 (0)