Open
Conversation
Contributor
|
There are 3 places where it is set to C level https://github.com/wch/r-source/blob/c5f33b7352a7a69701f96aeeddd21e3d86220fed/src/main/eval.c#L8127 https://github.com/wch/r-source/blob/c5f33b7352a7a69701f96aeeddd21e3d86220fed/src/main/eval.c#L2433 https://github.com/wch/r-source/blob/c5f33b7352a7a69701f96aeeddd21e3d86220fed/src/main/eval.c#L1259 |
Contributor
Author
And guarded by profiling checks, so I think we're not getting through there in this case? |
lionel-
force-pushed
the
bugfix/browser-crash
branch
from
6b37f66 to
24b91f2
Compare
Contributor
|
2 of the 3 are |
Comment on lines
+51
to
+52
| # See https://github.com/posit-dev/positron/issues/8979 | ||
| frame <- frame %||% frame_info_fallback() |
Contributor
There was a problem hiding this comment.
Suggested change
| # See https://github.com/posit-dev/positron/issues/8979 | |
| frame <- frame %||% frame_info_fallback() | |
| # See https://github.com/posit-dev/positron/issues/8979 | |
| # and https://github.com/posit-dev/positron/issues/12021 | |
| frame <- frame %||% frame_info_fallback() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#8979
Addresses posit-dev/positron#12021
Even though I'm quite curious about it, I haven't taken the time to investigate why
R_SrcrefbecomesNULLin the dplyr mask evaluation context.