chore: adjust page_offset() to always respect limit (#472)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>

Author: 3 people

R/page.R

@@ -93,7 +93,8 @@ page_offset <- function(client, req, limit = Inf) {
     new_expr <- NULL
     new_req <- NULL
   }
-  return(agg_response)
+  # Make sure we never return more than `limit` records
+  head(agg_response, limit)
 }
 
 optional_progress_bar <- function(...) {
@@ -102,8 +103,7 @@ optional_progress_bar <- function(...) {
   } else {
     # Return a mock object that behaves enough like a progress bar object
     list(
-      tick = function() {
-      }
+      tick = function() {}
     )
   }
 }

tests/testthat/2025.09.0/__api__/v1/search/content-d37a6d.json

@@ -1,6 +1,6 @@
-// Used in test-content.R
+// Used in test-content.R and test-page.R
 {
-    "total": 3,
+    "total": 4,
     "current_page": 1,
     "results": [
         {

tests/testthat/2025.09.0/__api__/v1/search/content-eaf9f2.json

@@ -1,12 +1,17 @@
-// Used in test-content.R
+// Used in test-content.R and test-page.R
 {
-    "total": 3,
+    "total": 4,
     "current_page": 2,
     "results": [
         {
             "guid": "abc12345",
             "name": "blobfish-report",
             "title": "blobfish report"
+        },
+        {
+            "guid": "abc12346",
+            "name": "blobfish-report-final",
+            "title": "blobfish report (v2)"
         }
     ]
-}
+}

tests/testthat/test-content.R

@@ -493,10 +493,15 @@ with_mock_dir("2025.09.0", {
 
   test_that("content search fetches multiple pages correctly", {
     res <- search_content(client, q = "blobfish")
-    expect_equal(length(res), 3)
+    expect_equal(length(res), 4)
     expect_equal(
       purrr::map_chr(res, list("content", "title")),
-      c("blobfish dashboard", "blobfish api", "blobfish report")
+      c(
+        "blobfish dashboard",
+        "blobfish api",
+        "blobfish report",
+        "blobfish report (v2)"
+      )
     )
   })
 

tests/testthat/test-page.R

@@ -0,0 +1,16 @@
+with_mock_dir("2025.09.0", {
+  client <- Connect$new(
+    server = "https://connect.example",
+    api_key = "not-a-key"
+  )
+
+  test_that("page_offset respects a specified 'limit' ", {
+    # These mocks return four results across two pages.
+    res <- search_content(client, q = "blobfish", limit = 3)
+    expect_equal(length(res), 3)
+    expect_equal(
+      purrr::map_chr(res, list("content", "title")),
+      c("blobfish dashboard", "blobfish api", "blobfish report")
+    )
+  })
+})