-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Description
Throughout the package, arguments and objects denoting the Connect client use different names.
src
Lines 218 to 225 in 2522605
| get_content <- function( | |
| src, | |
| guid = NULL, | |
| owner_guid = NULL, | |
| name = NULL, | |
| ..., | |
| .p = NULL | |
| ) { |
connect
Line 593 in 860052e
| content_item <- function(connect, guid) { |
client is used elsewhere.
con is also used as a variable name internally, but this can be confusing if it occurs in contexts when content is also an object.
We should pick a single name, especially for user-facing arguments. I think client is better than src.
To maintain backward compatibility with existing code, we could look for the old name in ... if the first arg is missing.
Metadata
Metadata
Assignees
Labels
No labels