`limit` argument to `page_offset` doesn't work if `limit` < `page_size`

[karawoo]

client <- connect()
search_content(client, limit = 2)

With the above, I still get a full page's worth of results, not just 2. If I set the page size to a smaller value than the limit, then I get 2 items:

search_content(client, limit = 2, page_size = 1)

I'd expect limit to work regardless of page_size.

The issue is that we fetch the first page of results here, bypass the while loop (because agg_length isn't less than limit), and then just return the whole page. We probably just want to subset agg_response[seq_len(min(limit, length(agg_response))] or something. [edit] or better eyt: set page_size to min(page_size, limit) before we make the API call.

connectapi/R/page.R

Lines 73 to 96 in 73ce793

	agg_response <- res
	agg_length <- length(agg_response)
	while (length(res) > 0 && agg_length < limit && agg_length < total_items) {
	prg$tick()
	# bump the page number
	current_page <- req_response$current_page
	new_expr <- qexpr
	new_expr$page_number <- current_page + 1
	new_req <- rlang::quo_set_expr(qreq, new_expr)
	# next request
	req_response <- rlang::eval_tidy(new_req)
	res <- req_response$results
	agg_response <- c(agg_response, res)
	agg_length <- length(agg_response)
	# clear out variables
	current_page <- NULL
	new_expr <- NULL
	new_req <- NULL
	}
	return(agg_response)

[toph-allen]

You're so right that — the user doesn't care about the pagination interface, and probably understands "limit" to mean "the max number of results fetched", not "the point after which to stop paginating".

I don't think your second suggestion will work by itself, e.g. if page_size is 500 (the max) and limit is 750, setting page_size to min(page_size, limit) will still return 1000 results.

So probably the first solution — subsetting the aggregated response before returning it — is the better option.