Add missing tests

Author: schloerke

src/posit/connect/tags.py

@@ -257,8 +257,10 @@ def get(self, tag_id: str) -> Tag:
             The tag object.
         """
         # TODO-barret-future: Replace with `self._ctx.client.tags.find(id=tag_id)`
-        assert isinstance(tag_id, str), "Tag `id` must be a string"
-        assert tag_id != "", "Tag `id` cannot be an empty string"
+        if not isinstance(tag_id, str):
+            raise TypeError("`tag_id` must be a string")
+        if tag_id == "":
+            raise ValueError("`tag_id` cannot be an empty string")
         path = f"{self._path}/{tag_id}"
         url = self._ctx.url + path
         response = self._ctx.session.get(url)
@@ -292,7 +294,8 @@ def _update_parent_kwargs(self, kwargs: dict) -> dict:
             parent: str = parent["id"]
 
         if isinstance(parent, str):
-            assert parent != "", "Tag `parent` cannot be an empty string"
+            if parent == "":
+                raise ValueError("Tag `parent` cannot be an empty string")
             ret_kwargs["parent_id"] = parent
             return ret_kwargs
 
@@ -424,8 +427,10 @@ def _to_tag_ids(self, tags: tuple[str | Tag, ...]) -> list[str]:
         tag_ids: list[str] = []
         for i, tag in enumerate(tags):
             tag_id = tag["id"] if isinstance(tag, Tag) else tag
-            assert isinstance(tag_id, str), f"Expected 'tags[{i}]' to be a string. Got: {tag_id}"
-            assert len(tag_id) > 0, "Expected 'tags[{i}]' value to be non-empty"
+            if not isinstance(tag_id, str):
+                raise TypeError(f"Expected 'tags[{i}]' to be a string. Received: {tag_id}")
+            if tag_id == "":
+                raise ValueError(f"Expected 'tags[{i}]' to be non-empty. Received: {tag_id}")
 
             tag_ids.append(tag_id)
 
@@ -474,5 +479,6 @@ def delete(self, *tags: str | Tag) -> None:
 
         url = self._ctx.url + self._path
         for tag_id in tag_ids:
-            _ = self._ctx.session.delete(url, json={"tag_id": tag_id})
+            tag_url = f"{url}/{tag_id}"
+            self._ctx.session.delete(tag_url, json={"tag_id": tag_id})
         return

tests/posit/connect/__api__/v1/content/f2f37341-e21d-3d80-c698-a935ad614066/tag-add.json

@@ -0,0 +1,7 @@
+{
+  "id": "34",
+  "name": "Support",
+  "parent_id": "3",
+  "created_time": "2023-05-18T16:41:59Z",
+  "updated_time": "2023-05-18T16:41:59Z"
+}

tests/posit/connect/__api__/v1/content/f2f37341-e21d-3d80-c698-a935ad614066/tags.json

@@ -0,0 +1,16 @@
+[
+  {
+    "id": "3",
+    "name": "Internal Solutions",
+    "parent_id": null,
+    "created_time": "2019-10-08T19:44:49Z",
+    "updated_time": "2019-10-08T19:44:49Z"
+  },
+  {
+    "id": "5",
+    "name": "Life Cycle",
+    "parent_id": null,
+    "created_time": "2019-10-08T19:45:21Z",
+    "updated_time": "2019-10-08T19:45:21Z"
+  }
+]

tests/posit/connect/test_tags.py

@@ -1,3 +1,4 @@
+import pytest
 import responses
 from responses import matchers
 
@@ -117,6 +118,14 @@ def test_create_tag(self):
         academy_tag_parent_id = client.tags.create(name="academy", parent=tag["id"])
         academy_tag_parent_tag = client.tags.create(name="academy", parent=tag)
 
+        with pytest.raises(TypeError):
+            client.tags.create(
+                name="academy",
+                parent=123,  # pyright: ignore[reportArgumentType]
+            )
+        with pytest.raises(ValueError):
+            client.tags.create(name="academy", parent="")
+
         # assert
         assert mock_create_tag.call_count == 2
 
@@ -285,15 +294,105 @@ def test_destroy(self):
 class TestContentItemTags:
     @responses.activate
     def test_find(self):
-        # TODO-barret
-        raise NotImplementedError
+        # behavior
+        content_item_guid = "f2f37341-e21d-3d80-c698-a935ad614066"
+        mock_get = responses.get(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}",
+            json=load_mock_dict(f"v1/content/{content_item_guid}.json"),
+        )
+        mock_tags_get = responses.get(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}/tags",
+            json=load_mock_list(f"v1/content/{content_item_guid}/tags.json"),
+        )
+
+        # setup
+        client = Client("https://connect.example", "12345")
+        content_item = client.content.get(content_item_guid)
+
+        # invoke
+        tags = content_item.tags.find()
+
+        # assert
+        assert mock_get.call_count == 1
+        assert mock_tags_get.call_count == 1
+        assert len(tags) == 2
 
     @responses.activate
     def test_add(self):
-        # TODO-barret
-        raise NotImplementedError
+        # behavior
+        content_item_guid = "f2f37341-e21d-3d80-c698-a935ad614066"
+        tag_id = "33"
+        mock_content_item_get = responses.get(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}",
+            json=load_mock_dict(f"v1/content/{content_item_guid}.json"),
+        )
+        mock_tag_get = responses.get(
+            f"https://connect.example/__api__/v1/tags/{tag_id}",
+            json=load_mock_dict(f"v1/tags/{tag_id}.json"),
+        )
+        mock_tags_add = responses.post(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}/tags",
+            json={},  # empty response
+        )
+
+        # setup
+        client = Client("https://connect.example", "12345")
+        content_item = client.content.get(content_item_guid)
+
+        sub_tag = client.tags.get("33")
+
+        # invoke
+        content_item.tags.add(sub_tag["id"])
+        content_item.tags.add(sub_tag)
+
+        with pytest.raises(TypeError):
+            content_item.tags.add(
+                123,  # pyright: ignore[reportArgumentType]
+            )
+        with pytest.raises(ValueError):
+            content_item.tags.add("")
+
+        # assert
+        assert mock_content_item_get.call_count == 1
+        assert mock_tag_get.call_count == 1
+        assert mock_tags_add.call_count == 2
 
     @responses.activate
     def test_delete(self):
-        # TODO-barret
-        raise NotImplementedError
+        # behavior
+        content_item_guid = "f2f37341-e21d-3d80-c698-a935ad614066"
+        tag_id = "33"
+        mock_content_item_get = responses.get(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}",
+            json=load_mock_dict(f"v1/content/{content_item_guid}.json"),
+        )
+        mock_tag_get = responses.get(
+            f"https://connect.example/__api__/v1/tags/{tag_id}",
+            json=load_mock_dict(f"v1/tags/{tag_id}.json"),
+        )
+        mock_tags_delete = responses.delete(
+            f"https://connect.example/__api__/v1/content/{content_item_guid}/tags/{tag_id}",
+            json={},  # empty response
+        )
+
+        # setup
+        client = Client("https://connect.example", "12345")
+        content_item = client.content.get(content_item_guid)
+
+        sub_tag = client.tags.get("33")
+
+        # invoke
+        content_item.tags.delete(sub_tag["id"])
+        content_item.tags.delete(sub_tag)
+
+        with pytest.raises(TypeError):
+            content_item.tags.delete(
+                123,  # pyright: ignore[reportArgumentType]
+            )
+        with pytest.raises(ValueError):
+            content_item.tags.delete("")
+
+        # assert
+        assert mock_content_item_get.call_count == 1
+        assert mock_tag_get.call_count == 1
+        assert mock_tags_delete.call_count == 2