ci: add requests compatiblity check

Author: tdstein

.github/workflows/deps.yaml

@@ -0,0 +1,100 @@
+name: Check Compability
+on:
+  - pull_request
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+env:
+  UV_SYSTEM_PYTHON: true
+jobs:
+  check-requests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        requests-version:
+          - '2.32.3'
+          - '2.32.2'
+          - '2.31.0'
+          - '2.30.0'
+          - '2.29.0'
+          - '2.28.2'
+          - '2.28.1'
+          - '2.28.0'
+          - '2.27.1'
+          - '2.27.0'
+          - '2.26.0'
+          - '2.25.1'
+          - '2.25.0'
+          - '2.24.0'
+          - '2.23.0'
+          - '2.22.0'
+          - '2.21.0'
+          - '2.20.1'
+          - '2.20.0'
+          - '2.19.1'
+          - '2.19.0'
+          - '2.18.4'
+          - '2.18.3'
+          - '2.18.2'
+          - '2.18.1'
+          - '2.18.0'
+          - '2.17.3'
+          - '2.17.2'
+          - '2.17.1'
+          - '2.17.0'
+          - '2.16.5'
+          - '2.16.4'
+          - '2.16.3'
+          - '2.16.2'
+          - '2.16.1'
+          - '2.16.0'
+          - '2.15.1'
+          - '2.15.0'
+          - '2.14.2'
+          - '2.14.1'
+          - '2.14.0'
+          - '2.13.0'
+          - '2.12.5'
+          - '2.12.4'
+          - '2.12.3'
+          - '2.12.2'
+          - '2.12.1'
+          - '2.12.0'
+          - '2.11.1'
+          - '2.11.0'
+          - '2.10.0'
+          - '2.9.2'
+          - '2.9.1'
+          - '2.9.0'
+          - '2.8.1'
+          - '2.8.0'
+          - '2.7.0'
+          - '2.6.2'
+          - '2.6.1'
+          - '2.6.0'
+          - '2.5.3'
+          - '2.5.2'
+          - '2.5.1'
+          - '2.5.0'
+          - '2.4.3'
+          - '2.4.2'
+          - '2.4.1'
+          - '2.4.0'
+          - '2.3.0'
+          - '2.2.1'
+          - '2.2.0'
+          - '2.1.0'
+          - '2.0.1'
+          - '2.0.0'
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: 3.x
+          check-latest: true
+          cache: 'pip'
+      - run: make dev
+      - run: make deps
+      - run: uv pip install requests==${{ matrix.requests-version }}
+      - run: make test

pyproject.toml

@@ -20,7 +20,7 @@ classifiers = [
 ]
 dynamic = ["version"]
 dependencies = [
-    "requests>=2.31.0,<3",
+    "requests>=2,<3",
     "packaging",
     "typing-extensions"
 ]

requirements.txt

@@ -1,3 +1,3 @@
-requests==2.32.2
-packaging==24.1
-typing-extensions==4.12.2
+requests
+packaging
+typing-extensions

src/posit/connect/hooks.py

@@ -1,7 +1,9 @@
+import json
 import warnings
 from http.client import responses
 
-from requests import JSONDecodeError, Response
+import requests
+from requests import Response
 
 from .errors import ClientError
 
@@ -14,11 +16,10 @@ def handle_errors(response: Response, *args, **kwargs) -> Response:
             message = data["error"]
             payload = data.get("payload")
             http_status = response.status_code
-            http_status_message = responses[http_status]
+            http_status_message = responses.get(http_status, "Unknown status")
             raise ClientError(error_code, message, http_status, http_status_message, payload)
-        except JSONDecodeError:
-            # No JSON error message from Connect, so just raise
-            response.raise_for_status()
+        finally:
+            response.raise_for_status()  # Raise if no JSON error is available
     return response
 
 

tests/posit/connect/test_hooks.py

@@ -23,12 +23,10 @@ def test_client_error():
     with pytest.raises(ClientError):
         handle_errors(response)
 
-
-@patch("posit.connect.hooks.JSONDecodeError")
-def test_client_error_without_payload(JSONDecodeError):
+def test_client_error_without_payload():
     response = Mock()
     response.status_code = 404
-    response.json = Mock(side_effect=JSONDecodeError())
+    response.json = Mock(side_effect=Exception())
     response.raise_for_status = Mock(side_effect=Exception())
     with pytest.raises(Exception):
         handle_errors(response)