Skip to content

Commit cc10291

Browse files
dbkegleyplascaray
andauthored
Apply suggestions from code review
Co-authored-by: Pablo Bianco Lascaray <[email protected]>
1 parent fe88776 commit cc10291

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/posit/connect/external/databricks.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,7 @@ def databricks_config(
351351
```python
352352
import os
353353
354-
from databricks.sdk.core import ApiClient
355-
from databricks.sdk.core.credentials_provider import databricks_cli
354+
from databricks.sdk.core import ApiClient, databricks_cli
356355
from databricks.sdk.service.iam import CurrentUserAPI
357356
from shiny import reactive
358357
from shiny.express import render, session
@@ -372,7 +371,6 @@ def cfg():
372371
posit_workbench_strategy=WorkbenchStrategy(),
373372
posit_connect_strategy=ConnectStrategy(user_session_token=session_token),
374373
host=os.getenv("DATABRICKS_HOST"),
375-
warehouse_id=os.getenv("DATABRICKS_WAREHOUSE_ID"),
376374
)
377375
378376
@@ -394,8 +392,7 @@ def text():
394392
```python
395393
import os
396394
397-
from databricks.sdk.core import ApiClient
398-
from databricks.sdk.core.credentials_provider import oauth_service_principal
395+
from databricks.sdk.core import ApiClient, oauth_service_principal
399396
from databricks.sdk.service.iam import CurrentUserAPI
400397
from shiny import reactive
401398
from shiny.express import render, session
@@ -413,7 +410,6 @@ def cfg():
413410
posit_workbench_strategy=oauth_service_principal,
414411
posit_connect_strategy=ConnectStrategy(user_session_token=session_token),
415412
host=os.getenv("DATABRICKS_HOST"),
416-
warehouse_id=os.getenv("DATABRICKS_WAREHOUSE_ID"),
417413
client_id=os.getenv("DATABRICKS_CLIENT_ID"),
418414
client_secret=os.getenv("DATABRICKS_CLIENT_SECRET"),
419415
)
@@ -437,8 +433,7 @@ def text():
437433
```python
438434
import os
439435
440-
from databricks.sdk.core import ApiClient
441-
from databricks.sdk.core.credentials_provider import azure_service_principal
436+
from databricks.sdk.core import ApiClient, azure_service_principal
442437
from databricks.sdk.service.iam import CurrentUserAPI
443438
from shiny import reactive
444439
from shiny.express import render
@@ -455,7 +450,6 @@ def cfg():
455450
posit_workbench_strategy=azure_service_principal,
456451
posit_connect_strategy=ConnectStrategy(),
457452
host=os.getenv("DATABRICKS_HOST"),
458-
warehouse_id=os.getenv("DATABRICKS_WAREHOUSE_ID"),
459453
azure_client_id=os.getenv("ARM_CLIENT_ID"),
460454
azure_client_secret=os.getenv("ARM_CLIENT_SECRET"),
461455
azure_tenant_id=os.getenv("ARM_TENANT_ID"),

0 commit comments

Comments
 (0)