More exclusions and fixes

Author: schloerke

pyproject.toml

@@ -44,6 +44,12 @@ docstring-code-format = true
 docstring-code-line-length = "dynamic"
 
 [tool.ruff.lint]
+extend-ignore = [
+    "E501",  # E501: Line too long
+    "PT011", # PT011 `pytest.raises(ValueError)` is too broad
+    "PT022", # PT022 [*] No teardown in fixture
+    "F841",  # F841 Local variable is assigned but never used
+]
 extend-select = [
     # "C90", # Many false positives # C90; mccabe: https://docs.astral.sh/ruff/rules/complex-structure/
     # "DTZ", # Dates with timezones are different from dates without timezones # DTZ; flake8-datetimez: https://docs.astral.sh/ruff/rules/#flake8-datetimez-dtz

src/posit/connect/hooks.py

@@ -37,5 +37,5 @@ def check_for_deprecation_header(response: Response, *args, **kwargs) -> Respons
             + " is deprecated and will be removed in a future version of Connect."
             + " Please upgrade `posit-sdk` in order to use the new APIs."
         )
-        warnings.warn(msg, DeprecationWarning)
+        warnings.warn(msg, DeprecationWarning, stacklevel=3)
     return response

src/posit/connect/metrics/usage.py

@@ -15,10 +15,10 @@ class UsageEvent(resources.Resource):
     def from_event(
         event: visits.VisitEvent | shiny_usage.ShinyUsageEvent,
     ) -> UsageEvent:
-        if type(event) == visits.VisitEvent:
+        if isinstance(event, visits.VisitEvent):
             return UsageEvent.from_visit_event(event)
 
-        if type(event) == shiny_usage.ShinyUsageEvent:
+        if isinstance(event, shiny_usage.ShinyUsageEvent):
             return UsageEvent.from_shiny_usage_event(event)
 
         raise TypeError

src/posit/connect/paginator.py

@@ -1,9 +1,10 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import Generator, List
+from typing import TYPE_CHECKING, Generator, List
 
-import requests
+if TYPE_CHECKING:
+    import requests
 
 # The maximum page size supported by the API.
 _MAX_PAGE_SIZE = 500

src/posit/connect/resources.py

@@ -36,6 +36,7 @@ def __getattr__(self, name):
                 f"Accessing the field '{name}' via attribute is deprecated and will be removed in v1.0.0. "
                 f"Please use __getitem__ (e.g., {self.__class__.__name__.lower()}['{name}']) for field access instead.",
                 DeprecationWarning,
+                stacklevel=2,
             )
             return self[name]
         return None