Merged PR posit-dev/positron-python#118: limit registered runtimes to >= 3.8

Merge pull request #118 from posit-dev/limit-registered-runtimes

limit registered runtimes to >= 3.8
--------------------
Commit message for posit-dev/positron-python@30bb1a5:

ignore pre-existing file with pyright issues

--------------------
Commit message for posit-dev/positron-python@cb6fca8:

limit registered runtimes to >= 3.8

Addresses #654.


Authored-by: Wasim Lorgat <[email protected]>
Signed-off-by: Wasim Lorgat <[email protected]>

Author: seeM

extensions/positron-python/pythonFiles/pyproject.toml

@@ -29,6 +29,7 @@ ignore = [
     'testlauncher.py',
     'visualstudio_py_testlauncher.py',
     'testing_tools/unittest_discovery.py',
+    'testing_tools/adapter/report.py',
     'testing_tools/adapter/util.py',
     'testing_tools/adapter/pytest/_discovery.py',
     'testing_tools/adapter/pytest/_pytest_item.py',

extensions/positron-python/src/client/activation/jedi/positronLanguageRuntimes.ts

@@ -12,7 +12,7 @@ import * as vscode from 'vscode';
 import * as crypto from 'crypto';
 import { Disposable, DocumentFilter, LanguageClientOptions } from 'vscode-languageclient/node';
 
-import { compare } from 'semver';
+import * as semver from 'semver';
 import { EXTENSION_ROOT_DIR, PYTHON_LANGUAGE } from '../../common/constants';
 import { IConfigurationService, IDisposableRegistry, IInstaller, InstallerResponse, Product, Resource } from '../../common/types';
 import { InstallOptions } from '../../common/installer/types';
@@ -49,6 +49,8 @@ export class PositronJediLanguageServerProxy implements ILanguageServerProxy {
 
     private registered = false;
 
+    private readonly minimumSupportedVersion = '3.8.0';
+
     constructor(
         private readonly serviceContainer: IServiceContainer,
         private readonly interpreterService: IInterpreterService,
@@ -161,20 +163,26 @@ export class PositronJediLanguageServerProxy implements ILanguageServerProxy {
         let debugPort;
         for (const interpreter of interpreters) {
 
-            // If required, also locate an available port for the debugger
-            if (debug) {
-                if (debugPort === undefined) {
-                    debugPort = 5678; // Default port for debugpy
+            // Only register runtimes for supported versions
+            if (this.isVersionSupported(interpreter?.version)) {
+
+                // If required, also locate an available port for the debugger
+                if (debug) {
+                    if (debugPort === undefined) {
+                        debugPort = 5678; // Default port for debugpy
+                    }
+                    debugPort = await portfinder.getPortPromise({ port: debugPort });
                 }
-                debugPort = await portfinder.getPortPromise({ port: debugPort });
-            }
 
-            const runtime: vscode.Disposable = await this.registerLanguageRuntime(
-                jupyterAdapterApi, interpreter, debugPort, logLevel, options);
-            this.disposables.push(runtime);
+                const runtime: vscode.Disposable = await this.registerLanguageRuntime(
+                    jupyterAdapterApi, interpreter, debugPort, logLevel, options);
+                this.disposables.push(runtime);
 
-            if (debugPort !== undefined) {
-                debugPort += 1;
+                if (debugPort !== undefined) {
+                    debugPort += 1;
+                }
+            } else {
+                traceVerbose(`Not registering runtime due to unsupported interpreter version ${interpreter.displayName}`);
             }
         }
     }
@@ -257,11 +265,20 @@ export class PositronJediLanguageServerProxy implements ILanguageServerProxy {
             // Compare versions in descending order
             const av: string = this.getVersionString(a.version);
             const bv: string = this.getVersionString(b.version);
-            return -compare(av, bv);
+            return -semver.compare(av, bv);
         });
         return copy;
     }
 
+    /**
+     * Check if a version is supported (i.e. >= the minimum supported version).
+     * Also returns true if the version could not be determined.
+     */
+    private isVersionSupported(version: PythonVersion | undefined): boolean {
+        const versionString = version && this.getVersionString(version);
+        return !versionString || semver.gte(versionString, this.minimumSupportedVersion);
+    }
+
     /**
      * Formats python version info as a semver string, adapted from
      * common/utils/version to work with PythonVersion instances.