Commit 6b162bf
authored
Set up typing on
Addresses #10593
This PR makes the typing for the new `console.fontLigatures` and
`console.fontVariations` settings the same as what we inherited for
`editor.fontLigatures` and `editor.fontVariations`, since that is how
these settings actually work. This does not change how these settings
function but now the hinting in `settings.json` is correct:
<img width="1028" height="336" alt="Screenshot 2025-12-03 at 7 24 59 PM"
src="https://github.com/user-attachments/assets/8ba356d3-3c45-4c8c-aa49-1c790681ab96"
/>
### Release Notes
#### New Features
- N/A
#### Bug Fixes
- Fixed typing for Positron's `console.fontLigatures` setting
### QA Notes
If you use a setting like `"console.fontLigatures": "'ss05'"` you should
get no errors and the same hinting that you would get for
`"editor.fontLigatures": "'ss05'"`.console.fontLigatures and console.fontVariations so it is the same as the editor counterparts (#10928)1 parent cad322b commit 6b162bf
File tree
2 files changed
+35
-14
lines changed- src/vs/workbench
- browser
- services/positronConsole/browser
2 files changed
+35
-14
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | | - | |
| 17 | + | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
| 28 | + | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
38 | 41 | | |
39 | | - | |
| 42 | + | |
40 | 43 | | |
41 | 44 | | |
42 | 45 | | |
| |||
Lines changed: 26 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
197 | 197 | | |
198 | 198 | | |
199 | 199 | | |
200 | | - | |
201 | | - | |
202 | | - | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
203 | 212 | | |
204 | 213 | | |
205 | 214 | | |
| |||
211 | 220 | | |
212 | 221 | | |
213 | 222 | | |
214 | | - | |
215 | | - | |
216 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
217 | 235 | | |
218 | 236 | | |
219 | 237 | | |
| |||
1697 | 1715 | | |
1698 | 1716 | | |
1699 | 1717 | | |
1700 | | - | |
| 1718 | + | |
1701 | 1719 | | |
1702 | 1720 | | |
1703 | 1721 | | |
| |||
1723 | 1741 | | |
1724 | 1742 | | |
1725 | 1743 | | |
1726 | | - | |
| 1744 | + | |
1727 | 1745 | | |
1728 | 1746 | | |
1729 | 1747 | | |
| |||
0 commit comments