Skip to content

Commit 6c59780

Browse files
authored
ci: move windows ext slack notify up to caller (#10948)
### Summary This should ensure that Slack notifications only include windows for data collection in the alternate Slack channel, and not be added to the notification that goes into #positron-test-results. **Current:** <img width="1351" height="580" alt="Screenshot 2025-12-04 at 12 46 32 PM" src="https://github.com/user-attachments/assets/be10d0ca-78dc-4dbc-99ac-354dd03d3193" /> <img width="617" height="198" alt="Screenshot 2025-12-04 at 1 00 41 PM" src="https://github.com/user-attachments/assets/524997e6-a51a-4f4d-b152-38e83ea85b75" /> **After:** Both slack notify jobs will be at same level. The "cancelled" (not run) slack-notify will not appear in our standard slack channel notifications. ### QA Notes I admit, I didn't test it because we don't have a manual trigger on this workflow. I will keep an eye on merges.
1 parent 62f21bd commit 6c59780

File tree

2 files changed

+19
-16
lines changed

2 files changed

+19
-16
lines changed

.github/workflows/test-e2e-windows.yml

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@ on:
4747
description: "Whether to allow tests marked with :soft-fail to fail without failing the job."
4848
type: boolean
4949
default: false
50+
outputs:
51+
extensions_failed:
52+
description: "Whether the extensions tests failed"
53+
value: ${{ jobs.e2e-windows.outputs.extensions_failed }}
5054

5155
workflow_dispatch:
5256
inputs:
@@ -355,19 +359,3 @@ jobs:
355359
with:
356360
name: inspect-ai-responses
357361
path: test/assistant-inspect-ai/*.json
358-
359-
slack-notify:
360-
if: ${{ needs.e2e-windows.outputs.extensions_failed == 'true' }}
361-
needs:
362-
- e2e-windows
363-
runs-on: ubuntu-latest
364-
steps:
365-
- run: |
366-
echo "Will notify on: ${{ env.notify_on }}"
367-
- name: Notify Slack
368-
uses: midleman/[email protected]
369-
with:
370-
gh_repo_token: ${{ secrets.GITHUB_TOKEN }}
371-
slack_token: ${{ secrets.SLACK_TOKEN_TEST_STATUS }}
372-
slack_channel: "#positron-rstats-test-results"
373-
filter_jobs: "e2e"

.github/workflows/test-merge.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,3 +96,18 @@ jobs:
9696
filter_jobs: "(e2e / ([^0-9]*)|unit|integration)$"
9797
include_job_durations: false
9898
notify_on: "failure"
99+
100+
slack-notify-win-extensions:
101+
if: ${{ needs.e2e-windows-electron.outputs.extensions_failed == 'true' }}
102+
needs:
103+
- e2e-windows-electron
104+
runs-on: ubuntu-latest
105+
steps:
106+
- name: Notify Slack
107+
uses: midleman/[email protected]
108+
with:
109+
gh_repo_token: ${{ secrets.GITHUB_TOKEN }}
110+
slack_token: ${{ secrets.SLACK_TOKEN_TEST_STATUS }}
111+
slack_channel: "#positron-rstats-test-results"
112+
filter_jobs: "windows"
113+
notify_on: "always"

0 commit comments

Comments
 (0)