Commit 707743c
authored
Remove experimental data explorer config (#9604)
Addresses #8528
Related PR for Ark: posit-dev/ark#931
Addresses the second half of #8528 which was to remove the
`dataExplorer.Experimental` config setting since it is confusing for
users when they see it.
For features that require frontend and backend coordination for the data
explorer, we have a system for declaring what features are supported.
The `SupportedFeatures` interface communicates the list of features that
are supported/unsupported by each backend. Each feature declares its
support status via a value from the `SupportStatus` enum. This enum has
three possible options: `Supported`, `Unsupported`, and `Experimental`.
We are removing the `Experimental` option and
`dataExplorer.Experimental` config setting since it isn't really used
for development (I think?). We recently added a new feature to the
`SupportedFeatures` list, convert to code, and that feature didn't
utilize the `Experimental` setting.
This change involved updating the data explorer backend rpc comm json to
remove the `Experimental` value.
This is my first time updating comms, so extra eyes on the changes would
be nice. I was able to test the changes agains a local build of ark but
additional testing would be appreciated to make sure I didn't miss
anything.
To get this change across the finish line, I believe we want to merge
the Ark PR first, release Ark (?), and then pick up the new Ark version
in this PR before this PR is merged.
### Release Notes
<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
The note will automatically be tagged with the language.
These notes are typically filled by the Positron team. If you are an
external
contributor, you may ignore this section.
-->
#### New Features
- Remove experimental Data Explorer config setting (#8528)
#### Bug Fixes
- N/A
### QA Notes
There isn't anything specific to test here since this setting was never
used. We'll just want to verify that `dataExplorer.Experimental` no
longer shows up in Settings:
<img width="1273" height="417" alt="Screenshot 2025-09-25 at 3 40 17 PM"
src="https://github.com/user-attachments/assets/73c18519-1d2f-4a8e-997c-7b9db2758053"
/>
@:data-explorer @:web @:win1 parent c9bfa10 commit 707743c
File tree
11 files changed
+12
-101
lines changed- extensions
- positron-duckdb/src
- positron-python/python_files/posit/positron
- positron-r
- positron/comms
- src/vs/workbench
- browser/positronDataExplorer/components/dataExplorerPanel/components/rowFilterBar
- services
- languageRuntime/common
- positronDataExplorer
- browser
- common
11 files changed
+12
-101
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1314 | 1314 | | |
1315 | 1315 | | |
1316 | 1316 | | |
1317 | | - | |
1318 | | - | |
| 1317 | + | |
1319 | 1318 | | |
1320 | 1319 | | |
1321 | 1320 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
233 | | - | |
234 | 232 | | |
235 | 233 | | |
236 | 234 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
974 | 974 | | |
975 | 975 | | |
976 | 976 | | |
977 | | - | |
| 977 | + | |
978 | 978 | | |
979 | 979 | | |
980 | 980 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1771 | 1771 | | |
1772 | 1772 | | |
1773 | 1773 | | |
1774 | | - | |
1775 | | - | |
| 1774 | + | |
1776 | 1775 | | |
1777 | 1776 | | |
1778 | 1777 | | |
| |||
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | 28 | | |
30 | 29 | | |
31 | 30 | | |
| |||
141 | 140 | | |
142 | 141 | | |
143 | 142 | | |
144 | | - | |
| 143 | + | |
145 | 144 | | |
146 | 145 | | |
147 | 146 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1268 | 1268 | | |
1269 | 1269 | | |
1270 | 1270 | | |
1271 | | - | |
1272 | | - | |
| 1271 | + | |
1273 | 1272 | | |
1274 | 1273 | | |
1275 | 1274 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | | - | |
143 | 142 | | |
144 | 143 | | |
145 | 144 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
827 | 826 | | |
828 | 827 | | |
829 | 828 | | |
830 | | - | |
| 829 | + | |
831 | 830 | | |
832 | 831 | | |
833 | 832 | | |
| |||
Lines changed: 2 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
| 23 | + | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
344 | 343 | | |
345 | 344 | | |
346 | 345 | | |
347 | | - | |
348 | | - | |
349 | | - | |
350 | | - | |
| 346 | + | |
351 | 347 | | |
352 | 348 | | |
353 | 349 | | |
| |||
Lines changed: 0 additions & 67 deletions
This file was deleted.
0 commit comments