Skip to content

Commit 707743c

Browse files
Remove experimental data explorer config (#9604)
Addresses #8528 Related PR for Ark: posit-dev/ark#931 Addresses the second half of #8528 which was to remove the `dataExplorer.Experimental` config setting since it is confusing for users when they see it. For features that require frontend and backend coordination for the data explorer, we have a system for declaring what features are supported. The `SupportedFeatures` interface communicates the list of features that are supported/unsupported by each backend. Each feature declares its support status via a value from the `SupportStatus` enum. This enum has three possible options: `Supported`, `Unsupported`, and `Experimental`. We are removing the `Experimental` option and `dataExplorer.Experimental` config setting since it isn't really used for development (I think?). We recently added a new feature to the `SupportedFeatures` list, convert to code, and that feature didn't utilize the `Experimental` setting. This change involved updating the data explorer backend rpc comm json to remove the `Experimental` value. This is my first time updating comms, so extra eyes on the changes would be nice. I was able to test the changes agains a local build of ark but additional testing would be appreciated to make sure I didn't miss anything. To get this change across the finish line, I believe we want to merge the Ark PR first, release Ark (?), and then pick up the new Ark version in this PR before this PR is merged. ### Release Notes <!-- Optionally, replace `N/A` with text to be included in the next release notes. The `N/A` bullets are ignored. If you refer to one or more Positron issues, these issues are used to collect information about the feature or bugfix, such as the relevant language pack as determined by Github labels of type `lang: `. The note will automatically be tagged with the language. These notes are typically filled by the Positron team. If you are an external contributor, you may ignore this section. --> #### New Features - Remove experimental Data Explorer config setting (#8528) #### Bug Fixes - N/A ### QA Notes There isn't anything specific to test here since this setting was never used. We'll just want to verify that `dataExplorer.Experimental` no longer shows up in Settings: <img width="1273" height="417" alt="Screenshot 2025-09-25 at 3 40 17 PM" src="https://github.com/user-attachments/assets/73c18519-1d2f-4a8e-997c-7b9db2758053" /> @:data-explorer @:web @:win
1 parent c9bfa10 commit 707743c

File tree

11 files changed

+12
-101
lines changed

11 files changed

+12
-101
lines changed

extensions/positron-duckdb/src/interfaces.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1314,8 +1314,7 @@ export enum ExportFormat {
13141314
*/
13151315
export enum SupportStatus {
13161316
Unsupported = 'unsupported',
1317-
Supported = 'supported',
1318-
Experimental = 'experimental'
1317+
Supported = 'supported'
13191318
}
13201319

13211320
/**

extensions/positron-python/python_files/posit/positron/data_explorer_comm.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,6 @@ class SupportStatus(str, enum.Enum):
229229

230230
Supported = "supported"
231231

232-
Experimental = "experimental"
233-
234232

235233
class OpenDatasetResult(BaseModel):
236234
"""

extensions/positron-r/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -974,7 +974,7 @@
974974
},
975975
"positron": {
976976
"binaryDependencies": {
977-
"ark": "0.1.211"
977+
"ark": "0.1.212"
978978
},
979979
"minimumRVersion": "4.2.0",
980980
"minimumRenvVersion": "1.0.9"

positron/comms/data_explorer-backend-openrpc.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1771,8 +1771,7 @@
17711771
"description": "The support status of the RPC method",
17721772
"enum": [
17731773
"unsupported",
1774-
"supported",
1775-
"experimental"
1774+
"supported"
17761775
]
17771776
}
17781777
}

src/vs/workbench/browser/positronDataExplorer/components/dataExplorerPanel/components/rowFilterBar/rowFilterBar.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,13 @@ import { usePositronDataExplorerContext } from '../../../../positronDataExplorer
1818
import { Button } from '../../../../../../../base/browser/ui/positronComponents/button/button.js';
1919
import { AddEditRowFilterModalPopup } from '../addEditRowFilterModalPopup/addEditRowFilterModalPopup.js';
2020
import { PositronModalReactRenderer } from '../../../../../../../base/browser/positronModalReactRenderer.js';
21-
import { ColumnSchema } from '../../../../../../services/languageRuntime/common/positronDataExplorerComm.js';
21+
import { ColumnSchema, SupportStatus } from '../../../../../../services/languageRuntime/common/positronDataExplorerComm.js';
2222
import { OKModalDialog } from '../../../../../positronComponents/positronModalDialog/positronOKModalDialog.js';
2323
import { getRowFilterDescriptor, RowFilterDescriptor } from '../addEditRowFilterModalPopup/rowFilterDescriptor.js';
2424
import { usePositronReactServicesContext } from '../../../../../../../base/browser/positronReactRendererContext.js';
2525
import { CustomContextMenuItem } from '../../../../../positronComponents/customContextMenu/customContextMenuItem.js';
2626
import { CustomContextMenuSeparator } from '../../../../../positronComponents/customContextMenu/customContextMenuSeparator.js';
2727
import { CustomContextMenuEntry, showCustomContextMenu } from '../../../../../positronComponents/customContextMenu/customContextMenu.js';
28-
import { dataExplorerExperimentalFeatureEnabled } from '../../../../../../services/positronDataExplorer/common/positronDataExplorerExperimentalConfig.js';
2928

3029
/**
3130
* Constants.
@@ -141,7 +140,7 @@ export const RowFilterBar = () => {
141140
}, [context.instance.dataExplorerClientInstance, context.instance.tableDataDataGridInstance, rowFilterDescriptors, services.workbenchLayoutService]);
142141

143142
const features = backendClient.getSupportedFeatures();
144-
const canFilter = dataExplorerExperimentalFeatureEnabled(features.set_row_filters.support_status, services.configurationService);
143+
const canFilter = features.set_row_filters.support_status === SupportStatus.Supported;
145144

146145
/**
147146
* Filter button pressed handler.

src/vs/workbench/services/languageRuntime/common/positronDataExplorerComm.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,8 +1268,7 @@ export enum ExportFormat {
12681268
*/
12691269
export enum SupportStatus {
12701270
Unsupported = 'unsupported',
1271-
Supported = 'supported',
1272-
Experimental = 'experimental'
1271+
Supported = 'supported'
12731272
}
12741273

12751274
/**

src/vs/workbench/services/positronDataExplorer/browser/positronDataExplorerInstance.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ export class PositronDataExplorerInstance extends Disposable implements IPositro
139139

140140
// Create the table summary cache.
141141
this._register(this._tableSummaryCache = new TableSummaryCache(
142-
this._services.configurationService,
143142
this._dataExplorerClientInstance
144143
));
145144

src/vs/workbench/services/positronDataExplorer/browser/tableDataDataGridInstance.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { CustomContextMenuSeparator } from '../../../browser/positronComponents/
2121
import { PositronDataExplorerCommandId } from '../../../contrib/positronDataExplorerEditor/browser/positronDataExplorerActions.js';
2222
import { InvalidateCacheFlags, TableDataCache, WidthCalculators } from '../common/tableDataCache.js';
2323
import { CustomContextMenuEntry, showCustomContextMenu } from '../../../browser/positronComponents/customContextMenu/customContextMenu.js';
24-
import { dataExplorerExperimentalFeatureEnabled } from '../common/positronDataExplorerExperimentalConfig.js';
2524
import { BackendState, ColumnSchema, DataSelectionCellIndices, DataSelectionIndices, DataSelectionSingleCell, ExportFormat, RowFilter, SupportStatus, TableSelection, TableSelectionKind } from '../../languageRuntime/common/positronDataExplorerComm.js';
2625
import { ClipboardCell, ClipboardCellIndexes, ClipboardColumnIndexes, ClipboardData, ClipboardRowIndexes, ColumnSelectionState, ColumnSortKeyDescriptor, DataGridInstance, MouseSelectionType, RowSelectionState } from '../../../browser/positronDataGrid/classes/dataGridInstance.js';
2726
import { PositronReactServices } from '../../../../base/browser/positronReactServices.js';
@@ -827,7 +826,7 @@ export class TableDataDataGridInstance extends DataGridInstance {
827826
* Given a status check if the feature is enabled.
828827
*/
829828
isFeatureEnabled(status: SupportStatus): boolean {
830-
return dataExplorerExperimentalFeatureEnabled(status, this._services.configurationService);
829+
return status === SupportStatus.Supported;
831830
}
832831

833832
//#endregion Public Methods

src/vs/workbench/services/positronDataExplorer/browser/tableSummaryDataGridInstance.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ import { COLUMN_PROFILE_DATE_TIME_LINE_COUNT } from './components/columnProfileD
2020
import { DataGridInstance } from '../../../browser/positronDataGrid/classes/dataGridInstance.js';
2121
import { DataExplorerClientInstance } from '../../languageRuntime/common/languageRuntimeDataExplorerClient.js';
2222
import { PositronActionBarHoverManager } from '../../../../platform/positronActionBar/browser/positronActionBarHoverManager.js';
23-
import { BackendState, ColumnDisplayType, ColumnProfileType, SearchSchemaSortOrder } from '../../languageRuntime/common/positronDataExplorerComm.js';
24-
import { dataExplorerExperimentalFeatureEnabled } from '../common/positronDataExplorerExperimentalConfig.js';
23+
import { BackendState, ColumnDisplayType, ColumnProfileType, SearchSchemaSortOrder, SupportStatus } from '../../languageRuntime/common/positronDataExplorerComm.js';
2524

2625
/**
2726
* Constants.
@@ -344,10 +343,7 @@ export class TableSummaryDataGridInstance extends DataGridInstance {
344343
}
345344

346345
// Return the summary stats support status.
347-
return dataExplorerExperimentalFeatureEnabled(
348-
summaryStatsSupportStatus.support_status,
349-
this.configurationService
350-
);
346+
return summaryStatsSupportStatus.support_status === SupportStatus.Supported;
351347
}
352348

353349
/**

src/vs/workbench/services/positronDataExplorer/common/positronDataExplorerExperimentalConfig.ts

Lines changed: 0 additions & 67 deletions
This file was deleted.

0 commit comments

Comments
 (0)