Skip to content

Commit 82d7eb5

Browse files
authored
Fix Windows postinstall launching Positron with silent option (#11084)
Address #10843 The task needs to run in silent mode for updates. There is an existing check on background updates where it looks for a marker file to signal that an update is in progress. This occurs with the `/update` option that Positron passes to the installer in an update scenario. For a typical admin install, they may script the installation or run it from command line. The silent option wasn't enough to prevent launching Positron. Adding the background update check restricts it to the update scenario. Note: there is also the `[Run]` section that can launch Positron but it is the option at the end of the wizard installation. ### Release Notes #### New Features - N/A #### Bug Fixes - Fix Windows installer launching Positron when run in silent mode ### QA Notes * Installer should respect the option to launch Positron at the end of the install * Running the installer from the command line in silent mode should not run Positron * The auto-update should re-launch Positron after initiating the "Restart to Update"
1 parent b23af49 commit 82d7eb5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build/win32/positron.iss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ Name: "addcontextmenufiles"; Description: "{cm:AddContextMenuFiles,{#NameShort}}
8585
Name: "addcontextmenufolders"; Description: "{cm:AddContextMenuFolders,{#NameShort}}"; GroupDescription: "{cm:Other}"; Flags: unchecked; Check: not (IsWindows11OrLater and QualityIsInsiders)
8686
Name: "associatewithfiles"; Description: "{cm:AssociateWithFiles,{#NameShort}}"; GroupDescription: "{cm:Other}"
8787
Name: "addtopath"; Description: "{cm:AddToPath}"; GroupDescription: "{cm:Other}"
88-
Name: "runcode"; Description: "{cm:RunAfter,{#NameShort}}"; GroupDescription: "{cm:Other}"; Check: WizardSilent
88+
Name: "runcode"; Description: "{cm:RunAfter,{#NameShort}}"; GroupDescription: "{cm:Other}"; Check: WizardSilent and IsBackgroundUpdate
8989

9090
[Dirs]
9191
Name: "{app}"; AfterInstall: DisableAppDirInheritance

0 commit comments

Comments
 (0)