e2e: fix new folder flow conda test (#8789)

### Summary

This PR resolves a flake in the new folder flow test related to Conda
environment creation. The test would occasionally fail because the
`create-conda.py` script fell back to the defaults channel, despite CI
being configured to use `conda-forge` via Miniforge.

We could use either Miniforge or Miniconda, but for now we prefer
Miniforge due to recent changes to Miniconda that require Terms of
Service acceptance when using the defaults channel and this also aligns
with the container work done by @testlabauto.

### QA Notes

@:new-folder-flow @:web

Author: midleman

.github/actions/install-python/action.yml

@@ -91,31 +91,17 @@ runs:
         echo "Setting up Conda environment with Python 3.12..."
 
         # Ensure Conda is available
-        source "${CONDA}/etc/profile.d/conda.sh"
+        source "$CONDA/etc/profile.d/conda.sh"
 
         # Define environment path
         CONDA_ENV_DIR="$HOME/scratch/python-env"
 
-        # Create a new Conda environment with Python 3.12
-        conda create -y -p "$CONDA_ENV_DIR" python=3.12.10 pip setuptools
+        # NOTE: When using Minforge conda-forge is the default and override is no longer strictly necessary,
+        # but we keep it to prevent any unintentional fallback if configs change.
+        conda create -y --override-channels -c conda-forge -p "$CONDA_ENV_DIR" python=3.12.10 pip setuptools
 
-        # Verify Python installation
-        PYTHON_BIN="$CONDA_ENV_DIR/bin/python"
+        echo "Verifying Python in Conda environment..."
+        "$CONDA_ENV_DIR/bin/python" --version
+        "$CONDA_ENV_DIR/bin/python" -c "import sys; print(f'Python {sys.version} is working!')"
 
-        if [[ -x "$PYTHON_BIN" ]]; then
-            echo "Python successfully installed in Conda environment at $PYTHON_BIN"
-            $PYTHON_BIN --version
-        else
-            echo "Error: Python binary not found in Conda environment!"
-            exit 1
-        fi
-
-        # Verify Python modules are working
-        echo "Checking if Python modules work..."
-        $PYTHON_BIN -c "import venv, sys; print(f'Python {sys.version} modules are working!')"
-
-        # Final verification
-        echo "Final Python check..."
-        $PYTHON_BIN -c "import sys; print(f'Python {sys.version} is working!')"
-
-        echo "Miniconda-based Python 3.12 setup complete!"
+        echo "Miniforge-based Python 3.12 setup complete!"

.github/actions/setup-test-env/action.yml

@@ -36,12 +36,15 @@ runs:
       with:
         tinytex: true
 
+    # Miniforge avoids Anaconda ToS and defaults to conda-forge
     - name: Setup Conda (Miniforge3)
       uses: conda-incubator/setup-miniconda@v3
       with:
-        miniforge-variant: Miniforge3
         miniforge-version: latest
         auto-activate-base: false
+        channels: conda-forge,defaults  # Defaults included only to suppress warnings; all packages are still resolved from conda-forge
+        conda-remove-defaults: "true"
+        channel-priority: strict
 
     - name: Setup Python
       uses: ./.github/actions/install-python

extensions/positron-python/python_files/create_conda.py

@@ -104,19 +104,30 @@ def main(argv: Optional[Sequence[str]] = None) -> None:
         env_path = get_conda_env_path(args.name)
         print(f"EXISTING_CONDA_ENV:{env_path}")
     else:
+        # --- Start Positron ---
+        # Special case for Playwright CI: force conda-forge to avoid ToS prompt from defaults
+        is_playwright_test = os.environ.get("PW_TEST") == "1"
+
+        cmd = [
+            sys.executable,
+            "-m",
+            "conda",
+            "create",
+            "--yes",
+            "--prefix",
+            args.name,
+            f"python={args.python}",
+        ]
+
+        if is_playwright_test:
+            print("PW_TEST env var detected: Configuring conda to use conda-forge channel only")
+            cmd.extend(["--override-channels", "-c", "conda-forge"])
+
         run_process(
-            [
-                sys.executable,
-                "-m",
-                "conda",
-                "create",
-                "--yes",
-                "--prefix",
-                args.name,
-                f"python={args.python}",
-            ],
+            cmd,
             "CREATE_CONDA.ENV_FAILED_CREATION",
         )
+        # --- End Positron ---
         env_path = get_conda_env_path(args.name)
         print(f"CREATED_CONDA_ENV:{env_path}")
         if args.git_ignore:

extensions/positron-python/src/client/pythonEnvironments/creation/provider/condaCreationProvider.ts

@@ -98,6 +98,9 @@ async function createCondaEnv(
         cwd: workspace.uri.fsPath,
         env: {
             PATH: pathEnv,
+            // --- Start Positron ---
+            PW_TEST: process.env.PW_TEST,
+            // --- End Positron ---
         },
     });
 

test/e2e/pages/hotKeys.ts

@@ -156,7 +156,7 @@ export class HotKeys {
 
 	public async closeWorkspace() {
 		await this.pressHotKeys('Cmd+J W');
-		await expect(this.code.driver.page.locator('.explorer-folders-view')).toBeVisible();
+		await expect(this.code.driver.page.locator('.explorer-folders-view')).not.toBeVisible();
 	}
 
 	public async importSettings() {

test/e2e/tests/new-folder-flow/new-folder-flow-python.test.ts

@@ -59,7 +59,7 @@ test.describe('New Folder Flow: Python Project', { tag: [tags.MODAL, tags.NEW_FO
 		await verifyPyprojectTomlCreated(app);
 	});
 
-	test.skip('New env: Conda environment', async function ({ app }) {
+	test('New env: Conda environment', async function ({ app }) {
 		const folderName = addRandomNumSuffix('conda-installed');
 		await createNewFolder(app, {
 			folderTemplate,

test/e2e/tests/welcome/welcome.test.ts

@@ -94,11 +94,8 @@ test.describe('Welcome Page', { tag: [tags.WELCOME, tags.WEB] }, () => {
 	});
 
 	test.describe('No Workspace', () => {
-		test.beforeAll(async function ({ hotKeys }) {
-			await hotKeys.closeWorkspace();
-		});
-
 		test.beforeEach(async function ({ hotKeys, sessions }) {
+			await hotKeys.closeWorkspace();
 			await sessions.expectSessionPickerToBe('Start Session');
 			await sessions.expectNoStartUpMessaging();
 			await hotKeys.openWelcomeWalkthrough();