e2e: more flake fixes (#10964)

### Summary
* Addressing 3 tests that are flaky:
   * `search.test.ts`
Removed final menu collapse step. A tooltip frequently blocks the
collapse button, causing intermittent failures. This step is not
essential to the test.
   * `default-python-interpreter.test.ts`
Added wait for session initialization before asserting metadata.
Previously caused reload loops when metadata was accessed before the
session was ready.
   * `notebook-working-directory.test`
Added retry logic for cell execution. Cells occasionally hang for 30s
(expected execution time is <1s). Test now stops execution and retries
on timeout.
* Skipping the reticulate tests
* Fixing a timing issue for chromium when selecting interpreters

### QA Notes

@:interpreter @:web @:positron-notebooks

<!--
  Add additional information for QA on how to validate the change,
  paying special attention to the level of risk, adjacent areas that
  could be affected by the change, and any important contextual
  information not present in the linked issues.
-->

Author: midleman

test/e2e/fixtures/test-setup/settings.fixtures.ts

@@ -3,7 +3,6 @@
  *  Licensed under the Elastic License 2.0. See LICENSE.txt for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import * as playwright from '@playwright/test';
 import { Application } from '../../infra';
 
 export function SettingsFixture(app: Application) {
@@ -19,10 +18,7 @@ export function SettingsFixture(app: Application) {
 			await settings.set(newSettings, { keepOpen });
 
 			if (reload === true || (reload === 'web' && app.web === true)) {
-				await app.workbench.hotKeys.reloadWindow();
-				// wait for the reload to complete
-				await app.code.driver.page.waitForTimeout(3000);
-				await playwright.expect(app.code.driver.page.locator('.monaco-workbench')).toBeVisible();
+				await app.workbench.hotKeys.reloadWindow(true);
 			}
 			if (waitMs) {
 				await app.code.driver.page.waitForTimeout(waitMs); // wait for settings to take effect

test/e2e/infra/workbench.ts

@@ -120,7 +120,7 @@ export class Workbench {
 		this.sessions = new Sessions(code, this.quickaccess, this.quickInput, this.console, this.contextMenu, this.modals);
 		this.notebooks = new Notebooks(code, this.quickInput, this.quickaccess, this.hotKeys);
 		this.notebooksVscode = new VsCodeNotebooks(code, this.quickInput, this.quickaccess, this.hotKeys);
-		this.notebooksPositron = new PositronNotebooks(code, this.quickInput, this.quickaccess, this.hotKeys, this.contextMenu);
+		this.notebooksPositron = new PositronNotebooks(code, this.quickInput, this.quickaccess, this.hotKeys, this.contextMenu, this.sessions);
 		this.welcome = new Welcome(code);
 		this.terminal = new Terminal(code, this.quickaccess, this.clipboard);
 		this.viewer = new Viewer(code);

test/e2e/pages/notebooks.ts

@@ -37,6 +37,7 @@ export class Notebooks {
 	frameLocator: FrameLocator;
 	notebookProgressBar: Locator;
 	cellIndex: (num?: number) => Locator;
+	interruptButton: Locator;
 
 	constructor(code: Code, quickinput: QuickInput, quickaccess: QuickAccess, hotKeys: HotKeys) {
 		this.code = code;
@@ -49,6 +50,7 @@ export class Notebooks {
 		this.frameLocator = this.code.driver.page.frameLocator(OUTER_FRAME).frameLocator(INNER_FRAME);
 		this.notebookProgressBar = this.code.driver.page.locator('[id="workbench\\.parts\\.editor"]').getByRole('progressbar');
 		this.cellIndex = (num = 0) => this.code.driver.page.locator('.cell-inner-container > .cell').nth(num);
+		this.interruptButton = this.code.driver.page.getByRole('button', { name: 'Interrupt' });
 	}
 
 	async selectInterpreter(
@@ -162,14 +164,18 @@ export class Notebooks {
 		await expect(markdownLocator).toHaveText(expectedText);
 	}
 
-	async runAllCells(timeout: number = 30000) {
+	async runAllCells({ timeout = 15000, throwError = false } = {}): Promise<void> {
 		await test.step('Run all cells', async () => {
 			await this.code.driver.page.getByLabel('Run All').click();
 			const stopExecutionLocator = this.code.driver.page.locator('a').filter({ hasText: /Stop Execution|Interrupt/ });
 			try {
-				await expect(stopExecutionLocator).toBeVisible();
+				await expect(stopExecutionLocator).toBeVisible({ timeout: 5000 });
 				await expect(stopExecutionLocator).not.toBeVisible({ timeout });
-			} catch { } // can be normal with very fast execution
+			} catch {
+				if (throwError) {
+					throw new Error('Timeout waiting for all cells to finish executing');
+				}
+			} // can be normal with very fast execution
 		});
 	}
 

test/e2e/pages/notebooksPositron.ts

@@ -10,7 +10,7 @@ import { QuickAccess } from './quickaccess';
 import test, { expect, Locator } from '@playwright/test';
 import { HotKeys } from './hotKeys.js';
 import { ContextMenu, MenuItemState } from './dialog-contextMenu.js';
-import { ACTIVE_STATUS_ICON, DISCONNECTED_STATUS_ICON, IDLE_STATUS_ICON, SessionState } from './sessions.js';
+import { ACTIVE_STATUS_ICON, DISCONNECTED_STATUS_ICON, IDLE_STATUS_ICON, Sessions, SessionState } from './sessions.js';
 import { basename, relative } from 'path';
 
 const DEFAULT_TIMEOUT = 10000;
@@ -53,7 +53,7 @@ export class PositronNotebooks extends Notebooks {
 	viewMarkdown = this.code.driver.page.getByRole('button', { name: 'View markdown' });
 	expandMarkdownEditor = this.code.driver.page.getByRole('button', { name: 'Open markdown editor' });
 
-	constructor(code: Code, quickinput: QuickInput, quickaccess: QuickAccess, hotKeys: HotKeys, private contextMenu: ContextMenu) {
+	constructor(code: Code, quickinput: QuickInput, quickaccess: QuickAccess, hotKeys: HotKeys, private contextMenu: ContextMenu, private sessions: Sessions) {
 		super(code, quickinput, quickaccess, hotKeys);
 		this.kernel = new Kernel(this.code, this, this.contextMenu, hotKeys, quickinput);
 	}
@@ -175,6 +175,7 @@ export class PositronNotebooks extends Notebooks {
 			'workbench.editorAssociations': { '*.ipynb': 'workbench.editor.positronNotebook' }
 		};
 		await settings.set(config, { reload: 'web' });
+		await this.sessions.expectNoStartUpMessaging();
 	}
 
 	/**

test/e2e/pages/sessions.ts

@@ -451,7 +451,7 @@ export class Sessions {
 			// Wait until the desired runtime appears in the list and select it.
 			// We need to click instead of using 'enter' because the Python select interpreter command
 			// may include additional items above the desired interpreter string.
-			await this.quickinput.selectQuickInputElementContaining(`${language} ${version}`, { timeout: 5000 });
+			await this.quickinput.selectQuickInputElementContaining(`${language} ${version}`);
 			await this.quickinput.waitForQuickInputClosed();
 
 			// Move mouse to prevent tooltip hover

test/e2e/tests/interpreters/default-python-interpreter.test.ts

@@ -6,6 +6,8 @@
 import { expect } from '@playwright/test';
 import { test, tags } from '../_test.setup';
 import { deletePositronHistoryFiles } from './helpers/default-interpreters.js';
+import { buildPythonPath } from './helpers/include-excludes.js';
+import path from 'path';
 
 test.use({
 	suiteId: __filename
@@ -17,50 +19,44 @@ test.describe('Default Interpreters - Python', {
 }, () => {
 
 	test.beforeAll(async function ({ settings }) {
-
-		await settings.remove(['interpreters.startupBehavior']);
 		await settings.set({ 'interpreters.startupBehavior': 'always' });
-
 		await deletePositronHistoryFiles();
 
-		// local debugging sample:
-		// const homeDir = process.env.HOME || '';
-		// await settings.set({'python.defaultInterpreterPath': `${path.join(homeDir, '.pyenv/versions/3.13.0/bin/python')}`}, { reload: true });
-
-		const pythonPath = '/root/scratch/python-env/bin/python';
+		// Build environment-aware path for default interpreter
+		// Note: CI uses hidden Python in /root/scratch, local uses pyenv version
+		const pythonVersion = process.env.POSITRON_PY_VER_SEL || '3.10.12';
+		const pythonPath = process.env.CI
+			? `${buildPythonPath('include')}/bin/python` // Hidden Python (POSITRON_HIDDEN_PY)
+			: path.join(process.env.HOME || '', `.pyenv/versions/${pythonVersion}/bin/python`);
 
+		// First reload: "Apply these settings"
 		await settings.set({ 'python.defaultInterpreterPath': pythonPath }, { reload: true });
-
 	});
 
 	test.afterAll(async function ({ cleanup }) {
-
 		await cleanup.discardAllChanges();
-
 	});
 
-	test('Python - Add a default interpreter (Conda)', async function ({ runCommand, sessions }) {
-
-		await runCommand('workbench.action.reloadWindow');
-
-		await expect(async () => {
+	test('Python - Add a default interpreter (Conda)', async function ({ hotKeys, sessions }) {
+		// Second reload: "Now actually start the interpreter with these settings"
+		await hotKeys.reloadWindow(true);
 
-			try {
-				const { name, path } = await sessions.getMetadata();
+		// Get version from appropriate env var (hidden Python in CI, regular in local)
+		const pythonVersion = process.env.CI
+			? (process.env.POSITRON_HIDDEN_PY || '3.12.10').split(' ')[0] // Extract "3.12.10" from "3.12.10 (Conda)"
+			: process.env.POSITRON_PY_VER_SEL || '3.10.12';
 
-				// Local debugging sample:
-				// expect(name).toMatch(/Python 3\.13\.0/);
-				// expect(path).toMatch(/.pyenv\/versions\/3.13.0\/bin\/python/);
+		// Match version with optional text after (e.g., "Python 3.12.10 (Conda)")
+		const versionRegex = new RegExp(`Python ${pythonVersion.replace(/\./g, '\\.')}(\\s.*)?`);
 
-				// hidden CI interpreter:
-				expect(name).toMatch(/Python 3\.12\.10/);
-				expect(path).toMatch(/python-env\/bin\/python/);
+		// Build environment-aware path regex
+		const pathRegex = process.env.CI
+			? /python-env\/bin\/python/
+			: new RegExp(`~?\\.pyenv/versions/${pythonVersion.replace(/\./g, '\\.')}/bin/python`);
 
-			} catch (error) {
-				await runCommand('workbench.action.reloadWindow');
-				throw error;
-			}
+		const { name, path } = await sessions.getMetadata();
 
-		}).toPass({ timeout: 60000 });
+		expect(name).toMatch(versionRegex);
+		expect(path).toMatch(pathRegex);
 	});
 });

test/e2e/tests/notebook/notebook-large-python.test.ts

@@ -26,7 +26,7 @@ test.describe('Large Python Notebook', {
 		// open the large Python notebook and run all cells
 		await openDataFile(join('workspaces', 'large_py_notebook', 'spotify.ipynb'));
 		await notebooks.selectInterpreter('Python');
-		await notebooks.runAllCells(120000);
+		await notebooks.runAllCells({ timeout: 12000 });
 
 		// scroll through the notebook and count unique plot outputs
 		await layouts.enterLayout('notebook');

test/e2e/tests/notebook/notebook-large-r.test.ts

@@ -25,7 +25,7 @@ test.describe('Large R Notebook', {
 		// open the large R notebook and run all cells
 		await openDataFile(join('workspaces', 'large_r_notebook', 'spotify.ipynb'));
 		await notebooks.selectInterpreter('R');
-		await notebooks.runAllCells(120000);
+		await notebooks.runAllCells({ timeout: 12000 });
 
 		// scroll through the notebook and count unique plot outputs
 		await layouts.enterLayout('notebook');

test/e2e/tests/notebook/notebook-working-directory.test.ts

@@ -6,14 +6,14 @@
 import path from 'path';
 import fs from 'fs';
 import os from 'os';
-import { test, tags } from '../_test.setup';
+import { test, tags, expect } from '../_test.setup';
 import { Notebooks } from '../../pages/notebooks.js';
 
 test.use({
 	suiteId: __filename
 });
 
-test.describe.skip('Notebook Working Directory Configuration', {
+test.describe('Notebook Working Directory Configuration', {
 	tag: [tags.WIN, tags.WEB, tags.NOTEBOOKS]
 }, () => {
 
@@ -25,53 +25,65 @@ test.describe.skip('Notebook Working Directory Configuration', {
 		await app.workbench.notebooks.closeNotebookWithoutSaving();
 	});
 
-	test('Default working directory is the notebook parent', async function ({ app, settings }) {
-		await settings.clear();
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, 'working-directory-notebook');
-	});
+	const testCases = [
+		{
+			title: 'Default working directory is the notebook parent',
+			workingDirectory: null, // null = use default (clear settings)
+			expectedEnd: 'working-directory-notebook',
+		},
+		{
+			title: 'workspaceFolder works',
+			workingDirectory: '${workspaceFolder}',
+			expectedEnd: 'qa-example-content',
+		},
+		{
+			title: 'fileDirname works',
+			workingDirectory: '${fileDirname}',
+			expectedEnd: 'working-directory-notebook',
+		},
+		{
+			title: 'Paths that do not exist result in the default notebook parent',
+			workingDirectory: '/does/not/exist',
+			expectedEnd: 'working-directory-notebook',
+		},
+		{
+			title: 'Bad variables result in the default notebook parent',
+			workingDirectory: '${asdasd}',
+			expectedEnd: 'working-directory-notebook',
+		},
+	];
 
-	test('workspaceFolder works', async function ({ app, settings }) {
-		await settings.set({
-			'notebook.workingDirectory': '${workspaceFolder}'
-		}, { reload: 'web' });
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, 'qa-example-content');
-	});
+	testCases.forEach(({ title, workingDirectory, expectedEnd }) => {
+		test(title, async function ({ app, settings }) {
+			workingDirectory === null
+				? await settings.clear()
+				: await settings.set({ 'notebook.workingDirectory': workingDirectory }, { reload: 'web' });
 
-	test('fileDirname works', async function ({ app, settings }) {
-		await settings.set({
-			'notebook.workingDirectory': '${fileDirname}'
-		}, { reload: 'web' });
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, 'working-directory-notebook');
+			await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, expectedEnd);
+		});
 	});
 
 	test('A hardcoded path works', async function ({ app, settings }) {
 		// Make a temp dir
 		const tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'notebook-test'));
-
 		await settings.set({
 			'notebook.workingDirectory': tempDir
 		}, { reload: 'web' });
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, path.basename(tempDir));
-	});
-
-	test('Paths that do not exist result in the default notebook parent', async function ({ app, settings }) {
-		await settings.set({
-			'notebook.workingDirectory': '/does/not/exist'
-		}, { reload: 'web' });
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, 'working-directory-notebook');
-	});
 
-	test('Bad variables result in the default notebook parent', async function ({ app, settings }) {
-		await settings.set({
-			'notebook.workingDirectory': '${asdasd}'
-		}, { reload: 'web' });
-		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, 'working-directory-notebook');
+		await verifyWorkingDirectoryEndsWith(app.workbench.notebooks, path.basename(tempDir));
 	});
 });
 
 async function verifyWorkingDirectoryEndsWith(notebooks: Notebooks, expectedEnd: string) {
 	await notebooks.openNotebook('working-directory.ipynb');
 	await notebooks.selectInterpreter('Python');
-	await notebooks.runAllCells();
-	await notebooks.assertCellOutput(new RegExp(`^'.*${expectedEnd}'$`));
+	await expect(async () => {
+		try {
+			await notebooks.runAllCells({ timeout: 10000, throwError: true });
+			await notebooks.assertCellOutput(new RegExp(`^'.*${expectedEnd}'$`));
+		} catch (e) {
+			await notebooks.interruptButton.click({ timeout: 3000 }).catch(() => { });
+			throw e;
+		}
+	}, 'Expect working directory to end with: ' + expectedEnd).toPass({ timeout: 30000 });
 }

test/e2e/tests/reticulate/reticulate-multiple.test.ts

@@ -14,7 +14,7 @@ test.use({
 // RETICULATE_PYTHON
 // to the installed python path
 
-test.describe('Reticulate', {
+test.describe.skip('Reticulate', {
 	tag: [tags.RETICULATE, tags.WEB, tags.ARK, tags.SOFT_FAIL],
 }, () => {
 	test.beforeAll(async function ({ app, settings }) {