Skip to content

Commit 90c5a84

Browse files
committed
Use shiny's ci-install-deps target to build faster
1 parent 19c4e8c commit 90c5a84

File tree

1 file changed

+9
-22
lines changed

1 file changed

+9
-22
lines changed

.github/workflows/shiny.yaml

Lines changed: 9 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,47 +6,34 @@ on:
66
pull_request:
77

88
jobs:
9-
shiny:
9+
htmltools-pr:
1010
runs-on: ubuntu-latest
1111
defaults:
1212
run:
1313
shell: bash
1414

1515
steps:
16-
- name: Set up Python 3.12
17-
uses: actions/setup-python@v5
16+
- uses: actions/checkout@v4
17+
with:
18+
repository: posit-dev/py-shiny
19+
fetch-depth: 0 # Required for shiny version
20+
- name: Setup py-shiny@main
21+
id: install
22+
uses: posit-dev/py-shiny/.github/py-shiny/setup
1823
with:
1924
python-version: "3.12"
2025

2126
- uses: actions/checkout@v4
2227
with:
2328
path: htmltools
24-
- uses: actions/checkout@v4
25-
with:
26-
repository: posit-dev/py-shiny
27-
path: shiny
28-
fetch-depth: 0 # Required for shiny version
29-
30-
- name: Install py-shiny@main
31-
run: |
32-
python -m pip install --upgrade pip
33-
cd shiny
34-
pip install -e ".[dev,test]"
35-
36-
- name: Check py-shiny@main w/ PyPi Htmltools (This should pass)
37-
continue-on-error: true
38-
run: |
39-
cd shiny
40-
make test check
4129

4230
- name: Install dev py-htmltools htmltools dependencies
4331
run: |
4432
cd htmltools
45-
python -m pip install --upgrade pip
4633
pip install -e ".[dev,test]"
4734
make install
4835
4936
- name: Check py-shiny@main w/ dev py-htmltools
5037
run: |
51-
cd shiny
38+
# Run test before check, so that linting is performed last
5239
make test check

0 commit comments

Comments
 (0)