Skip to content

Make TagAttrs a Mapping #70

@schloerke

Description

@schloerke
          I think a better way to go about this is to change `TagAttrs` from a `Dict` to a `Mapping`. (The reason it didn't accept a `TagAttrDict` as a `TagAttrs` object is because `Dict` is invariant, whereas `Mapping` is covariant.)
TagAttrs = Mapping[str, TagAttrValue]

There is also a place where you'll have to test for isinstance(x, Mapping) instead of isinstance(x, dict).

Originally posted by @wch in #55 (comment)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions