Skip to content

Commit 1579f11

Browse files
committed
Set it out of order to prove the filter order is consistent
1 parent 1e598f6 commit 1579f11

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

js/data-frame/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,6 +732,7 @@ const ShinyDataGrid: FC<ShinyDataGridProps<unknown>> = ({
732732
value: filterObj.value as FilterValue,
733733
});
734734
});
735+
shinyFilter.sort((a, b) => a.col - b.col);
735736
window.Shiny.setInputValue!(`${id}_filter`, shinyFilter);
736737

737738
// Deprecated as of 2024-05-21

shiny/www/py-shiny/data-frame/data-frame.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/py-shiny/data-frame/data-frame.js.map

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/playwright/shiny/components/data_frame/filter_reset/test_filter_reset.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ def test_set_filter_accepts_tuple(page: Page, local_app: ShinyAppProc) -> None:
8989

9090
penguin_df.set_filter(
9191
(
92-
{"col": 0, "value": "Adelie"},
9392
{"col": 3, "value": (None, 17)},
93+
{"col": 0, "value": "Adelie"},
9494
) # type: ignore[arg-type]
9595
)
9696

0 commit comments

Comments
 (0)