Skip to content

Commit 1a06708

Browse files
committed
Account for the fact that message.obj might be null
1 parent e820a9d commit 1a06708

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

js/chat/chat.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ type ShinyChatMessage = {
2727
handler: string;
2828
// Message keys will create custom element attributes, but html_deps are handled
2929
// separately
30-
obj: Message & { html_deps?: HtmlDep[] };
30+
obj: (Message & { html_deps?: HtmlDep[] }) | null;
3131
};
3232

3333
type UpdateUserInput = {
@@ -538,14 +538,13 @@ $(function () {
538538
Shiny.addCustomMessageHandler(
539539
"shinyChatMessage",
540540
async function (message: ShinyChatMessage) {
541-
const { html_deps, ...msg } = message.obj;
542541

543-
if (html_deps) {
544-
await renderDependencies(html_deps);
542+
if (message.obj?.html_deps) {
543+
await renderDependencies(message.obj.html_deps);
545544
}
546545

547546
const evt = new CustomEvent(message.handler, {
548-
detail: msg,
547+
detail: message.obj,
549548
});
550549

551550
const el = document.getElementById(message.id);

shiny/www/py-shiny/chat/chat.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/py-shiny/chat/chat.js.map

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)