Un-export render.[DataFrame, DataFrameT, IntoDataFrame, IntoDataFrameT] as they are direct exports from narwhals

Author: schloerke

shiny/render/__init__.py

@@ -15,10 +15,6 @@
 from ._data_frame_utils._selection import CellSelection
 from ._data_frame_utils._types import (  # noqa: F401
     StyleInfo,
-    DataFrame,  # pyright: ignore[reportUnusedImport]
-    DataFrameT,  # pyright: ignore[reportUnusedImport]
-    IntoDataFrame,  # pyright: ignore[reportUnusedImport]
-    IntoDataFrameT,  # pyright: ignore[reportUnusedImport]
 )
 from ._deprecated import (  # noqa: F401
     RenderFunction,  # pyright: ignore[reportUnusedImport]

tests/playwright/shiny/components/data_frame/data_view_info/app.py

@@ -5,6 +5,7 @@
 # pyright: reportArgumentType = false
 # pyright: reportUnknownMemberType = false
 import polars as pl
+from narwhals.typing import IntoDataFrame
 from palmerpenguins import load_penguins_raw
 
 from shiny import App, Inputs, Outputs, Session, module, render, ui
@@ -55,7 +56,7 @@ def mod_server(
     input: Inputs,
     output: Outputs,
     session: Session,
-    dt: render.IntoDataFrame,
+    dt: IntoDataFrame,
 ):
     @render.data_frame
     def penguins_df():

tests/playwright/shiny/components/data_frame/df_methods/app.py

@@ -1,6 +1,7 @@
 import pandas as pd
 import polars as pl
 import seaborn as sns
+from narwhals.typing import IntoDataFrame
 
 from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui
 
@@ -45,7 +46,7 @@ def mod_server(
     input: Inputs,
     output: Outputs,
     session: Session,
-    data: render.IntoDataFrame,
+    data: IntoDataFrame,
 ):
     @render.text
     def df_type():

tests/playwright/shiny/components/data_frame/row_selection/app.py

@@ -2,6 +2,7 @@
 
 import palmerpenguins  # pyright: ignore[reportMissingTypeStubs]
 import polars as pl
+from narwhals.typing import IntoDataFrame
 
 from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui
 
@@ -41,7 +42,7 @@ def make_ui(title: str):
     )
 
 
-def make_server(input: Inputs, data: render.IntoDataFrame):
+def make_server(input: Inputs, data: IntoDataFrame):
     @render.data_frame
     def grid():
         return render.DataGrid(
@@ -93,7 +94,7 @@ def mod_server(
     input: Inputs,
     output: Outputs,
     session: Session,
-    data: render.IntoDataFrame,
+    data: IntoDataFrame,
 ):
     make_server(input, data)
 

tests/playwright/shiny/components/data_frame/styles/app.py

@@ -5,6 +5,7 @@
 # pyright: reportMissingTypeStubs = false
 import palmerpenguins
 import polars as pl
+from narwhals.typing import IntoDataFrame
 
 from shiny import App, Inputs, Outputs, Session, module, render, ui
 
@@ -110,15 +111,15 @@ def mod_server(
     input: Inputs,
     output: Outputs,
     session: Session,
-    data: render.IntoDataFrame,
+    data: IntoDataFrame,
 ):
     @render.data_frame
     def fn_styles():
 
         counter = 0
 
         def df_styles_fn(
-            data: render.IntoDataFrame,
+            data: IntoDataFrame,
         ) -> list[render.StyleInfo]:
             nonlocal counter
 

tests/playwright/shiny/components/data_frame/validate_column_labels/app.py

@@ -4,6 +4,7 @@
 
 import palmerpenguins  # pyright: ignore[reportMissingTypeStubs]
 import polars as pl
+from narwhals.typing import IntoDataFrame
 
 from shiny import Inputs, Outputs, Session
 from shiny.express import module, render, ui
@@ -22,7 +23,7 @@ def df_mod(
     output: Outputs,
     session: Session,
     name: str,
-    data: render.IntoDataFrame,
+    data: IntoDataFrame,
 ):
 
     ui.hr()