Skip to content

Commit 2799518

Browse files
committed
Modernize message sending
1 parent f210d48 commit 2799518

File tree

1 file changed

+18
-19
lines changed

1 file changed

+18
-19
lines changed

shiny/ui/_navs_dynamic.py

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,7 @@ def nav_insert(
8888
"select": select,
8989
}
9090

91-
def callback() -> None:
92-
run_coro_sync(session._send_message({"shiny-insert-tab": msg}))
93-
94-
session.on_flush(callback, once=True)
91+
session._send_message_sync({"custom": {"shiny-insert-tab": msg}})
9592

9693

9794
def nav_remove(id: str, target: str, session: Optional[Session] = None) -> None:
@@ -118,12 +115,12 @@ def nav_remove(id: str, target: str, session: Optional[Session] = None) -> None:
118115

119116
session = require_active_session(session)
120117

121-
msg = {"inputId": resolve_id(id), "target": target}
122-
123-
def callback() -> None:
124-
run_coro_sync(session._send_message({"shiny-remove-tab": msg}))
118+
msg = {
119+
"inputId": resolve_id(id),
120+
"target": target,
121+
}
125122

126-
session.on_flush(callback, once=True)
123+
session._send_message_sync({"custom": {"shiny-remove-tab": msg}})
127124

128125

129126
def nav_show(
@@ -163,12 +160,13 @@ def nav_show(
163160
if select:
164161
update_navs(id, selected=target)
165162

166-
msg = {"inputId": id, "target": target, "type": "show"}
167-
168-
def callback() -> None:
169-
run_coro_sync(session._send_message({"shiny-change-tab-visibility": msg}))
163+
msg = {
164+
"inputId": id,
165+
"target": target,
166+
"type": "show",
167+
}
170168

171-
session.on_flush(callback, once=True)
169+
session._send_message_sync({"custom": {"shiny-change-tab-visibility": msg}})
172170

173171

174172
def nav_hide(id: str, target: str, session: Optional[Session] = None) -> None:
@@ -195,9 +193,10 @@ def nav_hide(id: str, target: str, session: Optional[Session] = None) -> None:
195193

196194
session = require_active_session(session)
197195

198-
msg = {"inputId": resolve_id(id), "target": target, "type": "hide"}
199-
200-
def callback() -> None:
201-
run_coro_sync(session._send_message({"shiny-change-tab-visibility": msg}))
196+
msg = {
197+
"inputId": resolve_id(id),
198+
"target": target,
199+
"type": "hide",
200+
}
202201

203-
session.on_flush(callback, once=True)
202+
session._send_message_sync({"custom": {"shiny-change-tab-visibility": msg}})

0 commit comments

Comments
 (0)