Merge branch 'main' into fix-issue-2013

Author: karangattu

tests/playwright/ai_generated_apps/bookmark/accordion/test_accordion_bookmarking.py

@@ -19,10 +19,13 @@ def test_accordion_bookmarking_demo(page: Page, app: ShinyAppProc) -> None:
     acc_mod.expect_open(["Section A"])
     acc_mod.set(["Section C"])
 
+    existing_url = page.url
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
 
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
+
     # reload page
     page.reload()
 
@@ -32,8 +35,12 @@ def test_accordion_bookmarking_demo(page: Page, app: ShinyAppProc) -> None:
     acc_single.set([])
     acc_mod.set([])
 
+    existing_url = page.url
+
     bookmark_button.click()
 
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
+
     # reload page
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/input_checkbox/test_input_checkbox_express_bookmarking.py

@@ -33,9 +33,12 @@ def test_checkbox_demo(page: Page, app: ShinyAppProc) -> None:
     module_checkbox.expect_checked(True)
     module_text.expect_value("Checkbox value: True")
 
+    existing_url = page.url
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
 
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
+
     # reload the page to test bookmark
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/input_checkbox_group/test_input_checkbox_group_express_bookmarking.py

@@ -35,9 +35,11 @@ def test_checkbox_group_demo(page: Page, app: ShinyAppProc) -> None:
     module_group.expect_selected(["Choice A", "Choice C"])
     module_text.expect_value("Checkbox group values: ('Choice A', 'Choice C')")
 
+    existing_url = page.url
     # Bookmark the state
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
 
     # Reload the page to test bookmark
     page.reload()

tests/playwright/ai_generated_apps/bookmark/input_file/test_input_file_express_bookmarking.py

@@ -44,9 +44,12 @@ def test_file_input_bookmarking(page: Page, app: ShinyAppProc) -> None:
 
     mod_file_output_txt.expect_value("File name(s): users.csv, users2.csv")
 
+    existing_url = page.url
+
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
     bookmark_button.click()
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
 
     page.reload()
 

tests/playwright/ai_generated_apps/bookmark/input_password/test_input_password_express_bookmarking.py

@@ -46,8 +46,11 @@ def test_text_input_demo(page: Page, app: ShinyAppProc) -> None:
 
     # click bookmark button
     bookmark_button = controller.InputBookmarkButton(page)
+    existing_url = page.url
     bookmark_button.click()
 
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
+
     page.reload()
 
     # Check if the values are retained after reloading the page

tests/playwright/ai_generated_apps/bookmark/navsets/test_navsets_express_bookmarking.py

@@ -44,9 +44,11 @@ def test_navsets_bookmarking_demo(
     mod_navset_cont = navset_controller(page, f"first-{navset_name}_{navset_variant}")
     mod_navset_cont.set(f"{navset_name}_b")
 
+    existing_url = page.url
+
     # Click bookmark button
     controller.InputBookmarkButton(page).click()
-
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
     # Reload page
     page.reload()
 
@@ -55,3 +57,4 @@ def test_navsets_bookmarking_demo(
     navset_cont.expect_value(f"{navset_name}_c")
     mod_navset_collection.expect_value(navset_name)
     mod_navset_cont.expect_value(f"{navset_name}_b")
+    mod_navset_cont.expect_value(f"{navset_name}_b")

tests/playwright/ai_generated_apps/bookmark/navsets/test_navsets_hidden_bookmarking.py

@@ -41,8 +41,11 @@ def test_navset_hidden_bookmarking(
     mod_navset_btn = controller.InputActionButton(page, f"first-{navset_id}_button")
     mod_navset_btn.click()
 
+    existing_url = page.url
+
     # Click bookmark button
     controller.InputBookmarkButton(page).click()
+    page.wait_for_url(lambda url: url != existing_url, timeout=5 * 1000)
 
     # Reload page
     page.reload()

tests/playwright/examples/example_apps.py

@@ -89,7 +89,8 @@ def get_apps(path: str) -> typing.List[str]:
     "FutureWarning: The default of observed=False is deprecated",
     # seaborn: https://github.com/mwaskom/seaborn/pull/3355
     "FutureWarning: use_inf_as_na option is deprecated",
-    "pd.option_context('mode.use_inf_as_na",  # continutation of line above
+    "pd.option_context('mode.use_inf_as_na",  # continutation of line above,
+    "RuntimeWarning: invalid value encountered in dot",  # some groups didn't have enough data points to create a meaningful line
 ]
 app_allow_js_errors: typing.Dict[str, typing.List[str]] = {
     "examples/brownian": ["Failed to acquire camera feed:"],

tests/playwright/shiny/bookmark/chat/chatlas/app.py

@@ -24,9 +24,9 @@
 # Use ChatOpenAI as it does not need credentials until submission to the server.
 # However, if we use `.set_turns()` and `.get_turns()`, a submission is never made to the server... therefore we don't need credentials.
 chat_client = chatlas.ChatOpenAI(  # pyright: ignore[reportUnknownMemberType]
-    turns=[],
     api_key="<not_utilized>",
 )
+chat_client.set_turns([])  # type: ignore[arg-type]
 chat.enable_bookmarking(chat_client, bookmark_store="url")