Skip to content

Commit 40a2f62

Browse files
committed
typing updates
1 parent d3bf198 commit 40a2f62

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

shiny/render/_data_frame_utils/_tbl_data.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,11 @@ def serialize_dtype(col: nw.Series) -> FrameDtype:
202202
type_ = "datetime"
203203
elif isinstance(dtype, nw.Duration):
204204
type_ = "duration"
205-
elif hasattr(nw, "Time") and isinstance(dtype, nw.Time):
205+
elif hasattr(nw, "Time") and isinstance(
206+
dtype,
207+
# https://github.com/narwhals-dev/narwhals/pull/2113
208+
nw.Time, # pyright: ignore[reportUnknownMemberType,reportAttributeAccessIssue]
209+
):
206210
type_ = "time"
207211
elif isinstance(dtype, nw.Object):
208212
type_ = "object"

shiny/render/_data_frame_utils/_types.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ class FrameDtypeSubset(TypedDict):
179179
"boolean",
180180
"date",
181181
"datetime",
182+
"time",
182183
"duration",
183184
"object",
184185
"unknown",

0 commit comments

Comments
 (0)