Merge branch 'main' into feat/current_output_id

Author: cpsievert

.github/py-shiny/setup/action.yaml

@@ -4,7 +4,7 @@ inputs:
   python-version:
     description: 'Python version to use'
     required: false
-    default: "3.12"
+    default: "3.13"
 runs:
   using: "composite"
   steps:
@@ -39,12 +39,6 @@ runs:
         run: |
           make ci-install-wheel
 
-      - name: Install backports.tarfile
-        if: ${{ startsWith(inputs.python-version, '3.8') }}
-        shell: bash
-        run: |
-          uv pip install backports.tarfile
-
       - name: Pip list
         shell: bash
         run: |

.github/workflows/build-docs.yaml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.12"]
+        python-version: ["3.13"]
       fail-fast: false
 
     steps:

.github/workflows/pytest.yaml

@@ -17,9 +17,10 @@ jobs:
     strategy:
       matrix:
         # "3.10" must be a string; otherwise it is interpreted as 3.1.
-        python-version: ["3.12", "3.11", "3.10", "3.9"]
+        python-version: ["3.13", "3.12", "3.11", "3.10", "3.9"]
         os: [ubuntu-latest, windows-latest, macOS-latest]
         exclude:
+          - python-version: ${{ github.event.pull_request.draft && '3.12' }}
           - python-version: ${{ github.event.pull_request.draft && '3.11' }}
           - python-version: ${{ github.event.pull_request.draft && '3.10' }}
           - python-version: ${{ github.event.pull_request.draft && '3.9' }}
@@ -73,7 +74,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: "Set up Python 3.10"
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: "3.10"
       - name: Install dependencies
@@ -107,18 +108,17 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.12", "3.11", "3.10", "3.9"]
+        python-version: ["3.13", "3.12", "3.11", "3.10", "3.9"]
         browser: ["chromium", "firefox", "webkit"]
         exclude:
+          - python-version: ${{ github.event.pull_request.draft && '3.12' }}
           - python-version: ${{ github.event.pull_request.draft && '3.11' }}
           - python-version: ${{ github.event.pull_request.draft && '3.10' }}
           - python-version: ${{ github.event.pull_request.draft && '3.9' }}
           - browser: ${{ github.event.pull_request.draft && 'firefox' }}
           - browser: ${{ github.event.pull_request.draft && 'webkit' }}
           # There are many unexplained tests that fail on webkit w/ python 3.8, 3.9
           # Given the more recent versions of python work, we will exclude this combination
-          - browser: "webkit"
-            python-version: "3.8"
           - browser: "webkit"
             python-version: "3.9"
       fail-fast: false
@@ -157,9 +157,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.12", "3.11", "3.10", "3.9"]
+        python-version: ["3.13", "3.12", "3.11", "3.10", "3.9"]
         browser: ["chromium", "firefox", "webkit"]
         exclude:
+          - python-version: ${{ github.event.pull_request.draft && '3.12' }}
           - python-version: ${{ github.event.pull_request.draft && '3.11' }}
           - python-version: ${{ github.event.pull_request.draft && '3.10' }}
           - python-version: ${{ github.event.pull_request.draft && '3.9' }}
@@ -193,6 +194,17 @@ jobs:
         working-directory: examples/brownian/shinymediapipe
         run: |
           npm ci
+      - name: Checkout py-shiny-templates repository
+        uses: actions/checkout@v4
+        with:
+          repository: posit-dev/py-shiny-templates
+          path: py-shiny-templates
+
+      - name: Install py-shiny-templates dependencies
+        if: matrix.python-version != '3.9'
+        # Scikit-learn 1.7.0+ requires Python 3.10+
+        run: |
+          make ci-install-py-shiny-templates-deps
 
       - name: Run example app tests
         timeout-minutes: 60
@@ -210,9 +222,10 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: ["3.12", "3.11", "3.10", "3.9"]
+        python-version: ["3.13", "3.12", "3.11", "3.10", "3.9"]
         browser: ["chromium", "firefox", "webkit"]
         exclude:
+          - python-version: ${{ github.event.pull_request.draft && '3.12' }}
           - python-version: ${{ github.event.pull_request.draft && '3.11' }}
           - python-version: ${{ github.event.pull_request.draft && '3.10' }}
           - python-version: ${{ github.event.pull_request.draft && '3.9' }}

CHANGELOG.md

@@ -9,20 +9,34 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### New features
 
-* The `.output_*()` methods of the `ClientData` class (e.g., `session.clientdata.output_height()`) can now be called without an `id` inside a output renderer. (#1978)
+* Added support for python 3.13. (#1711)
+
+* `ui.sidebar()` is now interactively resizable. (#2020)
+
+* `ui.update_*()` functions now accept `ui.TagChild` (i.e., HTML) as input to the `label` and `icon` arguments. (#2020)
+
+* The `.output_*()` methods of the `ClientData` class (e.g., `session.clientdata.output_height()`) can now be called without an `id` when called inside a `@render` function. (#1978)
+
+* `playwright.controller.InputActionButton` gains a `expect_icon()` method. As a result, the already existing `expect_label()` no longer includes the icon. (#2020)
 
 ### Improvements
 
+* Improved the styling and readability of markdown tables rendered by `ui.Chat()` and `ui.MarkdownStream()`. (#1973)
+
 * `selectize`, `remove_button`, and `options` parameters of `ui.input_select()` have been deprecated; use `ui.input_selectize()` instead. (Thanks, @ErdaradunGaztea!) (#1947)
 
-* Improved the styling and readability of markdown tables rendered by `ui.Chat()` and `ui.MarkdownStream()`. (#1973)
+* Added `timeout_secs` parameter to `create_app_fixture` to allow testing apps with longer startup times. (#2033)
 
 ### Bug fixes
 
+* Fixed an issue with `ui.Chat()` sometimes wanting to scroll a parent element. (#1996)
+
 * Explicitly call out module usage in UI input bookmark button documentation. (#1983)
 
 * Fix missing session when trying to display an error duing bookmarking. (#1984)
 
+* Fixed `set()` method of `InputSelectize` controller so it clears existing selections before applying new values. (#2024)
+
 
 ## [1.4.0] - 2025-04-08
 
@@ -50,6 +64,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Bug fixes
 
+* Fixed issue where apps run in Workbench were unexpectedly crashing. Apps running in Workbench will now have `ws_per_message_deflate=False` enforced. (#2005)
+
 * Fixed an issue where the `<main>` areas of `ui.page_sidebar()` and `ui.page_navbar()` (with a `sidebar`) were made to be a fillable containers even when `fillable=False`. (#1816)
 
 * Fixed an issue where the `.update_user_input()` method on `ui.Chat()` isn't working in shinylive.  (#1891)

Makefile

@@ -56,9 +56,6 @@ clean-test: FORCE
 	rm -fr .pytest_cache
 	rm -rf typings/
 
-typings/appdirs:
-	@echo "Creating appdirs stubs"
-	pyright --createstub appdirs
 typings/folium:
 	@echo "Creating folium stubs"
 	pyright --createstub folium
@@ -75,7 +72,7 @@ typings/matplotlib/__init__.pyi:
 	mv typings/python-type-stubs/stubs/matplotlib typings/
 	rm -rf typings/python-type-stubs
 
-pyright-typings: typings/appdirs typings/folium typings/uvicorn typings/seaborn typings/matplotlib/__init__.pyi
+pyright-typings: typings/folium typings/uvicorn typings/seaborn typings/matplotlib/__init__.pyi
 
 check: check-format check-lint check-types check-tests  ## check code, style, types, and test (basic CI)
 check-fix: format check-lint check-types check-tests ## check and format code, style, types, and test
@@ -223,6 +220,8 @@ install-deps: FORCE ## install dependencies
 	pip install -e ".[dev,test]" --upgrade
 ci-install-deps: FORCE
 	uv pip install -e ".[dev,test]"
+ci-install-py-shiny-templates-deps: FORCE
+	uv pip install -r py-shiny-templates/requirements.txt
 
 install-docs: FORCE
 	pip install -e ".[dev,test,doc]"

docs/_quartodoc-testing.yml

@@ -26,6 +26,7 @@ quartodoc:
       contents:
         - playwright.controller.InputActionButton
         - playwright.controller.InputActionLink
+        - playwright.controller.InputBookmarkButton
         - playwright.controller.InputCheckbox
         - playwright.controller.InputCheckboxGroup
         - playwright.controller.InputDarkMode
@@ -59,6 +60,7 @@ quartodoc:
         - playwright.controller.NavsetTab
         - playwright.controller.NavsetUnderline
         - playwright.controller.NavPanel
+        - playwright.controller.PageNavbar
     - title: Upload and download
       desc: Methods for interacting with Shiny app uploading and downloading controller.
       contents:

js/chat/chat.ts

@@ -131,8 +131,6 @@ interface ChatInputSetInputOptions {
 }
 
 class ChatInput extends LightElement {
-  private _disabled = false;
-
   @property() placeholder = "Enter a message...";
   // disabled is reflected manually because `reflect: true` doesn't work with LightElement
   @property({ type: Boolean })
@@ -155,6 +153,27 @@ class ChatInput extends LightElement {
     this.#onInput();
   }
 
+  private _disabled = false;
+  inputVisibleObserver?: IntersectionObserver;
+
+  connectedCallback(): void {
+    super.connectedCallback();
+
+    this.inputVisibleObserver = new IntersectionObserver((entries) => {
+      entries.forEach((entry) => {
+        if (entry.isIntersecting) this.#updateHeight();
+      });
+    });
+
+    this.inputVisibleObserver.observe(this);
+  }
+
+  disconnectedCallback(): void {
+    super.disconnectedCallback();
+    this.inputVisibleObserver?.disconnect();
+    this.inputVisibleObserver = undefined;
+  }
+
   attributeChangedCallback(
     name: string,
     _old: string | null,
@@ -189,7 +208,7 @@ class ChatInput extends LightElement {
     return html`
       <textarea
         id="${this.id}"
-        class="form-control textarea-autoresize"
+        class="form-control"
         rows="1"
         placeholder="${this.placeholder}"
         @keydown=${this.#onKeyDown}
@@ -217,6 +236,7 @@ class ChatInput extends LightElement {
   }
 
   #onInput(): void {
+    this.#updateHeight();
     this.button.disabled = this.disabled
       ? true
       : this.value.trim().length === 0;
@@ -247,6 +267,15 @@ class ChatInput extends LightElement {
     if (focus) this.textarea.focus();
   }
 
+  #updateHeight(): void {
+    const el = this.textarea;
+    if (el.scrollHeight == 0) {
+      return;
+    }
+    el.style.height = "auto";
+    el.style.height = `${el.scrollHeight}px`;
+  }
+
   setInputValue(
     value: string,
     { submit = false, focus = false }: ChatInputSetInputOptions = {}
@@ -528,11 +557,19 @@ class ChatContainer extends LightElement {
 
 // ------- Register custom elements and shiny bindings ---------
 
-customElements.define(CHAT_MESSAGE_TAG, ChatMessage);
-customElements.define(CHAT_USER_MESSAGE_TAG, ChatUserMessage);
-customElements.define(CHAT_MESSAGES_TAG, ChatMessages);
-customElements.define(CHAT_INPUT_TAG, ChatInput);
-customElements.define(CHAT_CONTAINER_TAG, ChatContainer);
+const chatCustomElements = [
+  { tag: CHAT_MESSAGE_TAG, component: ChatMessage },
+  { tag: CHAT_USER_MESSAGE_TAG, component: ChatUserMessage },
+  { tag: CHAT_MESSAGES_TAG, component: ChatMessages },
+  { tag: CHAT_INPUT_TAG, component: ChatInput },
+  { tag: CHAT_CONTAINER_TAG, component: ChatContainer }
+];
+
+chatCustomElements.forEach(({ tag, component }) => {
+  if (!customElements.get(tag)) {
+    customElements.define(tag, component);
+  }
+});
 
 window.Shiny.addCustomMessageHandler(
   "shinyChatMessage",
@@ -561,3 +598,5 @@ window.Shiny.addCustomMessageHandler(
     el.dispatchEvent(evt);
   }
 );
+
+export { CHAT_CONTAINER_TAG };

js/markdown-stream/markdown-stream.ts

@@ -6,6 +6,8 @@ import ClipboardJS from "clipboard";
 import hljs from "highlight.js/lib/common";
 import { Renderer, parse } from "marked";
 
+import { CHAT_CONTAINER_TAG } from "../chat/chat";
+
 import {
   LightElement,
   createElement,
@@ -282,6 +284,12 @@ class MarkdownElement extends LightElement {
     while (el) {
       if (el.scrollHeight > el.clientHeight) return el;
       el = el.parentElement;
+      if (el?.tagName?.toLowerCase() === CHAT_CONTAINER_TAG.toLowerCase()) {
+        // This ensures that we do not accidentally scroll a parent element of the chat
+        // container. If the chat container itself is scrollable, a scrollable element
+        // would already have been identified.
+        break;
+      }
     }
     return null;
   }

pyproject.toml

@@ -26,6 +26,7 @@ classifiers = [
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
 ]
 dependencies = [
     "typing-extensions>=4.10.0",
@@ -37,7 +38,7 @@ dependencies = [
     "markdown-it-py>=1.1.0",
     "mdit-py-plugins>=0.3.0",
     "linkify-it-py>=1.0",
-    "appdirs>=1.4.4",
+    "platformdirs>=2.1.0",
     "asgiref>=3.5.2",
     "packaging>=20.9",
     "watchfiles>=0.18.0;platform_system!='Emscripten'",
@@ -54,8 +55,8 @@ theme = ["libsass>=0.23.0", "brand_yml>=0.1.0"]
 test = [
     "pytest>=6.2.4",
     "pytest-asyncio>=0.17.2",
-    "pytest-playwright>=0.3.0",
-    "playwright>=1.43.0",
+    "pytest-playwright>=0.5.2",
+    "playwright>=1.48.0",
     "pytest-xdist",
     "pytest-timeout",
     "pytest-rerunfailures",
@@ -86,7 +87,6 @@ test = [
     "faicons",
     "ridgeplot",
     "great_tables",
-    "modin[all]",
     "polars",
     "dask[dataframe]",
     "pyarrow",
@@ -113,11 +113,7 @@ dev = [
     "anthropic",
     "google-generativeai;python_version>='3.9'",
     "langchain_core",
-    # langsmith (needed for langchain_core) versions >= 0.3
-    # (up to at least 0.3.2 as of 2025-01-29)
-    # cause an `argparse.ArgumentError` when running `pytest`.
-    # https://github.com/posit-dev/py-shiny/issues/1829
-    "langsmith<0.3",
+    "langsmith>=0.3.4",
     "openai",
     "ollama",
     "chatlas>=0.6.1",

shiny/_datastructures.py

@@ -15,8 +15,6 @@ class PriorityQueueFIFO(Generic[T]):
     """
 
     def __init__(self) -> None:
-        # Using Tuple instead of tuple because in Python 3.8 and earlier, tuple isn't
-        # generic
         self._pq: PriorityQueue[tuple[int, int, T]] = PriorityQueue()
         self._counter: int = 0