Skip to content

Commit 47b3ff2

Browse files
committed
Update changelog and tests for OutputDataFrame filter changes
Added changelog entries for OutputDataFrame improvements and bug fixes.
1 parent cecf011 commit 47b3ff2

File tree

3 files changed

+9
-28
lines changed

3 files changed

+9
-28
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Improvements
1111

1212
* Playwright's `OutputDataFrame.set_filter()` controller now supports multi-column filters (#2093)
13+
* Add api-example for `ui.output_code` (#2093)
14+
* Update controllers for `DownloadLink` and `DownloadButton` (#2093)
15+
16+
### Bug fixes
17+
18+
* `ui.output_data_frame` will now consistently order the filtered columns in ascending column order. (#2093)
19+
* When resetting a `ui.output_data_frame` filter, numeric range filters will now reset both values. (#2093)
1320

1421
## [1.5.0] - 2025-09-11
1522

shiny/playwright/controller/_output.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import annotations
22

33
import platform
4-
from typing import Any, Literal, Protocol, Sequence, Union, cast
4+
from typing import Any, Literal, Protocol, Sequence, cast
55

66
from playwright.sync_api import Locator, Page
77
from playwright.sync_api import expect as playwright_expect

tests/playwright/shiny/components/data_frame/filter_reset/test_filter_reset.py

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def test_set_filter_accepts_tuple(page: Page, local_app: ShinyAppProc) -> None:
9191
(
9292
{"col": 3, "value": (None, 17)},
9393
{"col": 0, "value": "Adelie"},
94-
) # type: ignore[arg-type]
94+
)
9595
)
9696

9797
penguin_code.expect_value(
@@ -106,32 +106,6 @@ def test_set_filter_accepts_tuple(page: Page, local_app: ShinyAppProc) -> None:
106106
expect(depth_filter.nth(1)).to_have_value("17")
107107

108108

109-
def test_set_filter_accepts_multi_column_mapping(
110-
page: Page, local_app: ShinyAppProc
111-
) -> None:
112-
page.goto(local_app.url)
113-
114-
penguin_df = controller.OutputDataFrame(page, "penguins_df")
115-
penguin_code = controller.OutputCode(page, "penguins_code")
116-
117-
penguin_df.set_filter(
118-
{
119-
"col": [0, 1],
120-
"value": ["Gentoo", "Biscoe"],
121-
} # type: ignore[arg-type]
122-
)
123-
124-
penguin_code.expect_value(
125-
"({'col': 0, 'value': 'Gentoo'}, {'col': 1, 'value': 'Biscoe'})"
126-
)
127-
128-
species_filter = penguin_df.loc_column_filter.nth(0).locator("input")
129-
island_filter = penguin_df.loc_column_filter.nth(1).locator("input")
130-
131-
expect(species_filter).to_have_value("Gentoo")
132-
expect(island_filter).to_have_value("Biscoe")
133-
134-
135109
def test_set_filter_none_clears_inputs(page: Page, local_app: ShinyAppProc) -> None:
136110
page.goto(local_app.url)
137111

0 commit comments

Comments
 (0)