feat(brand): restore card borders in dark mode if brand makes dark mode

gadenbuie · gadenbuie · commit 484c89b98cf3 · 2024-10-24T10:42:00.000-04:00
diff --git a/shiny/ui/_theme_brand.py b/shiny/ui/_theme_brand.py
@@ -382,6 +382,14 @@ def __init__(
               font-weight: $code-block-font-weight;
               font-size: $code-block-font-size;
             }
+
+            @if variable-exists(brand--background) {
+              // When brand makes dark mode, it usually hides card definition, so we add
+              // back card borders in dark mode.
+              [data-bs-theme="dark"] {
+                --bslib-card-border-color: RGBA(255, 255, 255, 0.15);
+              }
+            }
             """
         )
 

Original file line number	Diff line number	Diff line change
`@@ -382,6 +382,14 @@ def __init__(`
`382`	`382`	`font-weight: $code-block-font-weight;`
`383`	`383`	`font-size: $code-block-font-size;`
`384`	`384`	`}`
	`385`	`+`
	`386`	`+ @if variable-exists(brand--background) {`
	`387`	`+ // When brand makes dark mode, it usually hides card definition, so we add`
	`388`	`+ // back card borders in dark mode.`
	`389`	`+ [data-bs-theme="dark"] {`
	`390`	`+ --bslib-card-border-color: RGBA(255, 255, 255, 0.15);`
	`391`	`+ }`
	`392`	`+ }`
`385`	`393`	`"""`
`386`	`394`	`)`
`387`	`395`