Skip to content

Commit 4e186ac

Browse files
committed
Simplify loglevel setting
No need to pass through to the background thread, we can just change the loglevel on the main thread.
1 parent 5d6c449 commit 4e186ac

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

shiny/_autoreload.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ def start_server(port: int, app_port: int, launch_browser: bool):
179179
# we think we have a problem. You can unsuppress by setting the environment variable
180180
# to DEBUG.
181181
loglevel = os.getenv("SHINY_AUTORELOAD_LOG_LEVEL", "CRITICAL")
182+
logging.getLogger("websockets").setLevel(loglevel)
182183

183184
app_url = get_proxy_url(f"http://127.0.0.1:{app_port}/")
184185

@@ -187,19 +188,17 @@ def start_server(port: int, app_port: int, launch_browser: bool):
187188
threading.Thread(
188189
None,
189190
_thread_main,
190-
args=[port, app_url, secret, launch_browser, loglevel],
191+
args=[port, app_url, secret, launch_browser],
191192
daemon=True,
192193
).start()
193194

194195

195-
def _thread_main(
196-
port: int, app_url: str, secret: str, launch_browser: bool, loglevel: str
197-
):
198-
asyncio.run(_coro_main(port, app_url, secret, launch_browser, loglevel))
196+
def _thread_main(port: int, app_url: str, secret: str, launch_browser: bool):
197+
asyncio.run(_coro_main(port, app_url, secret, launch_browser))
199198

200199

201200
async def _coro_main(
202-
port: int, app_url: str, secret: str, launch_browser: bool, loglevel: str
201+
port: int, app_url: str, secret: str, launch_browser: bool
203202
) -> None:
204203
import websockets
205204
import websockets.asyncio.server
@@ -260,9 +259,6 @@ async def process_request(
260259
else:
261260
return None
262261

263-
# logging.getLogger("websockets").addHandler(logging.NullHandler())
264-
logging.getLogger("websockets").setLevel(loglevel)
265-
266262
async with websockets.asyncio.server.serve(
267263
reload_server, "127.0.0.1", port, process_request=process_request
268264
):

0 commit comments

Comments
 (0)