Updating express test

Author: elnelson575

shiny/api-examples/insert_nav_panel/app-core.py

@@ -5,6 +5,7 @@
         ui.input_action_button("add", "Add 'Dynamic' tab"),
         ui.input_action_button("removeFoo", "Remove 'Foo' tabs"),
         ui.input_action_button("addFoo", "Add New 'Foo' tab"),
+        ui.input_action_button("addTextPanel", "Add Text Panel"),
     ),
     ui.navset_tab(
         ui.nav_panel("Hello", "This is the hello tab"),
@@ -32,6 +33,17 @@ def _():
             position="before",
         )
 
+    @reactive.effect()
+    @reactive.event(input.addTextPanel)
+    def _():
+        id = "Text-" + str(input.addTextPanel())
+        ui.insert_nav_panel(
+            "tabs",
+            id,
+            target="s2",
+            position="before",
+        )
+
     @reactive.effect()
     @reactive.event(input.removeFoo)
     def _():
@@ -49,5 +61,17 @@ def _():
             select=True,
         )
 
+    @reactive.effect()
+    @reactive.event(input.addTextPanel)
+    def _():
+        n = str(input.addFoo())
+        ui.insert_nav_panel(
+            "tabs",
+            "Placeholder Text Panel",
+            target="Menu",
+            position="before",
+            select=True,
+        )
+
 
 app = App(app_ui, server)

shiny/api-examples/insert_nav_panel/app-express.py

@@ -5,6 +5,8 @@
     ui.input_action_button("add", "Add 'Dynamic' tab")
     ui.input_action_button("removeFoo", "Remove 'Foo' tabs")
     ui.input_action_button("addFoo", "Add New 'Foo' tab")
+    ui.input_action_button("addTextPanel", "Add Text Panel"),
+
 
 with ui.navset_tab(id="tabs"):
     with ui.nav_panel("Hello", value="Hello"):
@@ -31,6 +33,13 @@ def _():
     ui.remove_nav_panel("tabs", target="Foo")
 
 
+@reactive.effect()
+@reactive.event(input.add)
+def _():
+    id = "Dynamic-" + str(input.add())
+    ui.insert_nav_panel("tabs", title=id, value=id, target="s2", position="before")
+
+
 @reactive.effect()
 @reactive.event(input.addFoo)
 def _():

tests/playwright/shiny/components/express_navs/app.py

@@ -1,29 +1,39 @@
 from shiny import reactive
-from shiny.express import render
-from .modules import custom_sidebar, add_to_counter_content
-
-tabs_added = reactive.value(0)
-
-
-def increment_tabs_counter():
-    tabs_added.set(tabs_added() + 1)
-
-
-custom_sidebar(
-    "nav",
-    _on_click=increment_tabs_counter,
-    label="Dynamic Sidebar",
-)
-
-
-add_to_counter_content(
-    "buttonAdder",
-    _on_click=increment_tabs_counter,
-    starting_value=0,
-    label="Add to Counter",
-)
-
-
-@render.code
-def out():
-    return f"Tabs added: {tabs_added()}"
+from shiny.express import ui, module
+
+
+@module
+def my_nav(input, output, session):
+    with ui.navset_card_tab(id="navset"):
+        with ui.nav_panel("Panel 1"):
+            "This is the first panel"
+            ui.input_action_button("hideTab", "Hide panel 2")
+            ui.input_action_button("showTab", "Show panel 2")
+            ui.input_action_button("deleteTabs", "Delete panel 2")
+
+    @reactive.effect
+    def _():
+        ui.insert_nav_panel(
+            "navset",
+            "Panel 2",
+            "This is the second panel",
+        )
+
+        @reactive.effect()
+        @reactive.event(input.showTab)
+        def _():
+            ui.show_nav_panel("navset", target="Panel 2")
+
+        @reactive.effect()
+        @reactive.event(input.hideTab)
+        def _():
+            ui.hide_nav_panel("navset", target="Panel 2")
+
+        @reactive.effect()
+        @reactive.event(input.deleteTabs)
+        def _():
+            ui.remove_nav_panel("navset", "Panel 2")
+
+
+my_nav("foo")
+my_nav("bar")

tests/playwright/shiny/components/express_navs/modules.py

@@ -0,0 +1,42 @@
+import pytest
+from playwright.sync_api import Page, expect
+
+from shiny.playwright import controller
+from shiny.run import ShinyAppProc
+
+
+@pytest.mark.flaky(reruns=3, reruns_delay=2)
+def test_dynamic_navs(page: Page, local_app: ShinyAppProc) -> None:
+    page.goto(local_app.url)
+
+    # Page begins with 2 tabs: "Hello" and "Foo" and a nav menu with 2 static items.
+    controller.NavsetTab(page, "foo-navset").expect_nav_titles(["Panel 1", "Panel 2"])
+    controller.NavsetTab(page, "bar-navset").expect_nav_titles(["Panel 1", "Panel 2"])
+
+    # Click hide-tab to hide the Foo tabs
+    hidetab = controller.InputActionButton(page, "foo-hideTab")
+    hidetab.click()
+
+    # Expect the Foo tabs to be hidden
+    navpanel = controller.NavPanel(page, "foo-navset", "Panel 2").loc
+    expect(navpanel).to_be_hidden()
+
+    # Expect the bar tabs to not be affected
+    navpanel2 = controller.NavPanel(page, "bar-navset", "Panel 2").loc
+    expect(navpanel2).to_be_visible()
+
+    # Click show-tab to show the Foo tabs again
+    showtab = controller.InputActionButton(page, "foo-showTab")
+    showtab.click()
+
+    # Expect the Foo tabs to be visible again
+    navpanel2 = controller.NavPanel(page, "foo-navset", "Panel 2").loc
+    expect(navpanel2).to_be_visible()
+    navpanel3 = controller.NavPanel(page, "bar-navset", "Panel 2").loc
+    expect(navpanel3).to_be_visible()
+
+    # Click the remove button to remove the panel 2 in bar
+    removeTab = controller.InputActionButton(page, "bar-deleteTabs")
+    removeTab.click()
+    controller.NavsetTab(page, "bar-navset").expect_nav_titles(["Panel 1"])
+    controller.NavsetTab(page, "foo-navset").expect_nav_titles(["Panel 1", "Panel 2"])