Add mod and non-mod tests for input components

Author: karangattu

shiny/playwright/controller/_base.py

@@ -120,6 +120,7 @@ def set_text(
     # TODO-future; Composable set() method
     loc.fill("", timeout=timeout)  # Reset the value
     loc.type(text, delay=delay, timeout=timeout)  # Type the value
+    loc.press("Enter", timeout=timeout)
 
 
 def _expect_multiple(loc: Locator, multiple: bool, timeout: Timeout = None) -> None:

shiny/playwright/controller/_input_buttons.py

@@ -47,7 +47,7 @@ def __init__(
         super().__init__(
             page,
             id=id,
-            loc=f"button#{id}.action-button.shiny-bound-input",
+            loc=f'button[id="{id}"].action-button.shiny-bound-input',
         )
 
     def expect_disabled(self, value: bool, *, timeout: Timeout = None):
@@ -75,7 +75,7 @@ class InputBookmarkButton(
     def __init__(
         self,
         page: Page,
-        id: str,
+        id: str = "`._bookmark_`",
     ) -> None:
         """
         Initializes the input bookmark button.
@@ -85,7 +85,7 @@ def __init__(
         page
             The page where the input bookmark button is located.
         id
-            The id of the input bookmark button.
+            The id of the input bookmark button. Defaults to "._bookmark_".
         """
         super().__init__(
             page,

tests/playwright/ai_generated_apps/bookmark_tests/bookmark_exclusion/app-core.py

@@ -0,0 +1,49 @@
+from starlette.requests import Request
+
+from shiny import App, Inputs, Outputs, Session, module, ui
+from shiny.bookmark import BookmarkState, RestoreState
+
+
+@module.ui
+def mod_ui(label: str):
+    return ui.div(
+        ui.input_text("text", f"{label} Text", "Initial Module Text"),
+        ui.input_numeric("num", f"{label} Numeric", 1),
+        ui.input_text("excluded", f"{label} Excluded", "Module Excluded"),
+    )
+
+
+@module.server
+def mod_server(input: Inputs, output: Outputs, session: Session):
+    session.bookmark.exclude.append("excluded")
+
+    @session.bookmark.on_bookmark
+    async def _(state: BookmarkState):
+        state.values["module_num"] = input.num()
+
+    @session.bookmark.on_restore
+    def _(state: RestoreState):
+        if "module_num" in state.values:
+            ui.update_numeric("num", value=state.values["module_num"])
+        if "text" in state.input:
+            print(f"module on_restore: text: {state.input['text']}")
+
+
+def app_ui(request: Request):
+    return ui.page_fluid(
+        mod_ui("mod1", "Module 1"),
+        mod_ui("mod2", "Module 2"),
+        ui.input_bookmark_button(),
+    )
+
+
+def server(input: Inputs, output: Outputs, session: Session):
+    mod_server("mod1")
+    mod_server("mod2")
+
+    @session.bookmark.on_bookmarked
+    async def _(url: str):
+        await session.bookmark.update_query_string(url)
+
+
+app = App(app_ui, server, bookmark_store="url")

tests/playwright/ai_generated_apps/bookmark_tests/input_checkbox/app-express.py

@@ -1,6 +1,6 @@
 from shiny.express import app_opts, input, module, render, session, ui
 
-app_opts(bookmark_store="url")
+app_opts(bookmark_store="url", debug=True)
 
 with ui.card():
     ui.card_header("Bookmarking Checkbox Demo")
@@ -30,7 +30,7 @@ def checkbox_text():
 
     checkbox_module("first")
 
-ui.input_bookmark_button(id="bookmark_button", label="Bookmark this page")
+ui.input_bookmark_button()
 
 
 @session.bookmark.on_bookmarked

tests/playwright/ai_generated_apps/bookmark_tests/input_checkbox/test_input_checkbox_core_express_bookmarking.py

@@ -33,9 +33,11 @@ def test_checkbox_demo(page: Page, app: ShinyAppProc) -> None:
     module_checkbox.expect_checked(True)
     module_text.expect_value("Checkbox value: True")
 
-    # Test bookmark button
-    bookmark_button = controller.InputActionButton(page, "bookmark_button")
-    bookmark_button.click()
+    # TODO-Karan: Implement bookmark button controller
+    # bookmark_button = controller.InputBookmarkButton(page)
+    # bookmark_button.click()
+
+    page.get_by_role("button", name="🔗 Bookmark...").click()
 
     # reload the page to test bookmark
     page.reload()

tests/playwright/ai_generated_apps/bookmark_tests/input_checkbox_group/app-express.py

@@ -38,7 +38,7 @@ def checkbox_text():
 
     checkbox_module("first")
 
-ui.input_bookmark_button(id="bookmark_button", label="Bookmark this page")
+ui.input_bookmark_button()
 
 
 @session.bookmark.on_bookmarked

tests/playwright/ai_generated_apps/bookmark_tests/input_checkbox_group/test_input_checkbox_group_core_express_bookmarking.py

@@ -0,0 +1,49 @@
+from playwright.sync_api import Page
+
+from shiny.playwright import controller
+from shiny.pytest import create_app_fixture
+from shiny.run import ShinyAppProc
+
+app = create_app_fixture(["app-express.py"])
+
+
+def test_checkbox_group_demo(page: Page, app: ShinyAppProc) -> None:
+    page.goto(app.url)
+
+    # Test basic checkbox group
+    basic_group = controller.InputCheckboxGroup(page, "basic")
+    basic_group.expect_label("Basic checkbox group")
+    basic_group.expect_selected([])
+
+    basic_text = controller.OutputText(page, "basic_text")
+    basic_text.expect_value("Checkbox group values: ()")
+
+    # Test module checkbox group
+    module_group = controller.InputCheckboxGroup(page, "first-module_checkbox")
+    module_group.expect_label("Module checkbox group")
+    module_group.expect_selected([])
+
+    module_text = controller.OutputText(page, "first-checkbox_text")
+    module_text.expect_value("Checkbox group values: ()")
+
+    # Select values
+    basic_group.set(["Option 1", "Option 3"])
+    basic_group.expect_selected(["Option 1", "Option 3"])
+    basic_text.expect_value("Checkbox group values: ('Option 1', 'Option 3')")
+
+    module_group.set(["Choice A", "Choice C"])
+    module_group.expect_selected(["Choice A", "Choice C"])
+    module_text.expect_value("Checkbox group values: ('Choice A', 'Choice C')")
+
+    # Bookmark the state
+    page.get_by_role("button", name="🔗 Bookmark...").click()
+
+    # Reload the page to test bookmark
+    page.reload()
+
+    # Check if selections are preserved
+    basic_group.expect_selected(["Option 1", "Option 3"])
+    basic_text.expect_value("Checkbox group values: ('Option 1', 'Option 3')")
+
+    module_group.expect_selected(["Choice A", "Choice C"])
+    module_text.expect_value("Checkbox group values: ('Choice A', 'Choice C')")

tests/playwright/ai_generated_apps/bookmark_tests/input_dark_mode/app-express.py

@@ -9,7 +9,7 @@
     ui.h3("Non-Module Section")
 
     # Basic dark mode toggle
-    ui.input_dark_mode(id="basic", label="Basic dark mode toggle")
+    ui.input_dark_mode(id="basic", label="Basic dark mode toggle", mode="dark")
 
     @render.text
     def basic_text():
@@ -22,15 +22,17 @@ def dark_mode_module(input, output, session):
         ui.h3("Dark Mode Module")
 
         # Module dark mode toggle
-        ui.input_dark_mode(id="module_dark_mode", label="Module dark mode toggle")
+        ui.input_dark_mode(
+            id="module_dark_mode", label="Module dark mode toggle", mode="dark"
+        )
 
         @render.text
         def dark_mode_text():
             return f"Dark mode value: {input.module_dark_mode()}"
 
     dark_mode_module("first")
 
-ui.input_bookmark_button(id="bookmark_button", label="Bookmark this page")
+ui.input_bookmark_button()
 
 
 @session.bookmark.on_bookmarked

tests/playwright/ai_generated_apps/bookmark_tests/input_dark_mode/test_input_dark_mode_core_express_bookmarking.py

@@ -0,0 +1,38 @@
+from playwright.sync_api import Page
+
+from shiny.playwright import controller
+from shiny.pytest import create_app_fixture
+from shiny.run import ShinyAppProc
+
+app = create_app_fixture(["app-express.py"])
+
+
+def test_dark_mode_demo(page: Page, app: ShinyAppProc) -> None:
+    page.goto(app.url)
+
+    # Test basic checkbox group
+    basic_dark_mode = controller.InputDarkMode(page, "basic")
+    basic_text = controller.OutputText(page, "basic_text")
+
+    basic_text.expect_value("Dark mode value: dark")
+
+    # Test module dark mode
+    module_group = controller.InputDarkMode(page, "first-module_dark_mode")
+    module_text = controller.OutputText(page, "first-dark_mode_text")
+
+    module_text.expect_value("Dark mode value: dark")
+
+    module_group.click()
+    basic_text.expect_value("Dark mode value: light")
+
+    # Bookmark the state
+    page.get_by_role("button", name="🔗 Bookmark...").click()
+
+    basic_dark_mode.click()
+    module_text.expect_value("Dark mode value: dark")
+
+    # Reload the page to test bookmark
+    page.reload()
+
+    basic_text.expect_value("Dark mode value: light")
+    module_text.expect_value("Dark mode value: light")

tests/playwright/ai_generated_apps/bookmark_tests/input_date/app-express.py

@@ -12,6 +12,7 @@
     ui.input_date(
         id="basic",
         label="Basic date input",
+        value="2024-01-01",
     )
 
     @render.text
@@ -28,6 +29,7 @@ def date_module(input, output, session):
         ui.input_date(
             id="module_date",
             label="Module date input",
+            value="2024-01-01",
         )
 
         @render.text
@@ -36,7 +38,7 @@ def date_text():
 
     date_module("first")
 
-ui.input_bookmark_button(id="bookmark_button", label="Bookmark this page")
+ui.input_bookmark_button()
 
 
 @session.bookmark.on_bookmarked