Skip to content

Commit 69991d3

Browse files
Merge branch 'main' into decouple-select-selectize
2 parents c3107d3 + 58e82de commit 69991d3

File tree

6 files changed

+7
-6220
lines changed

6 files changed

+7
-6220
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@ _dev/
116116
tests/playwright/deploys/**/requirements.txt
117117
test-results/
118118
shiny_bookmarks/
119+
.posit/
119120

120121
# setuptools_scm
121122
shiny/_version.py

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ dev = [
100100
"isort>=5.10.1",
101101
"libsass>=0.23.0",
102102
"brand_yml>=0.1.0",
103-
"pyright>=1.1.383,<1.1.395",
103+
"pyright>=1.1.398",
104104
"pre-commit>=2.15.0",
105105
"wheel",
106106
"matplotlib",

shiny/_app.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from typing import Any, Callable, Literal, Mapping, Optional, TypeVar, cast
1010

1111
import starlette.applications
12-
import starlette.exceptions
1312
import starlette.middleware
1413
import starlette.routing
1514
import starlette.websockets

shiny/ui/_page.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
)
1515

1616
from copy import copy
17-
from typing import Any, Callable, Literal, Optional, Sequence, cast
17+
from typing import Any, Callable, Literal, Optional, Sequence
1818

1919
from htmltools import (
2020
MetadataNode,
@@ -752,7 +752,6 @@ def page_auto(
752752
)
753753

754754
# If we got here, _page_fn is not None, but the type checker needs a little help.
755-
page_fn = cast(Callable[..., Tag], page_fn)
756755
return page_fn(*args, **kwargs)
757756

758757

tests/playwright/shiny/bookmark/chat/client_state/test_bookmark_chat.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
import re
22

3+
import pytest
34
from playwright.sync_api import Page
45

56
from shiny.playwright.controller import Chat
67
from shiny.run import ShinyAppProc
78

89

9-
def test_bookmark_chatlas(page: Page, local_app: ShinyAppProc):
10+
# Up to 5 retries for intermittent WebKit timing issues
11+
@pytest.mark.flaky(reruns=5, reruns_delay=1)
12+
def test_bookmark_chat(page: Page, local_app: ShinyAppProc):
1013

1114
page.goto(local_app.url)
1215

0 commit comments

Comments
 (0)