Skip to content

Commit 6c6f8a2

Browse files
committed
Updating
1 parent 3de5e2f commit 6c6f8a2

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5353

5454
### Bug fixes
5555

56-
* Fixed several issues related to including custom js and css files
57-
* JS and CSS file loaded with `include_js()` or `include_css()` will be loaded into a new temporary directory and cleaned up properly on program exit. (#2061)
58-
* JS and CSS files in the same directory will be loaded correctly. (#729)
59-
6056
* Fixed numerous issues related to programmatically updating selectize options. (#2053)
6157
* `update_selectize(options=...)` no longer gets ignored when `server=False` (the default).
6258
* `update_selectize(options=...)` now works as expected in a module.
@@ -77,6 +73,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7773

7874
* `include_js()` and `include_css()` now correctly handle file permissions in multi-user settings. (#2061)
7975

76+
* Temporary directories/files created for HTML dependencies will be cleaned up on App object deletion (#2079)
77+
8078
### Deprecations
8179

8280
* `ui.update_navs()` has been deprecated in favor of `ui.update_navset()`. (#2047)

shiny/_app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ def _cleanup_temp_source_dirs(deps: list[HTMLDependency]) -> None:
233233
# the (system-wide) temp directory, we should remove it.
234234
current_temp_dir = os.path.realpath(tempfile.gettempdir())
235235
for dep in deps:
236-
src = dep.source_path_map()["source"]
236+
src = dep.source.get("subdir") if dep.source else None
237237
if not src:
238238
continue
239239
src = os.path.realpath(src)

0 commit comments

Comments
 (0)